Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: subvertpy - Python bindings for Subversion
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Summary: Review Request: subvertpy - Python bindings for Subversion Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fabian@bernewireless.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/subvertpy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/subvertpy-0.7.2-1.fc13.src.rpm
Project URL: http://samba.org/~jelmer/subvertpy/
Description: Alternative Python bindings for Subversion, split out from bzr-svn. The goal is to have complete, portable and "Pythonic" Python bindings.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2276232
rpmlint output: [fab@laptop011 SRPMS]$ rpmlint subvertpy-0.7.2-1.fc13.src.rpm subvertpy.src: W: spelling-error %description -l en_US bzr -> br, bar, brr subvertpy.src: W: spelling-error %description -l en_US svn -> avn, sen, sin 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[fab@laptop011 x86_64]$ rpmlint subvertpy* subvertpy.x86_64: W: spelling-error %description -l en_US bzr -> br, bar, brr subvertpy.x86_64: W: spelling-error %description -l en_US svn -> avn, sen, sin subvertpy.x86_64: W: no-manual-page-for-binary subvertpy-fast-export 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |608512
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |subvertpy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Chen Lei supercyper1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@gmail.com
--- Comment #1 from Chen Lei supercyper1@gmail.com 2010-06-27 23:10:10 EDT --- Some suggustions:
1.name subvertpy -> python-subvertpy I'll better to use python before module namespace, those in some special case py can be omitted.
2.Group: Development/Languages -> Group: Development/Libraries See http://en.opensuse.org/Packaging/SUSE_Package_Conventions/RPM_Groups
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #2 from Chen Lei supercyper1@gmail.com 2010-06-27 23:15:37 EDT --- s/those/though
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #3 from Fabian Affolter fabian@bernewireless.net 2010-06-28 11:02:33 EDT --- (In reply to comment #1)
1.name subvertpy -> python-subvertpy I'll better to use python before module namespace, those in some special case py can be omitted.
The naming guidelines says if there is "py" in the name, the name is fine for a python module. There is no statement about the position of "py" and common practice (numpy, scapy, etc.) to place "py" at the end of the name.
2.Group: Development/Languages -> Group: Development/Libraries See http://en.opensuse.org/Packaging/SUSE_Package_Conventions/RPM_Groups
I will change that. Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #4 from Chen Lei supercyper1@gmail.com 2010-06-28 12:44:11 EDT --- (In reply to comment #3)
(In reply to comment #1)
1.name subvertpy -> python-subvertpy I'll better to use python before module namespace, those in some special case py can be omitted.
The naming guidelines says if there is "py" in the name, the name is fine for a python module. There is no statement about the position of "py" and common practice (numpy, scapy, etc.) to place "py" at the end of the name.
Yep, the naming convention is inconsistency, no guideline object this. But more *py packages add python before module names.
See http://koji.fedoraproject.org/koji/search?match=glob&type=package&te... See http://koji.fedoraproject.org/koji/search?match=glob&type=package&te...
When considering python3 naming guideline, It'll be better to add python before $NAME to keep consistency with python3.
From naming guideline:
This makes a package name format of python-$NAME. When in doubt, use the name of the module that you type to import it in a script.
I think if py* packages don't have py in their namespace, then we can omit python( e.g. pygtk2), in other case, adding python will be more appropriate.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #5 from Fabian Affolter fabian@bernewireless.net 2010-11-18 06:17:12 EST --- I will rename the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #6 from Fabian Affolter fabian@bernewireless.net 2010-11-20 08:05:35 EST --- * Sat Nov 20 2010 Fabian Affolter fabian@bernewireless.net - 0.7.5-1 - Changed the filtering stuff to get rid of private-shared-object-provides - Added the tests (at the moment all failed) - Renamed the package
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy-0.7.5-1.fc14.src...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |python-subvertpy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2010-11-25 10:28:36 EST --- FYI, the tests run fine with this:
%check cd build/*/subvertpy/tests PYTHONPATH=.. nosetests test*.py
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #8 from Fabian Affolter fabian@bernewireless.net 2010-11-25 17:25:19 EST --- (In reply to comment #7)
FYI, the tests run fine with this:
Thanks
* Thu Nov 25 2010 Fabian Affolter fabian@bernewireless.net - 0.7.5-2 - Check section fixed
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy-0.7.5-2.fc14.src...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|subvertpy |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: subvertpy - |Review Request: |Python bindings for |python-subvertpy - Python |Subversion |bindings for Subversion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #9 from Jason Tibbitts tibbs@math.uh.edu 2010-12-01 18:52:25 EST --- While reviewing this I noticed that you've submitted around 138 packages (158 minus about 20 duplicates and reviews that were closed for various reasons) while reviewing only 38. Since I have no package submissions pending, would you consider doing the courtesy of reviewing someone else's package? If you do, I'll look at some of your other pending submissions.
Builds fine; rpmlint complains only about the lack of a manpage for subvertpy-fast-export.
I'm afraid I don't understand why the tests directory is part of the final package. What purpose does it serve?
* source files match upstream. sha256sum: c43782ef281f347a1c4fe02e5cab4dd361fe228a6c3186f2d76ec01daca9bb5e subvertpy-0.7.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: python-subvertpy = 0.7.5-2.fc15 python-subvertpy(x86-64) = 0.7.5-2.fc15 = libapr-1.so.0()(64bit) libpython2.7.so.1.0()(64bit) libsvn_client-1.so.0()(64bit) libsvn_delta-1.so.0()(64bit) libsvn_fs-1.so.0()(64bit) libsvn_ra-1.so.0()(64bit) libsvn_repos-1.so.0()(64bit) libsvn_subr-1.so.0()(64bit) libsvn_wc-1.so.0()(64bit) python(abi) = 2.7 /usr/bin/python
* %check is present and all tests pass: Ran 129 tests in 25.772s OK * no bundled libraries. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no static libraries. * no libtool .la files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #10 from Fabian Affolter fabian@bernewireless.net 2011-03-28 15:15:48 EDT --- (In reply to comment #9)
While reviewing this I noticed that you've submitted around 138 packages (158 minus about 20 duplicates and reviews that were closed for various reasons) while reviewing only 38. Since I have no package submissions pending, would you consider doing the courtesy of reviewing someone else's package? If you do, I'll look at some of your other pending submissions.
I started to adjust the mismatch of reviews and review request but this will take a while.
I'm afraid I don't understand why the tests directory is part of the final package. What purpose does it serve?
Well, the tests are not needed in the final package.
Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/subvertpy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy-0.8.0-1.fc14.src...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #11 from Fabian Affolter mail@fabian-affolter.ch 2011-11-26 07:24:27 EST --- * Sat Nov 26 2011 Fabian Affolter mail@fabian-affolter.ch - 0.8.9-1 - Updated to new upstream release 0.8.9
Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy-0.8.9-1.fc16.src...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #12 from Fabian Affolter mail@fabian-affolter.ch 2012-03-04 12:32:17 EST --- * Sun Mar 04 2012 Fabian Affolter mail@fabian-affolter.ch - 0.8.10-1 - Updated to new upstream release 0.8.10
Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-subvertpy-0.8.10-1.fc16.sr...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@matthias-runge.de
--- Comment #13 from Matthias Runge mrunge@matthias-runge.de 2012-04-10 05:37:32 EDT --- Jason, any progress here? May I jump in?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608509
--- Comment #14 from Jason Tibbitts tibbs@math.uh.edu 2012-04-10 10:15:59 EDT --- Hmm, honestly I didn't notice the updates that came nearly five months after my initial review. Let me take a look.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla