[Bug 2189641] New: Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Bug ID: 2189641
           Summary: Review Request: golang-github-pin-tftp-3 - TFTP server
                    and client library for Golang
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fed...
Description: TFTP server and client library for Golang
Fedora Account System Username: mavjs

Here is a build in copr:
https://copr.fedorainfracloud.org/coprs/mavjs/package-reviews/build/5849303/

This package is required to update gobuster to latest stable version: v3.5.0
Current gobuster package version in Fedora is currently at: v3.1.0

Note: I am not a fedora packager yet and will require a sponsor.

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Maverick Kaung  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Pavel Solovev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]

--- Comment #1 from Pavel Solovev  ---
> golang-github-pin-tftp.spec

The filename of spec MUST match the name of the package. Rename to
golang-github-pin-tftp-3.spec
> %global forgeurl1	https://github.com/pin/tftp

Isn't really needed, it is deduced automatically

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

--- Comment #2 from Maverick Kaung  ---
(In reply to Pavel Solovev from comment #1)
> > golang-github-pin-tftp.spec
>
> The filename of spec MUST match the name of the package. Rename to
> golang-github-pin-tftp-3.spec

Done. See new build link below.
> > %global forgeurl1	https://github.com/pin/tftp
>
> Isn't really needed, it is deduced automatically

This was removed as well.

Note: I deleted the previous builds and therefore, here are the new links:

SPEC URL:
https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fed...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mavjs/package-reviews/fed...
COPR URL:
https://copr.fedorainfracloud.org/coprs/mavjs/package-reviews/build/5852501/

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Pavel Solovev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Pavel Solovev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #3 from Pavel Solovev  ---
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is
justified.
- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] The latest version is packaged.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these
by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the
Bodhi ticket.

Thanks!

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

--- Comment #4 from Pavel Solovev  ---
Ah, and the last thing - on import, remove the `-f` flag from %gometa, gobuster
is still
built for i386.

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

--- Comment #5 from Maverick Kaung  ---
(In reply to Pavel Solovev from comment #4)
> Ah, and the last thing - on import, remove the `-f` flag from %gometa,
> gobuster is still
> built for i386.

Will do. Thanks for the review.

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Debarshi Ray  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Debarshi Ray  ---
Maverick, I see that you are already a member of the 'packager' group:
https://accounts.fedoraproject.org/user/mavjs/

Do you still need a sponsor?

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Debarshi Ray  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Maverick Kaung  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |)                           |

--- Comment #7 from Maverick Kaung  ---
(In reply to Debarshi Ray from comment #6)
> Maverick, I see that you are already a member of the 'packager' group:
> https://accounts.fedoraproject.org/user/mavjs/
>
> Do you still need a sponsor?

Hey rishi, thanks for reaching out (via email as well).
I got sponsored by nirik (Kevin). I just need to follow up with the steps to
continue.

-Maverick

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

--- Comment #8 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-pin-tftp-3

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-b80d36465b has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-b80d36465b

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-05-26 18:31:31

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-b80d36465b has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

Michal Ambroz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2133290

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2133290
[Bug 2133290] gobuster-3.5.0 is available

[Bug 2189641] Review Request: golang-github-pin-tftp-3 - TFTP server and client library for Golang

https://bugzilla.redhat.com/show_bug.cgi?id=2189641

--- Comment #11 from Michal Ambroz  ---
Hello,
this package is needed for the gobuster 3.5.0 -
https://src.fedoraproject.org/rpms/gobuster
Please would you mind building the golang-github-pin-tftp-3 also for the F38
F37 ?
Thank you
Michal Ambroz