[Bug 2042375] New: Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Bug ID: 2042375
           Summary: Review Request: gpu-trace -  Simple script to collect
                    GPU traces
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://raw.githubusercontent.com/dorindabassey/gpu-trace/5e6cc2fe35ffec7c63...
SRPM URL:
https://github.com/dorindabassey/gpu-trace/blob/master/rpm/gpu-trace-2.7-1.f...
Description: gpu-trace is a tool intended to aid the collection process of
gpuvis traces.
Fedora Account System Username: dorinda

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

--- Comment #1 from Dorinda  ---
koji scratch build
f34 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445554
rawhide https://koji.fedoraproject.org/koji/taskinfo?taskID=81445905
f35 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445665
f36 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445869
epel8 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445546
epel9 https://koji.fedoraproject.org/koji/taskinfo?taskID=81445498

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://raw.githubusercontent.com/dorindabassey/gpu-trace/5e6cc2fe35ffec7c63...
SRPM URL:
https://github.com/dorindabassey/gpu-trace/blob/master/rpm/gpu-trace-2.7-1.f...
Description: gpu-trace is a tool intended to aid the collection process of
gpuvis traces.
Fedora Account System Username: dorinda

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://raw.githubusercontent.com/dorindabassey/gpu-trace/5e6cc2fe35ffec7c63...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-...
Description: gpu-trace is a tool intended to aid the collection process of
gpuvis traces.
Fedora Account System Username: dorinda

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Pierre-YvesChibon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

needinfo canceled: [Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

Product: Fedora
Version: rawhide
Component: Package Review

Dorinda  has canceled Package Review
's request for Dorinda
's needinfo:
Bug 2042375: Review Request: gpu-trace -  Simple script to collect GPU traces
https://bugzilla.redhat.com/show_bug.cgi?id=2042375

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Sandro Bonazzola  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|unspecified                 |medium
           Assignee|[e-mail]    |[e-mail]

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Xavier Bachelot  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

--- Comment #3 from Dorinda  ---
updated the spec file and srpm, here's the link to copr builds 
https://copr.fedorainfracloud.org/coprs/dorinda/gpu-trace/build/7242489/

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Sandro Bonazzola  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #4 from Sandro Bonazzola  ---
(In reply to Dorinda from comment #3)
> updated the spec file and srpm, here's the link to copr builds 
> https://copr.fedorainfracloud.org/coprs/dorinda/gpu-trace/build/7242489/

Thanks Dorinda, can you please update comment #0 with the new SPEC and SRPM
url?

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace....
SRPM URL:
https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-...
Description: gpu-trace is a tool intended to aid the collection process of
gpuvis traces.
Fedora Account System Username: dorinda

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #5 from Dorinda  ---
seems the update i made previously wasn't applied, updated now thanks :)

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Sandro Bonazzola  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #6 from Sandro Bonazzola  ---
Fedora review tool is failing as the src.rpm provided is fc39 and it's looking
for a fc41 build.
Can you rebuild for Rawhide and update accordingly comment #0?

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace....
SRPM URL:
https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-...
Description: gpu-trace is a tool intended to aid the collection process of
gpuvis traces.
Fedora Account System Username: dorinda

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

--- Comment #7 from Sandro Bonazzola  ---
A first issue is Source0 URL within the spec file is broken.
Could not download Source0:
https://github.com/lostgoat/gpu-trace/archive/refs/tags/gpu-trace-2.12.tar.g...

The correct download address seems to be
https://github.com/lostgoat/gpu-trace/archive/refs/tags/v2.12.tar.gz

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

--- Comment #8 from Xavier Bachelot  ---
You don't need to update first comment, just post a new comment with new Spec
URL: and SRPM URL: lines, this will be picked up by the fedora review bot.

Also, correct URL for Source0 is :
https://github.com/lostgoat/gpu-trace/archive/v2.12/gpu-trace-2.12.tar.gz
which translates to:
Source0:
https://github.com/lostgoat/gpu-trace/archive/v%%7Bversion%7D-%%7Bname%7D-%%...

See
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_ta...

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

--- Comment #9 from Xavier Bachelot  ---
Sorry typo above, should read:
Source0:
https://github.com/lostgoat/gpu-trace/archive/v%%7Bversion%7D/%%7Bname%7D-%%...

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #10 from Dorinda  ---
Spec URL:
https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace....
SRPM URL:
https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-...
Description: gpu-trace is a tool intended to aid the collection process of
gpuvis traces.
Fedora Account System Username: dorinda

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

--- Comment #11 from Dorinda  ---
Spec Url:
https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace....
SRPM URL:
https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-...

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

Dorinda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://copr-dist-git.fedorainfracloud.org/cgit/dorinda/gpu-trace/gpu-trace....
SRPM URL:
https://download.copr.fedorainfracloud.org/results/dorinda/gpu-trace/fedora-...
Description: gpu-trace is a tool intended to aid the collection process of
gpuvis traces.
Fedora Account System Username: dorinda

[Bug 2042375] Review Request: gpu-trace - Simple script to collect GPU traces

https://bugzilla.redhat.com/show_bug.cgi?id=2042375

--- Comment #12 from Sandro Bonazzola  ---
Looking at the spec file, I see:

BuildRequires:  make
 BuildRequires:  gcc  systemd-rpm-macros

But there's no need for gcc, nothing to be compiled there.

There's a SystemD unit shipped in the package but it's not properly handled
within the spec file.
Please refer to:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...
on how to handle SystemD units.
I also think systemd should be in Requires.

You can also use `%_systemd_util_dir` instead of hardcoding the systemd path in
`export SYSTEMD_SERVICE_PATH=/usr/lib/systemd`

Looking at the upstream code, I see calls to `sudo`, `logname`, `gpuvis`,
`perf`, `trace-cmd`.
Requires on their existence are missing.

Looks like there's no package providing `gpuvis` command, perhaps you need to
package that one as well?

As it brings up a rpc service socket listening on rpcServerPort = 47317 you may
want to provide a firewalld service file as well to make it easy granting
access to that port.