Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Bug ID: 903768 Summary: Review Request: php-PhpCollection - General purpose collection library for PHP Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: shawn.iwinski@gmail.com
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpCollection.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpCollection-0.1.0-1.fc...
Description: This library adds basic collections for PHP.
Collections can be seen as more specialized arrays for which certain contracts are guaranteed.
Supported Collections: * Sequences ** Keys: numerical, consequentially increasing, no gaps ** Values: anything, duplicates allowed ** Classes: Sequence, SortedSequence * Maps ** Keys: strings or objects, duplicate keys not allowed ** Values: anything, duplicates allowed ** Classes: Map, ObjectMap (not yet implemented) * Sets (not yet implemented) ** Keys: not meaningful ** Values: anything, each value must be unique (===) ** Classes: Set
General Characteristics: * Collections are mutable (new elements may be added, existing elements may be modified or removed). Specialized immutable versions may be added in the future though. * Equality comparison between elements are always performed using the shallow comparison operator (===). * Sorting algorithms are unstable, that means the order for equal elements is undefined (the default, and only PHP behavior).
Fedora Account System Username: siwinski
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com Depends On| |903766 (php-PhpOption) Alias| |php-PhpCollection
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Bug 903768 depends on bug 903766, which changed state.
Bug 903766 Summary: Review Request: php-PhpOption - Option type for PHP https://bugzilla.redhat.com/show_bug.cgi?id=903766
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Created attachment 707764 --> https://bugzilla.redhat.com/attachment.cgi?id=707764&action=edit phpci.log
phpci version 2.13.2.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 707765 --> https://bugzilla.redhat.com/attachment.cgi?id=707765&action=edit review.txt
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 903768
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Remi Collet fedora@famillecollet.com --- [!]: Latest version is packaged. version 0.2.0 is tagged in guthub.
No blocker
=== APPROVED ===
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ | Flags| |fedora-review?
--- Comment #4 from Remi Collet fedora@famillecollet.com --- Sorry to have miss the License issue.
LICENSE is Apache 2.0: OK. doc/LICENSE is BY-NC-ND (http://jmsyst.com/libs/parser-lib), this only apply to documentation (not provided in the rpm, but present in the src.rpm)...
As BY-NC-ND is explicitly rejected for fedora https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Bad_Licenses_3
you have to strip the doc folder from upstream tarball.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #5 from Shawn Iwinski shawn.iwinski@gmail.com --- Spec changes: https://github.com/siwinski/rpms/commit/d57357672db2f920dabf5491fc5e45fdc81b...
SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-PhpCollection.spec
SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-PhpCollection-0.2.0-1.fc...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Remi Collet fedora@famillecollet.com --- LICENSE issue fixed
== APPROVED (again) ==
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #7 from Remi Collet fedora@famillecollet.com --- Please add php-PhpCollection-strip.sh as Source1.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #8 from Shawn Iwinski shawn.iwinski@gmail.com --- (In reply to comment #7)
Please add php-PhpCollection-strip.sh as Source1.
Shoot! I actually meant to do that. I will add that after initial import.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Shawn Iwinski shawn.iwinski@gmail.com --- THANKS for the review!
New Package SCM Request ======================= Package Name: php-PhpCollection Short Description: General purpose collection library for PHP Owners: siwinski Branches: f18 f19 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-PhpCollection-0.2.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-PhpCollection-0.2.0-2.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-PhpCollection-0.2.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-PhpCollection-0.2.0-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-PhpCollection-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-03-28 21:35:56
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-PhpCollection-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903768
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-PhpCollection-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org