[Bug 1611598] New: Review Request: tendrl-node-agent - A python agent local to every managed storage node in the sds cluster for tendrl

https://bugzilla.redhat.com/show_bug.cgi?id=1611598

Bug ID: 1611598
           Summary: Review Request: tendrl-node-agent - A python agent
                    local to every managed storage node in the sds cluster
                    for tendrl
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/tendrl/release/epel-7-x86_64...
https://github.com/Tendrl/node-agent/blob/master/tendrl-node-agent.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tendrl/release/epel-7-x86_64...

Github url: https://github.com/Tendrl/node-agent

Description: Hi I have finished packaging up tendrl-node-agent.
Tendrl node agent resides on every node managed by tendrl. It is responsible
for operating system level operations such as hardware inventory, service
management, process monitoring etc. The node agent also serves as the
provisioning controller and can invoke provisioning operations on the node.

I would appreciate a review so that I can get it into Fedora Extras!.
Thank you!

Fedora Account System Username: timothyasir

[Bug 1611598] Review Request: tendrl-node-agent - A python agent local to every managed storage node in the sds cluster for tendrl

https://bugzilla.redhat.com/show_bug.cgi?id=1611598

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Robert-André Mauchin  ---
 - %{__python} setup.py build → %py3_build

- %{__python} setup.py install --single-version-externally-managed -O1
--root=$RPM_BUILD_ROOT → %py3_install

- Source0 must point to a URL

- Package must be Python3, you mist not require python-X package as this is
deprecated. Python 2 is also deprecated.

- If you install systemd files you must require:

%{?systemd_requires}
BuildRequires: systemd

- Keep timestamps with install-p

- These permissions are not standard, please provide rationale. It should be
0644

%attr(0655, root, root) %{_sysconfdir}/collectd_template/*
%attr(0655, root, root) %{_libdir}/collectd/*

- Add your own %changelog entry