[Bug 2221357] New: Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers

https://bugzilla.redhat.com/show_bug.cgi?id=2221357

Bug ID: 2221357
           Summary: Review Request: rust-archery - Abstract over the
                    atomicity of reference-counting pointers
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://mattia.fedorapeople.org/rust-archery/rust-archery.spec
SRPM URL:
https://mattia.fedorapeople.org/rust-archery/rust-archery-0.5.0-1.fc39.src.r...
Description: Abstract over the atomicity of reference-counting pointers
Fedora Account System Username: mattia

[Bug 2221357] Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers

https://bugzilla.redhat.com/show_bug.cgi?id=2221357

Mattia Verga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2179260
           Doc Type|---                         |If docs needed, set a value

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2179260
[Bug 2179260] python-jsonschema-spec-0.2.2 is available

[Bug 2221357] Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers

https://bugzilla.redhat.com/show_bug.cgi?id=2221357

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |POST
              Flags|                            |fedora-review+

--- Comment #1 from Fabio Valentini  ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Minor nit-pick: Please add a comment to the Patch in the spec file (something
like "criterion dependency is used only for running benchmarks, which does not
happen during package builds, tests that use compiletest_rs are not included in
published sources, ...).

Hint for future Rust packages: I strongly recommend using rust2rpm's "-p" flag
for patching Cargo.toml files. This happens so frequently that it's mostly
automated. Also, some changes to Cargo.toml metadata will trigger changes to
how the spec file is generated, so making these changes manually *after* the
spec is already generated will lead to a spec file that is out of sync with the
actual package contents. When using "rust2rpm -p", changes to Cargo.toml are
taken into account when generating the spec file.

Hint number two: Use the "-s" flag for rust2rpm. It saves you from having to
run "spectool -g" separately. :)

Welcome to Rust packaging! 😅

[Bug 2221357] Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers

https://bugzilla.redhat.com/show_bug.cgi?id=2221357

--- Comment #2 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-archery

[Bug 2221357] Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers

https://bugzilla.redhat.com/show_bug.cgi?id=2221357

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #3 from Fedora Update System  ---
FEDORA-2023-116d7f2bb7 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-116d7f2bb7

[Bug 2221357] Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers

https://bugzilla.redhat.com/show_bug.cgi?id=2221357

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-07-08 12:00:54

--- Comment #4 from Fedora Update System  ---
FEDORA-2023-116d7f2bb7 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.