[Bug 1246120] New: Review Request: atomic-reactor - Improved builder for Docker images - package-review

List overview All Threads
Download

newer

[Bug 1246120] New: Review Request: atomic-reactor - Improved builder for Docker images

older

[Bug 1294341] New: Review Request:...

[Bug 1291225] New: Review Request:...

Red Hat Bugzilla

23 Jul 2015 23 Jul '15

8:32 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Bug ID: 1246120 Summary: Review Request: atomic-reactor - Improved builder for Docker images Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: bkabrda@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor.spec SRPM URL: https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor-1.4.0-1.... Description: Simple Python tool with command line interface for building Docker images. It contains a lot of helpful functions which you would probably implement if you started hooking Docker into your infrastructure. Fedora Account System Username: bkabrda

Note: This package was previously called dock and dock is already in Fedora. This is in fact a rename.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

23 Jul 23 Jul

8:33 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1245521

--- Comment #1 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Note: atomic-reactor can now be built, but won't actually run until bug 1245521 is fixed.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1245521 [Bug 1245521] docker-py gets broken by old python-websocket-client version

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Jul 27 Jul

2:13 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Michal Cyprian mcyprian@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:15 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Michal Cyprian mcyprian@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mcyprian@redhat.com

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:53 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

--- Comment #2 from Michal Cyprian mcyprian@redhat.com --- * There is non executable script /usr/share/atomic-reactor/images/privileged-builder/docker.sh with permissions 644. * The lastest revision of Packaging Guidelines:Python don't recommend to use macro %{py3dir}. * License of the package and license field in spec are alright. * Package was compiled and build successfully. * import of atomic_reactor module is working properly in both python2 and python3 subpackages. * It is still not possible to run it as you have already noticed.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

28 Jul 28 Jul

2:40 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

--- Comment #3 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Thanks for the review. Please see my comments inline:

(In reply to Michal Cyprian from comment #2)

...

There is non executable script

/usr/share/atomic-reactor/images/privileged-builder/docker.sh with permissions 644.

As a comment on line 239 notes, this file is not executable since it's not meant for direct use on user's system, but should only be used in a container (therefore the 644 privileges defend user from making unwanted harm). So hopefully, this is ok.

...

The lastest revision of Packaging Guidelines:Python don't recommend to use

macro %{py3dir}.

Fixed (I just don't use separate dirs for py3 build any more, which should be correct and still work).

...

License of the package and license field in spec are alright.

Package was compiled and build successfully.

import of atomic_reactor module is working properly in both python2 and

python3 subpackages.

It is still not possible to run it as you have already noticed.

Since fixing bug 1245523 makes python-docker-py work again (until it's fixed properly as requested in bug 1245521), it should work now.

Spec URL: https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor.spec SRPM URL: https://bkabrda.fedorapeople.org/pkgs/atomic-reactor/atomic-reactor-1.4.0-2....

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:42 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bug 1246120 depends on bug 1245521, which changed state.

Bug 1245521 Summary: docker-py gets broken by old python-websocket-client version https://bugzilla.redhat.com/show_bug.cgi?id=1245521

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:28 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Michal Cyprian mcyprian@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #4 from Michal Cyprian mcyprian@redhat.com --- Everything seems to be alright now, It is possible to run it when python-websocket-client-0.32.0 is installed.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:55 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #5 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Great, thanks for your review!

New Package SCM Request ======================= Package Name: atomic-reactor Short Description: Improved builder for Docker images Upstream URL: https://github.com/projectatomic/atomic-reactor Owners: bkabrda ttomecek Branches: f22 f23 epel7 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:14 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:14 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:34 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

--- Comment #7 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Note: this can't be built for epel7 now because of bug 1192534 comment 13. I'll leave this bug open and close it when f22, f23, rawhide and epel7 are built and gone through testing.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:50 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:53 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- atomic-reactor-1.4.0-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/atomic-reactor-1.4.0-2.fc22

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Jul 29 Jul

7:53 p.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- Package atomic-reactor-1.4.0-2.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing atomic-reactor-1.4.0-2.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-12144/atomic-reactor-1.4... then log in and leave karma (feedback).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Aug 3 Aug

8:40 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1249651

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1249651 [Bug 1249651] docker-py gets broken by old python-requests version

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Aug 7 Aug

8:17 a.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120

Fedora Update System updates@fedoraproject.org changed:

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- atomic-reactor-1.4.0-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Jan 7 Jan

3:44 p.m.

New subject: [Bug 1246120] Review Request: atomic-reactor - Improved builder for Docker images

https://bugzilla.redhat.com/show_bug.cgi?id=1246120 Bug 1246120 depends on bug 1249651, which changed state.

Bug 1249651 Summary: docker-py gets broken by old python-requests version https://bugzilla.redhat.com/show_bug.cgi?id=1249651

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3484

Age (days ago)

3652

Last active (days ago)

package-review@lists.fedoraproject.org

17 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla