[Bug 769609] New: Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Summary: Review Request: device-mapper-persistent-data - device-mapper thin provisioning tools Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mbroz@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://mbroz.fedorapeople.org/thinp/device-mapper-persistent-data.spec SRPM URL: http://mbroz.fedorapeople.org/thinp/device-mapper-persistent-data-0.0.1-1.fc... Description: thin-provisioning-tools contains dump,restore and repair tools to manage device-mapper thin provisioning target metadata devices.
Notes: - package will later contain tools for another targets (like hierarchical storage management) that's why there is such generic name.
- rpmlint E: description-line-too-long C This package provides debug information for package device-mapper-persistent-data. - filled bug #768393
- upstream tar location will perhaps change in future (removing URL warning) and will include pre-generated autoconf files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mmaslano@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #1 from Marcela Mašláňová mmaslano@redhat.com 2011-12-21 08:56:07 EST --- [!]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. jthornber-thin-provisioning-tools-0.0.1-0-g4dcab4b.tar.gz : MD5SUM this package : 31920fb9428b9a02b7e2b5681fd287fc MD5SUM upstream package : upstream source not found
The source should be placed somewhere.
Instead of macros define, there should be used global. The global will work even in EL-6.
Upstream comment: * in build.log is mentioned: configure: WARNING: unrecognized options: --disable-dependency-tracking
The only real problem is missing source, when will you upload it somewhere?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #2 from Milan Broz mbroz@redhat.com 2011-12-21 09:31:05 EST --- comment in spec: # The source for this package was pulled from upstream's git. # Use the following URL to access the tarball: # https://github.com/jthornber/thin-provisioning-tools/tarball/%%%7Bversion%7D
So https://github.com/jthornber/thin-provisioning-tools/tarball/0.0.1 will redirect to tar.gz download used in the srpm.
unfortunately, github doesn't provide better way to access it (usable directly in Source0:)
I hope Joe will place tar so some better location in future.
global - yes, will change that.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #3 from Marcela Mašláňová mmaslano@redhat.com 2011-12-21 10:00:09 EST --- Bad github.
Ok, conditionally APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Milan Broz mbroz@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Milan Broz mbroz@redhat.com 2011-12-21 10:21:52 EST --- New Package SCM Request ======================= Package Name: device-mapper-persistent-data Short Description: device-mapper persistent data tools Owners: lvm-team mbroz agk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2011-12-21 10:22:53 EST --- lvm-team is not in the packager group.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Milan Broz mbroz@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Milan Broz mbroz@redhat.com 2011-12-21 10:28:56 EST --- It is group account, I think it cannot be in packager group.... see lvm2 package, lvm-team is the owner, here should be the same
If it is not possible, please use me as the owner and I let Alasdair to complain somewhere, it is his idea to use lvm-team :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #7 from Jon Ciesla limburgher@gmail.com 2011-12-21 10:51:10 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limburgher@gmail.com
--- Comment #8 from Jon Ciesla limburgher@gmail.com 2011-12-21 10:53:05 EST --- I think I've managed to do what you want. -ish.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(limburgher@gmail. | |com)
--- Comment #9 from Marcela Mašláňová mmaslano@redhat.com 2011-12-21 10:56:57 EST --- (In reply to comment #8)
I think I've managed to do what you want. -ish.
Hehe, now I am new maintainer. I assure you that I know nothing about device-mapper.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(limburgher@gmail. | |com) |
--- Comment #10 from Jon Ciesla limburgher@gmail.com 2011-12-21 11:10:59 EST --- Do'h. I misread the comments. Marcela, if you orphan in pkgdb, Milan can take it. Sorry. :(
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
Milan Broz mbroz@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2011-12-21 11:36:53
--- Comment #11 from Milan Broz mbroz@redhat.com 2011-12-21 11:36:53 EST --- np, we fixed that already, thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #12 from Alasdair Kergon agk@redhat.com 2011-12-21 20:48:01 EST --- The owner still needs changing to lvm-team so that bugzilla can pick up the correct mailing list owner: you'll probably need to open a ticket to request that. (spot wouldn't allow us to log in directly using the lvm-team account to set up things like that.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #13 from Alasdair Kergon agk@redhat.com 2011-12-21 20:52:14 EST --- BTW Although it's not currently 'critical path', it will become so in due course.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769609
--- Comment #14 from Jon Ciesla limburgher@gmail.com 2011-12-22 08:38:23 EST --- Fixed.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla