https://bugzilla.redhat.com/show_bug.cgi?id=1268369
Bug ID: 1268369 Summary: Review Request: rubygem-http_parser.rb - Simple callback-based HTTP request/response parser Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ilya.gradina@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-http_p... SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-http_p... Description: Ruby bindings to http://github.com/ry/http-parser and http://github.com/a2800276/http-parser.java. Fedora Account System Username: ilgrad
https://bugzilla.redhat.com/show_bug.cgi?id=1268369
Ilya Gradina ilya.gradina@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1268371
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1268371 [Bug 1268371] Review Request: rubygem-twitter-stream - Twitter realtime API client
https://bugzilla.redhat.com/show_bug.cgi?id=1268369
Jun Aruga jaruga@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jaruga@redhat.com
--- Comment #1 from Jun Aruga jaruga@redhat.com --- Let me review this. But if there are any other things to comment, please comment.
* spec file - You should add your test suite in %check section.
See https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites > If the source code of the package provides a test suite, it should be executed in the %check section, whenever it is practical to do so.
- rubygem-http_parser is using ruby_http_parser.so compiled by itself. But http_parser package exits in Fedora package. So, should use the package.
See http://fedoraproject.org/wiki/Packaging:ReviewGuidelines > MUST: Packages must NOT bundle copies of system libraries
* license ok after checking with licensecheck tool.
* rpmlint - rpmlint shows below thing. but it looks no problem. rubygem-http_parser.rb.x86_64: E: zero-length /usr/lib64/gems/ruby/http_parser.rb-0.6.0/gem.build_complete - Other warnings looks ok.
https://bugzilla.redhat.com/show_bug.cgi?id=1268369
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #2 from Vít Ondruch vondruch@redhat.com --- (In reply to Jun Aruga from comment #1)
- rpmlint
- rpmlint shows below thing. but it looks no problem. rubygem-http_parser.rb.x86_64: E: zero-length
/usr/lib64/gems/ruby/http_parser.rb-0.6.0/gem.build_complete
This is actually false positive. The file has to be there and has 0 bytes length.
https://bugzilla.redhat.com/show_bug.cgi?id=1268369
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed| |2016-09-08 08:06:19
--- Comment #3 from Vít Ondruch vondruch@redhat.com ---
*** This bug has been marked as a duplicate of bug 1372999 ***
package-review@lists.fedoraproject.org