[Bug 439015] New: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=439015

Summary: Review Request: libzend-framework-php - A simple,
                    straightforward, open-source software framework for PHP
                    5
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://downloads.zend.com/framework/1.5/rpm/libzend-framework-php.spec
SRPM URL: http://downloads.zend.com/framework/1.5/rpm/libzend-framework-php-1.5.0-0.sr...
Description: Zend Framework is a simple, straightforward, open-source software framework for PHP 5 designed to eliminate the tedious details of coding and 
let you focus on the big picture. One of its strengths is the highly modular Model-View-Controller (MVC) design, making your code more reusable 
and easier to maintain.

[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

https://bugzilla.redhat.com/show_bug.cgi?id=439015

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |noarch

[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

https://bugzilla.redhat.com/show_bug.cgi?id=439015

------- Additional Comments From [e-mail]  2008-03-26 17:06 EST -------
License must be one from this list:
http://fedoraproject.org/wiki/Licensing

so it should probably be Zend in this case

replace %{buildroot} with $RPM_BUILD_ROOT
get rid of #%setup - # isn't enough of a comment for rpm specfiles - Problems
will occur.
Release must start from 1, not 0 unless this is a pre-release package.

more vertical spacing between sections would be nice.

Did you go through all of these:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

https://bugzilla.redhat.com/show_bug.cgi?id=439015

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-03-26 17:12 EST -------
oh and should it really just be dropping the files in /usr/share?

[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

https://bugzilla.redhat.com/show_bug.cgi?id=439015

------- Additional Comments From [e-mail]  2008-03-27 14:44 EST -------
(In reply to comment #2)
> oh and should it really just be dropping the files in /usr/share?

Yes. These are just PHP files. The user should add the frame dir to his
include_path and he can start working with it.
I must confess, I wasn't sure whether it should install onto /usr/share or
/usr/lib. Perl and Python modules usually go to /usr/lib and that always seemed
like good practice to me, do you think it's better to place the
libzend-framework-php there instead?

Replaced %{buildroot} with $RPM_BUILD_ROOT.
Dropped the #%setup comment, it got in there by mistake in the first place.
Spaced the sections.
The updated version can be downloaded from the same URL.

Thank you for reviewing.

[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

https://bugzilla.redhat.com/show_bug.cgi?id=439015

------- Additional Comments From [e-mail]  2008-04-01 11:20 EST -------
run rpmlint on your src.rpm, please. Lots of issues there:

rpmlint libzend-framework-php-1.5.0-0.src.rpm
libzend-framework-php.src:11: W: hardcoded-packager-tag Zend
libzend-framework-php.src:24: W: setup-not-quiet
libzend-framework-php.src: E: no-cleaning-of-buildroot %install
libzend-framework-php.src: W: no-%build-section
libzend-framework-php.src: E: description-line-too-long Zend Framework is a
simple, straightforward, open-source software framework for PHP 5 designed to
eliminate the tedious details of coding and
libzend-framework-php.src: E: description-line-too-long let you focus on the big
picture. One of its strengths is the highly modular Model-View-Controller (MVC)
design, making your code more reusable
libzend-framework-php.src: W: invalid-license http://framework.zend.com/license
libzend-framework-php.src: W: strange-permission libzend-framework-php.spec 0666

[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

https://bugzilla.redhat.com/show_bug.cgi?id=439015

------- Additional Comments From [e-mail]  2008-04-03 11:39 EST -------
This looks like a duplicate of bug #421241 where the spec is, at first sight, in
a much better shape

[Bug 439015] Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libzend-framework-php - A simple, straightforward, open-source software framework for PHP 5

https://bugzilla.redhat.com/show_bug.cgi?id=439015

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |DUPLICATE

------- Additional Comments From [e-mail]  2008-04-04 04:04 EST -------
Closing this bug as a duplicate of bug 421241. You are of course all welcome to
help improving the spec as there are still issues how to handle the unit tests
properly.

*** This bug has been marked as a duplicate of 421241 ***