Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: kdevelop-php - Php language plugin for KDevelop
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Summary: Review Request: kdevelop-php - Php language plugin for KDevelop Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php-1.1.1-1.fc13.... Description: Php language plugin for KDevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews) Depends on| |661832
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |kdevelop-php
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #1 from Rex Dieter rdieter@math.unl.edu 2010-12-09 13:50:15 EST --- rpmlint *.rpm x86_64/*.rpm kdevelop-php.x86_64: E: invalid-soname /usr/lib64/libkdev4phpparser.so libkdev4phpparser.so kdevelop-php.x86_64: E: invalid-soname /usr/lib64/libkdev4phpcompletion.so libkdev4phpcompletion.so kdevelop-php.x86_64: E: invalid-soname /usr/lib64/libkdev4phpduchain.so libkdev4phpduchain.so 3 packages and 0 specfiles checked; 3 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jreznik@redhat.com AssignedTo|nobody@fedoraproject.org |jreznik@redhat.com Flag| |fedora-review?
--- Comment #2 from Jaroslav Reznik jreznik@redhat.com 2010-12-10 08:09:19 EST --- Name: ok Summary: ok Version/Release: ok Group: ok License: not ok! most files in the archive are LGPLv2+, some even GPLv3+ (does not look like intention as it's just header, even not properly filled!), try licensecheck -> pls, contact upstream to clarify situation and to fix issues URL: ok Sources: md5sum ok (1f364430db7e8146fc2dee61a80417f4 kdevelop-php-1.1.1.tar.bz2, d93efbe0f4fa04070c27fd5a68152f95 kdevelop-php-docs-1.1.1.tar.bz2) BuildRequires/Requires: ok Description: ok Build/make: ok
Looks ok but license and invalid-sonames.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #3 from Rex Dieter rdieter@math.unl.edu 2010-12-10 12:26:32 EST --- indeed, $ find . -print | grep -v test | xargs licensecheck | grep -v LGPL | sort | uniq ./app_templates/simple_phpapp/%{APPNAME}.php: *No copyright* UNKNOWN ./parser/parsesession.cpp: GPL (v2 or later) ./parser/parsesession.h: GPL (v2 or later) ./phpfunctions.php: *No copyright* GENERATED FILE ./phphighlighting.cpp: GPL (v3 or later) ./phphighlighting.h: GPL (v3 or later) ./phplanguagesupport.cpp: GPL (v2 or later) ./phplanguagesupport.h: GPL (v2 or later) ./phpparsejob.cpp: GPL (v2 or later) ./phpparsejob.h: GPL (v2 or later)
looks like we can go with License: GPLv2+
the libraries are not illegitimate, imo, rpmlint is just complaining about the lack of (versioned) sonames.
Any other blockers?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2010-12-10 12:40:22 EST --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php-1.1.1-2.fc13....
%changelog * Fri Dec 10 2010 Rex Dieter rdieter@fedoraproject.org - 1.1.1-2 - License: GPLv2+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #5 from Rex Dieter rdieter@math.unl.edu 2010-12-10 13:10:05 EST --- Oops, missed, ./phphighlighting.cpp: GPL (v3 or later) ./phphighlighting.h: GPL (v3 or later)
Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php-1.1.1-3.fc13....
%changelog * Fri Dec 10 2010 Rex Dieter rdieter@fedoraproject.org - 1.1.1-3 - License: GPLv3+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #6 from Rex Dieter rdieter@math.unl.edu 2010-12-10 13:39:49 EST --- Folks on #kdevelop irc confirmed the intent is to be GPLv2+ , and will work to relicense those files for upcoming releases.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #7 from Jaroslav Reznik jreznik@redhat.com 2010-12-14 08:22:32 EST --- ETA on this?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #8 from Rex Dieter rdieter@math.unl.edu 2010-12-14 11:59:25 EST --- ETA on kdevelop's next release? no idea. I figured we could ammend the license tag when/if that happens.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #9 from Jaroslav Reznik jreznik@redhat.com 2011-01-05 08:51:06 EST --- I'm going to approve this package with current license resolution as GPLv3+ and comment in SPEC file, update it once upstream releases fixed tarballs to GPLv2+. Thanks.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Rex Dieter rdieter@math.unl.edu 2011-01-05 09:23:18 EST --- New Package SCM Request ======================= Package Name: kdevelop-php Short Description: Php language plugin for KDevelop Owners: rdieter than ltinkl thomasj kkofler Branches: f13 f14 InitialCC: rnovacek tuxbrewr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #11 from Jason Tibbitts tibbs@math.uh.edu 2011-01-05 11:07:42 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-01-05 15:07:32 EST --- kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-p...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-01-05 15:08:01 EST --- kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc13,kdevelop-p...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-01-06 14:23:41 EST --- kdevelop-php-1.1.1-3.fc14, kdevelop-pg-qt-0.9.0-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kdevelop-php kdevelop-pg-qt'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-p...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-01-18 16:31:42 EST --- kdevelop-php-1.1.1-3.fc14, kdevelop-pg-qt-0.9.0-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |kdevelop-php-1.1.1-3.fc14 Resolution| |ERRATA Last Closed| |2011-01-18 16:31:53
Bug 661833 depends on bug 661832, which changed state.
Bug 661832 Summary: Review Request: kdevelop-pg-qt - A parser generator https://bugzilla.redhat.com/show_bug.cgi?id=661832
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2011-01-18 16:38:16 EST --- kdevelop-php-1.1.1-3.fc13, kdevelop-pg-qt-0.9.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|kdevelop-php-1.1.1-3.fc14 |kdevelop-php-1.1.1-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |niklas.laxstrom+bro@gmail.c | |om
--- Comment #17 from Kevin Kofler kevin@tigcc.ticalc.org 2011-06-02 09:02:50 EDT --- *** Bug 647161 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661833
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|656997(kde-reviews) |
package-review@lists.fedoraproject.org