https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Bug ID: 1421044 Summary: Review Request: deepin-qml-widgets - Deepin QML widgets Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/FZUG/repo/blob/master/rpms/deepin_project/deepin-qml-widg...
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17612371
Description: Deepin QML widgets
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Felix Yan felixonmars@archlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1421047
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1421047 [Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sensor.wen@gmail.com Flags| |needinfo?(sensor.wen@gmail. | |com)
--- Comment #1 from Zamir SUN sztsian@gmail.com --- Hi, Your SPEC is now 2.3.5 while your srpm is 2.3.4. Can you resubmit a 2.3.5 srpm for review?
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sensor.wen@gmail. | |com) |
--- Comment #2 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... Task: https://copr.fedorainfracloud.org/coprs/mosquito/deepin/build/579729/
https://bugzilla.redhat.com/show_bug.cgi?id=1421044 Bug 1421044 depends on bug 1421047, which changed state.
Bug 1421047 Summary: Review Request: deepin-tool-kit - Base development tool of all C++/Qt Developer work on Deepin https://bugzilla.redhat.com/show_bug.cgi?id=1421047
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- - No need to use underscores in %_commit, %_shortcommit.
- F24 is (almost) out, so you can remove the F24-specific workarounds.
- Group:, %defattr(-,root,root,-) → please remove [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]
- qt5-qtquick1 package has been retired [http://pkgs.fedoraproject.org/cgit/rpms/qt5-qtquick1.git/commit/?id=10624544...]. I rebuilt this package without that dependency, and it seems to build fine, but I don't know it there's any effect. Please check.
- The %description doesn't describe the package: it also contains a D-bus activated service. Please describe what the package does more fully.
- deepin-dialog says: QQmlComponent: Component is not ready "qrc:///qml/main.qml:46 Type DDialogBox unavailable\nfile:///usr/lib64/qt5/qml/Deepin/Widgets/DDialogBox.qml:11 module "QtGraphicalEffects" is not installed\n" → I think you need Requires: qt5-qtgraphicaleffects(?%_isa) Requires: qt5-qtquickcontrols(?%_isa)
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
--- Comment #4 from sensor.wen@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Thanks, i fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- + package name is OOK + license is acceptable (GPLv3) + license is specified correctly + %license is used + latest version + builds and install OK + P/R/BR look OK
rpmlint:
deepin-qml-widgets.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/qml/Deepin/Locale/libdlocale.so
I think that's OK.
deepin-qml-widgets.x86_64: W: no-manual-page-for-binary deepin-dialog
OK.
deepin-qml-widgets.x86_64: E: unknown-key RSA#1ae64798 (MD5
No idea what's going on here. rpm version mismatch? Nothing to do with the packag e anyway.
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
Package is APPROVED.
The %description is still a very short, but this shouldn't block the package. It would be nice to improve it in the future.
Also, please close the ticket when you have built the package in rawhide, if you do not intend to build it in F26 or earlier. It makes it easier to see which reviews are still active.
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
--- Comment #6 from Ralph Bean rbean@redhat.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-qml-widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
--- Comment #7 from Ralph Bean rbean@redhat.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-qml-widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |deepin-qml-widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1421044
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:30:55
--- Comment #8 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
package-review@lists.fedoraproject.org