[Bug 2358970] New: Review Request: rust-prost-reflect - Protobuf library extending prost with reflection support and dynamic messages
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Bug ID: 2358970 Summary: Review Request: rust-prost-reflect - Protobuf library extending prost with reflection support and dynamic messages Product: Fedora Version: rawhide URL: https://crates.io/crates/prost-reflect Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: fedora@lecris.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec...
Description: A protobuf library extending prost with reflection support and dynamic messages.
Fedora Account System Username: lecris
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131384076
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2358966
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2358966 [Bug 2358966] Review Request: rust-protox - Rust implementation of the protobuf compiler
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8888705 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #2 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec...
Update prost-reflect which eliminates most workarounds. Also disabled the unused features that I have not packaged the dependencies for.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131401674
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2084426 --> https://bugzilla.redhat.com/attachment.cgi?id=2084426&action=edit The .spec file difference from Copr build 8888705 to 8890008
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8890008 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #5 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec...
Relaxed the logos constraint and updated the features hidden
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131404714
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2084440 --> https://bugzilla.redhat.com/attachment.cgi?id=2084440&action=edit The .spec file difference from Copr build 8890008 to 8891288
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8891288 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #8 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec...
Move the patches to `rust2rpm -p`
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131518671
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2084783 --> https://bugzilla.redhat.com/attachment.cgi?id=2084783&action=edit The .spec file difference from Copr build 8891288 to 8899939
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8899939 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #11 from Fabio Valentini decathorpe@gmail.com --- Some issues in the package as-is:
# * - dynamic::type_sizes This test uses std::mem::size_of which is inconsistent # on i686
This might be indicative of a real problem (or not), would be good to check with upstream.
LICENSE-APACHE LICENSE-MIT
These files don't contain actual license texts, but the literal strings "../LICENSE-APACHE" and "../LICENSE-MIT", respectively.
Looks like the current version was published on a Windows system without working symbolic links (or the files are actually messed up in git too, I haven't checked).
# Broken test because tests.rs is not in crate sed -i '/#[cfg(test)]/,/mod tests/d' src/descriptor/mod.rs
This is unfortunate, but likely not avoidable.
I usually recommend to upstream projects to at least include all the files to make tests *compile* (if not run). If tests at least *compile* you can "--skip" as appropriate. But if they don't even compile, it's a lot more annoying.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #12 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec...
Update to 0.15.2. They've fixed the license file and newline characters. They've also added the files necessary for testing. One file is a binary file used for testing only so I've removed it from the devel package to be safe.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131818565
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2086204 --> https://bugzilla.redhat.com/attachment.cgi?id=2086204&action=edit The .spec file difference from Copr build 8899939 to 8949183
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8949183 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #15 from Fabio Valentini decathorpe@gmail.com ---
Update to 0.15.2. They've fixed the license file and newline characters.
Looks like it, yeah. That makes things easier :)
They've also added the files necessary for testing.
:party:
One file is a binary file used for testing only so I've removed it from the devel package to be safe.
The "file_descriptor_set.bin" file looks harmless in a hexdump, it's just the compiled binary for doctest.proto. Both are only referenced by doctests, so you can exclude both from the built package.
You might also want to exclude the doc/ and tests/ folders - they're unused too and contain a large amount of test-only files.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #16 from Fabio Valentini decathorpe@gmail.com --- Oh, and I'm wondering why the subpackage for the "derive" feature is missing.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #17 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec... SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflec...
Removed more files. Re derive subpackage, it is intentionally removed because I did not package the dependencies and it doesn't seem to be needed for protox.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=132065840
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #18 from Fabio Valentini decathorpe@gmail.com --- Hm, this looks good, with one potential exception - I think the fact that the tests/main.rs file is now excluded but still referenced in the Cargo.toml file might break things when building this crate as a dependency of something else, but I'm not sure. You might need to change the %exclude from tests/ to tests/data and tests/snapshots then. But you can cross that bridge when you get to it.
As for excluding the "derive" feature - fair enough, if you don't need it and it would involve packaging more dependencies, then this is a perfectly fine solution.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #19 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prost-reflect
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #20 from Cristian Le fedora@lecris.me --- Thank you for the review, Fabio
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-f646a7828c (rust-prost-reflect-0.15.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f646a7828c
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |rust-prost-reflect-0.15.2-1 | |.fc43
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2025-05-01 12:40:05
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-f646a7828c (rust-prost-reflect-0.15.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c9ce6e00f5 (rust-prost-reflect-0.15.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c9ce6e00f5
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c9ce6e00f5 (rust-prost-reflect-0.15.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c9ce6e00f5
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-9e28110097 (rust-prost-reflect-0.15.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-9e28110097
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-9e28110097 (rust-prost-reflect-0.15.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-9e28110097
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-bc57d873bf (rust-prost-reflect-0.15.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-bc57d873bf
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-bc57d873bf has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-bc57d873bf` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-bc57d873bf
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c9ce6e00f5 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c9ce6e00f5` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c9ce6e00f5
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-9e28110097 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-9e28110097` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-9e28110097
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c9ce6e00f5 (rust-prost-reflect-0.15.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #30 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-9e28110097 (rust-prost-reflect-0.15.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2358970
--- Comment #31 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-bc57d873bf (rust-prost-reflect-0.15.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com