[Bug 2296105] New: Review Request: rust-cryptographic-message-syntax - Pure Rust implementation of Crypographic Message Syntax (RFC 5652)
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Bug ID: 2296105 Summary: Review Request: rust-cryptographic-message-syntax - Pure Rust implementation of Crypographic Message Syntax (RFC 5652) Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-cryptographic-message-syntax/r... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cryptographic-message-syntax/r...
Description: A pure Rust implementation of Crypographic Message Syntax (RFC 5652).
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2296103
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2296103 [Bug 2296103] Review Request: rust-x509-certificate - X.509 certificate parser and utility functionality
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [package] extra-sources = [ { number = 2, file = "https://github.com/indygreg/cryptography-rs/raw/cfaafe05892ce5c617dcac593a92...", comments = ["https://github.com/indygreg/cryptography-rs/pull/23%22%5D%7D, ]
[scripts] prep.pre = ["cp -p %SOURCE2 ."]
[tests] skip = [ "time_stamp_protocol::test::simple_request", "signing::tests::time_stamp_url", ] comments = ["Skip tests requiring Internet access"]
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2296106
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2296106 [Bug 2296106] Review Request: rust-apple-xar - XAR archive reading and writing
https://bugzilla.redhat.com/show_bug.cgi?id=2296105 Bug 2296105 depends on bug 2296103, which changed state.
Bug 2296103 Summary: Review Request: rust-x509-certificate - X.509 certificate parser and utility functionality https://bugzilla.redhat.com/show_bug.cgi?id=2296103
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review+ Status|NEW |ASSIGNED CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package looks good to me. Just please verify that the test data is something that we can redistribute.
It looks like it's just some certificates and stuff, so I think it should be fine. But you also might want to exclude src/testdata folder from being installed.
===
Package was generated with rust2rpm, simplifying the review.
❓ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files (temporarily manually included from upstream) ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cryptographic-message-syntax
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #4 from Davide Cavalca davide@cavalca.name ---
Just please verify that the test data is something that we can redistribute.
I did a pass on this and afaict it's all fine, they're just some certificate bundles.
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5397ea612f (rust-cryptographic-message-syntax-0.26.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5397ea612f
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-09-12 17:47:47
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5397ea612f (rust-cryptographic-message-syntax-0.26.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-6ddb74e8cc (rust-cryptographic-message-syntax-0.26.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6ddb74e8cc
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-121885247d (rust-cryptographic-message-syntax-0.26.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-121885247d
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-56cfb6b8db (rust-cryptographic-message-syntax-0.26.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-56cfb6b8db
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-56cfb6b8db has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-56cfb6b8db *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-56cfb6b8db
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-121885247d has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-121885247d *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-121885247d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-6ddb74e8cc has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6ddb74e8cc *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6ddb74e8cc
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-6ddb74e8cc (rust-cryptographic-message-syntax-0.26.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-56cfb6b8db (rust-cryptographic-message-syntax-0.26.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2296105
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-121885247d (rust-cryptographic-message-syntax-0.26.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com