Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
Summary: Review Request: kpowersave - kde power control applet Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dennis@ausil.us QAContact: fedora-package-review@redhat.com
Spec URL: http://www.ausil.us/packages/kpowersave.spec SRPM URL: http://www.ausil.us/packages/kpowersave-0.7.1-1.src.rpm Description: power control applet for kde
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |226891
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
gauret@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |gauret@free.fr OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From gauret@free.fr 2007-02-02 04:00 EST ------- Needs work: * Source 0 is not available, please replace it with http://dl.sf.net/powersave/kpowersave-%%7Bversion%7D.tar.bz2 * BuildRequires: desktop-file-utils is missing * Build failed in mock, missing buildrequires: hal-devel (at least). Please test the build in mock.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
Bug 226892 depends on bug 226891, which changed state.
Bug 226891 Summary: Review Request: dbus-qt - dbus bindings for qt https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226891
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
------- Additional Comments From dennis@ausil.us 2007-02-02 11:53 EST ------- i grabbed the tarball from the ftp site but have changed the url. build in mock SRPM: http://www.ausil.us/packages/kpowersave-0.7.1-2.al3.src.rpm SPEC: http://www.ausil.us/packages/kpowersave.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
------- Additional Comments From gauret@free.fr 2007-02-03 05:27 EST ------- Needs work: * Please remove /usr/lib/libkdeinit_kpowersave.la, it should be useless (http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries). /usr/lib/kde3/kpowersave.la is probably needed however, please keep it. * As kpowersave ships icons in the hicolor directory, it should have "Requires: hicolor-icon-theme" https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.h...
Everything else looks OK, good job.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
------- Additional Comments From dennis@ausil.us 2007-02-03 17:08 EST ------- libkdeinit .la files are needed and kdelibs requires hicolor-icon-theme so the requires is redundant.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
gauret@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From gauret@free.fr 2007-02-04 04:08 EST ------- Thanks for the clarification.
Review for release 2.fc6: * RPM name is OK * Source kpowersave-0.7.1.tar.bz2 is the same as upstream * This is the latest version * rpmlint looks OK * File list looks OK * Builds fine in mock * Works fine (36 automatic checks have been run by fedora-qa)
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kpowersave - kde power control applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226892
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From dennis@ausil.us 2007-02-04 13:36 EST ------- Built in devel and FC-6 thanks for the review.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla