[Bug 1529788] New: Review Request: spirv-headers - Header files from the SPIR-V registry
https://bugzilla.redhat.com/show_bug.cgi?id=1529788
Bug ID: 1529788 Summary: Review Request: spirv-headers - Header files from the SPIR-V registry Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: leigh123linux@googlemail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://leigh123linux.fedorapeople.org/pub/review/spirv-headers/1/spirv-head... SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/spirv-headers/1/spirv-head...
Description: Header files from the SPIR-V registry Fedora Account System Username: leigh123linux
https://bugzilla.redhat.com/show_bug.cgi?id=1529788
Björn "besser82" Esser besser82@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |besser82@fedoraproject.org Flags| |fedora-review?
--- Comment #1 from Björn "besser82" Esser besser82@fedoraproject.org --- Taken. =)
https://bugzilla.redhat.com/show_bug.cgi?id=1529788
Björn "besser82" Esser besser82@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #2 from Björn "besser82" Esser besser82@fedoraproject.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
C/C++: [x]: Header files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 41 files have unknown license. Detailed output of licensecheck in /home/besser82/vm_shared/fedora/review/1529788-spirv- headers/licensecheck.txt
---> License: MIT is fine.
[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL)
---> Contents of diff is not troublesome.
[x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: spirv-headers-devel-1.2-0.1.20170516.git63e1062.fc28.noarch.rpm spirv-headers-1.2-0.1.20170516.git63e1062.fc28.src.rpm spirv-headers-devel.noarch: W: spelling-error %description -l en_US fil -> feel, fol, fl spirv-headers-devel.noarch: E: script-without-shebang /usr/include/spirv/1.2/spirv.py 2 packages and 0 specfiles checked; 1 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory spirv-headers-devel.noarch: W: spelling-error %description -l en_US fil -> feel, fol, fl spirv-headers-devel.noarch: W: invalid-url URL: https://github.com/KhronosGroup <urlopen error [Errno -2] Name or service not known> spirv-headers-devel.noarch: E: script-without-shebang /usr/include/spirv/1.2/spirv.py 1 packages and 0 specfiles checked; 1 errors, 2 warnings.
Diff spec file in url and in SRPM --------------------------------- --- /home/besser82/vm_shared/fedora/review/1529788-spirv-headers/srpm/spirv-headers.spec 2017-12-30 02:19:29.461933731 +0100 +++ /home/besser82/vm_shared/fedora/review/1529788-spirv-headers/srpm-unpacked/spirv-headers.spec 2017-07-13 20:16:26.000000000 +0200 @@ -15,4 +15,7 @@ BuildArch: noarch
+BuildRequires: cmake +BuildRequires: gcc-c++ + %description %{summary}
Requires -------- spirv-headers-devel (rpmlib, GLIBC filtered):
Provides -------- spirv-headers-devel: spirv-headers-devel
Source checksums ---------------- https://github.com/KhronosGroup/SPIRV-Headers/archive/63e1062a194750b354d48b... : CHECKSUM(SHA512) this package : b5c0d15bdf24f7ba4e4beee87678dee5c3fc994c7afccf6a8ddabefce1478abd32b0eee2fd740fec6fa9502ef0bf27066cab16179b9916793fdd5ee300c374e6 CHECKSUM(SHA512) upstream package : b5c0d15bdf24f7ba4e4beee87678dee5c3fc994c7afccf6a8ddabefce1478abd32b0eee2fd740fec6fa9502ef0bf27066cab16179b9916793fdd5ee300c374e6
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -k sha512 -m fedora-rawhide-x86_64 -b 1529788 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
===== Solution =====
Package APPROVED!!!
I'd recommend to add a shebang to `/usr/include/spirv/1.2/spirv.py` or change it's mod to 0644, whatever better fits the package's needs. I'd also recommend to package the `examples` dir shipped with the sources as %%doc after removing possible build-sys files in there.
https://bugzilla.redhat.com/show_bug.cgi?id=1529788
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/spirv-headers
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com