[Bug 2266590] New: Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Bug ID: 2266590
           Summary: Review Request: syncplay - Free software that
                    synchronises media players so that faraway friends can
                    watch videos together.
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://luk1337.fedorapeople.org/review/syncplay.spec
SRPM URL: https://luk1337.fedorapeople.org/review/syncplay-1.7.1-1.fc41.src.rpm
Description: Free software that synchronises media players so that faraway
friends can watch videos together.
Fedora Account System Username: luk1337

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://syncplay.pl

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7068377
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Łukasz Patron  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Łukasz Patron  ---
[fedora-review-service-build]

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

--- Comment #3 from Fedora Review Service  ---
Created attachment 2019282
  --> https://bugzilla.redhat.com/attachment.cgi?id=2019282&action=edit
The .spec file difference from Copr build 7068377 to 7068559

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7068559
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Łukasz Patron  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Xavier Bachelot  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

--- Comment #5 from Łukasz Patron  ---
[fedora-review-service-build]

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

--- Comment #6 from Fedora Review Service  ---
Created attachment 2020347
  --> https://bugzilla.redhat.com/attachment.cgi?id=2020347&action=edit
The .spec file difference from Copr build 7068559 to 7112210

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

--- Comment #7 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7112210
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Andreas Schneider  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Andreas Schneider  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.rtf is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "Apache License 2.0 and/or MIT License", "*No copyright* Apache
     License", "MIT License", "*No copyright* ISC License", "BSD 3-Clause
     License and/or MIT License", "BSD 3-Clause License". 147 files have
     unknown license. Detailed output of licensecheck in

/home/asn/workspace/package/fedora/REVIEW/2266590-syncplay/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/icons/hicolor/16x16,
     /usr/lib/python3.12, /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/48x48/apps,
     /usr/share/icons/hicolor/32x32/apps, /usr/lib/python3.12/site-
     packages, /usr/share/icons/hicolor/64x64/apps,
     /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/16x16/apps,
     /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/128x128,
     /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/96x96/apps,
     /usr/share/icons/hicolor/256x256/apps,
     /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/96x96,
     /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/32x32,
     /usr/share/icons/hicolor/64x64
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2948 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Rpmlint
-------
Checking: syncplay-1.7.1-1.fc41.noarch.rpm
          syncplay-1.7.1-1.fc41.src.rpm
===============================================================================
rpmlint session starts
==============================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp166nj2br')]
checks: 32, packages: 2

syncplay.noarch: E: spelling-error ('mpv', '%description -l en_US mpv -> mp,
mpg, mph')
syncplay.noarch: E: spelling-error ('unpauses', '%description -l en_US unpauses
-> pauses')
syncplay.noarch: E: spelling-error ('synchronised', '%description -l en_US
synchronised -> synchronized, synchronize, synchronicity')
syncplay.src: E: spelling-error ('mpv', '%description -l en_US mpv -> mp, mpg,
mph')
syncplay.src: E: spelling-error ('unpauses', '%description -l en_US unpauses ->
pauses')
syncplay.src: E: spelling-error ('synchronised', '%description -l en_US
synchronised -> synchronized, synchronize, synchronicity')
syncplay.noarch: W: python-leftover-require python3-pyside6
syncplay.noarch: W: python-leftover-require python3-twisted+tls
========================================== 2 packages and 0 specfiles checked;
6 errors, 2 warnings, 9 filtered, 6 badness; has taken 0.8 s
=========================================

Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

syncplay.noarch: E: spelling-error ('mpv', '%description -l en_US mpv -> mp,
mpg, mph')
syncplay.noarch: E: spelling-error ('unpauses', '%description -l en_US unpauses
-> pauses')
syncplay.noarch: E: spelling-error ('synchronised', '%description -l en_US
synchronised -> synchronized, synchronize, synchronicity')
syncplay.noarch: W: python-leftover-require python3-pyside6
syncplay.noarch: W: python-leftover-require python3-twisted+tls
 1 packages and 0 specfiles checked; 3 errors, 2 warnings, 5 filtered, 3
badness; has taken 0.3 s

Source checksums
----------------
https://github.com/Syncplay/syncplay/archive/refs/tags/v1.7.1/syncplay-1.7.1...
:
  CHECKSUM(SHA256) this package     :
f335787ff1d94cc990cdcec94f12f39a2068e5bba31db7dbac9ab42e1661d900
  CHECKSUM(SHA256) upstream package :
f335787ff1d94cc990cdcec94f12f39a2068e5bba31db7dbac9ab42e1661d900

Requires
--------
syncplay (rpmlib, GLIBC filtered):
    /usr/bin/python3
    hicolor-icon-theme
    python(abi)
    python3-certifi
    python3-pyside6
    python3-twisted+tls
    python3.12dist(certifi)
    python3.12dist(pem)
    python3.12dist(pyside6)
    python3.12dist(twisted)
    python3.12dist(twisted[tls])

Provides
--------
syncplay:
    application()
    application(syncplay-server.desktop)
    application(syncplay.desktop)
    mimehandler(audio/ac3)
    mimehandler(audio/mp4)
    mimehandler(audio/mpeg)
    mimehandler(audio/mpegurl)
    mimehandler(audio/vnd.rn-realaudio)
    mimehandler(audio/vorbis)
    mimehandler(audio/x-adpcm)
    mimehandler(audio/x-matroska)
    mimehandler(audio/x-mp2)
    mimehandler(audio/x-mp3)
    mimehandler(audio/x-mpegurl)
    mimehandler(audio/x-ms-wma)
    mimehandler(audio/x-pn-realaudio)
    mimehandler(audio/x-scpls)
    mimehandler(audio/x-vorbis)
    mimehandler(audio/x-wav)
    mimehandler(video/avi)
    mimehandler(video/flv)
    mimehandler(video/mp4)
    mimehandler(video/mpeg)
    mimehandler(video/quicktime)
    mimehandler(video/vnd.rn-realvideo)
    mimehandler(video/x-matroska)
    mimehandler(video/x-ms-asf)
    mimehandler(video/x-ms-wmv)
    mimehandler(video/x-msvideo)
    mimehandler(video/x-ogm)
    mimehandler(video/x-theora)
    python3.12dist(syncplay)
    python3dist(syncplay)
    syncplay

Diff spec file in url and in SRPM
---------------------------------
---
/home/asn/workspace/package/fedora/REVIEW/2266590-syncplay/srpm/syncplay.spec  
    2024-03-06 14:23:53.342851390 +0100
+++
/home/asn/workspace/package/fedora/REVIEW/2266590-syncplay/srpm-unpacked/syncplay.spec
     2024-03-06 01:00:00.000000000 +0100
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.6.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 Name:           syncplay
 Version:        1.7.1
@@ -77,4 +87,6 @@

%changelog
-%autochangelog
-
+## START: Generated by rpmautospec
+* Wed Mar 06 2024 LuK1337  - 1.7.1-1
+- Initial commit
+## END: Generated by rpmautospec

Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2266590
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: PHP, C/C++, Ocaml, Java, Haskell, R, Perl, fonts,
SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST

--- Comment #9 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/syncplay

[Bug 2266590] Review Request: syncplay - Free software that synchronises media players so that faraway friends can watch videos together.

https://bugzilla.redhat.com/show_bug.cgi?id=2266590

Łukasz Patron  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |COMPLETED
        Last Closed|                            |2024-03-06 14:06:23