[Bug 449234] New: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=449234

Summary: Review Request: perl-Catalyst-Plugin-Session-State-
                    Cookie - Maintain session IDs using cookies
           Product: Fedora
           Version: rawhide
          Platform: All
               URL: http://search.cpan.org/dist/Catalyst-Plugin-Session-
                    State-Cookie/
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session-Stat...
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Session-Stat...

Description:
In order for Catalyst::Plugin::Session to work the session ID needs to
be stored on the client, and the session data needs to be stored on
the server.  This plugin provides a way to store the session ID on the
client, through a cookie.

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

https://bugzilla.redhat.com/show_bug.cgi?id=449234

------- Additional Comments From [e-mail]  2008-05-31 15:14 EST -------
http://koji.fedoraproject.org/koji/taskinfo?taskID=638376

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

https://bugzilla.redhat.com/show_bug.cgi?id=449234

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |449251
              nThis|                            |

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

https://bugzilla.redhat.com/show_bug.cgi?id=449234

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-05-31 22:39 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=638376
+ rpmlint is silent for SRPM but NOT for RPM.
perl-Catalyst-Plugin-Session-State-Cookie.src:38: W: rpm-buildroot-usage %prep
FOO=`perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
==> I think this will not be a problem.
+ source files match upstream url
0eb184e081051ca284c2952ba6db59f7  Catalyst-Plugin-Session-State-Cookie-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=5, Tests=32,  3 wallclock secs ( 1.16 cusr +  0.21 csys =  1.37 CPU)
+ Package perl-Catalyst-Plugin-Session-State-Cookie-0.09-1.fc10 =>
Provides: perl(Catalyst::Plugin::Session::State::Cookie) = 0.09
Requires: perl(:MODULE_COMPAT_5.10.0) perl(Catalyst::Plugin::Session) >= 0.19
perl(Catalyst::Utils) perl(NEXT) perl(base) perl(strict) perl(warnings)

APPROVED.

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

https://bugzilla.redhat.com/show_bug.cgi?id=449234

------- Additional Comments From [e-mail]  2008-06-01 00:00 EST -------
New Package CVS Request
=======================
Package Name: perl-Catalyst-Plugin-Session-State-Cookie
Short Description: Maintain session IDs using cookies
Owners: cweyl
Branches: F-7, F-8, F-9, devel
InitialCC: perl-sig

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

https://bugzilla.redhat.com/show_bug.cgi?id=449234

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

https://bugzilla.redhat.com/show_bug.cgi?id=449234

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-06-01 13:35 EST -------
cvs done. (Except for F-7, as we are no longer doing F-7 branches.)

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

https://bugzilla.redhat.com/show_bug.cgi?id=449234

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-06-01 14:12 EST -------
Imported and built for rawhide.  Thanks for the review! :)

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=449234

Mathieu Bridon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Mathieu Bridon  2011-07-12 00:23:28 EDT ---
Package Change Request
======================
Package Name: perl-Catalyst-Plugin-Session-State-Cookie
New Branches: el6
Owners: bochecha

Chris doesn't maintain his packages in EPEL, but doesn't have a problem with
others doing so.

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=449234

Mathieu Bridon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=449234

--- Comment #7 from Jon Ciesla  2011-07-12 00:57:06 EDT ---
Git done (by process-git-requests).