Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: harfbuzz - Text shaping library
https://bugzilla.redhat.com/show_bug.cgi?id=713126
Summary: Review Request: harfbuzz - Text shaping library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kalev@smartlink.ee QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://kalev.fedorapeople.org/harfbuzz.spec SRPM URL: http://kalev.fedorapeople.org/harfbuzz-0.6.0-1.fc15.src.rpm Description: HarfBuzz is an implementation of the OpenType Layout engine.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3130477
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen@redhat.com
--- Comment #1 from Matthias Clasen mclasen@redhat.com 2011-06-15 23:32:55 EDT --- Builds fine in mock.
rpmlint says: rpmlint /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/RPMS/harfbuzz-* harfbuzz.x86_64: W: no-manual-page-for-binary hb-view harfbuzz-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
which is fine. Formal review to follow.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mclasen@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
--- Comment #2 from Matthias Clasen mclasen@redhat.com 2011-06-15 23:58:20 EDT --- I think hb-view is probably better off in the -devel package ? Isn't that mostly a debug/demo thing ? I don't think it is interesting for most people who just install the library because pango is (going to) depend on it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #3 from Matthias Clasen mclasen@redhat.com 2011-06-16 00:14:54 EDT --- Package name: ok Spec file name: ok Packaging guidelines: ok License: ok License field: ok License file: ok Spec file language: ok Spec file readable: yes Upstream sources: ok Buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok permissions: ok (I just learned that %defattr is no longer required) macro use: ok permissable content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok
Looks fine; approved
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #4 from Kalev Lember kalev@smartlink.ee 2011-06-16 05:50:36 EDT --- (In reply to comment #2)
I think hb-view is probably better off in the -devel package ? Isn't that mostly a debug/demo thing ? I don't think it is interesting for most people who just install the library because pango is (going to) depend on it.
Good idea, I'll move it to -devel when importing the new package.
Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Kalev Lember kalev@smartlink.ee 2011-06-16 05:52:18 EDT --- New Package SCM Request ======================= Package Name: harfbuzz Short Description: Text shaping library Owners: kalev mclasen Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2011-06-16 08:19:03 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |harfbuzz-0.6.0-2.fc16 Resolution| |NEXTRELEASE Last Closed| |2011-06-16 14:07:27
--- Comment #7 from Kalev Lember kalev@smartlink.ee 2011-06-16 14:07:27 EDT --- Package imported and built; closing the ticket.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=713126
--- Comment #8 from Parag pnemade@redhat.com 2011-06-17 00:30:41 EDT --- No package depends on this package, so I think its ok to branch for f15 also. Can this package be built for F15?
Benefit I see, people who generally don't use rawhide but current stable release can also work on harfbuzz.
package-review@lists.fedoraproject.org