[Bug 602597] New: Review Request: perl-Package-Stash - Routines for manipulating stashes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Package-Stash - Routines for manipulating stashes
https://bugzilla.redhat.com/show_bug.cgi?id=602597
Summary: Review Request: perl-Package-Stash - Routines for manipulating stashes Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: paul@city-fan.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Package-Stash/branches/fe... SRPM URL: http://www.city-fan.org/~paul/extras/perl-Package-Stash/perl-Package-Stash-0... Description:
Manipulating stashes (Perl's symbol tables) is occasionally necessary, but incredibly messy, and easy to get wrong. This module hides all of that behind a simple API.
This package is needed for Class::MOP 1.03.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #1 from Chris Weyl cweyl@alumni.drew.edu 2010-06-11 22:16:47 EDT --- Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2246047
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2010-06-11 22:24:54 EDT --- Thanks for packaging this :)
The package looks good; the following are suggestions, not blockers.
DESTDIR seems to be a safer choice than PERL_INSTALL_ROOT given the recent fun around it. Please consider using %{?perl_default_filter}; it won't harm anything and it will make sure unwanted deps don't creep in down the road.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2246047
Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly.
Latest version (0.03) is being packaged.
Source tarballs match upstream (sha1sum): a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz.srpm
Final provides / requires are sane:
====> rpmlint perl-Package-Stash.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
======> perl-Package-Stash-0.03-1.fc14.noarch.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides perl(Package::Stash) = 0.03 perl-Package-Stash = 0.03-1.fc14 ====> requires perl(:MODULE_COMPAT_5.10.1) perl(Carp) perl(Scalar::Util) perl(strict) perl(warnings) ====> obsoletes ====> conflicts
======> perl-Package-Stash-0.03-1.fc14.src.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides ====> requires perl(ExtUtils::MakeMaker) perl(Pod::Coverage::TrustPod) perl(Scalar::Util) perl(Test::Exception) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) ====> obsoletes ====> conflicts
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cweyl@alumni.drew.edu AssignedTo|nobody@fedoraproject.org |cweyl@alumni.drew.edu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Paul Howarth paul@city-fan.org 2010-06-12 06:10:44 EDT --- New Package CVS Request ======================= Package Name: perl-Package-Stash Short Description: Routines for manipulating stashes Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-12 F-13 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2010-06-14 00:47:01 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2010-06-14 04:43:03 EDT --- perl-Package-Stash-0.03-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2010-06-14 04:44:24 EDT --- perl-Package-Stash-0.03-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-06-14 04:45:48 EDT --- perl-Package-Stash-0.03-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-06-14 04:45:53 EDT --- perl-Package-Stash-0.03-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #9 from Paul Howarth paul@city-fan.org 2010-06-14 04:47:42 EDT --- Built successfully on all branches, including dist-rawhide and dist-f14-perltest tags for devel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-06-14 13:19:23 EDT --- perl-Package-Stash-0.03-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Package-Stash-0.03-1.f | |c13 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-06-14 13:22:59 EDT --- perl-Package-Stash-0.03-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-Package-Stash-0.03-1.f |perl-Package-Stash-0.03-1.f |c13 |c12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-06-30 10:21:06 EDT --- perl-Package-Stash-0.03-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602597
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-06-30 10:24:46 EDT --- perl-Package-Stash-0.03-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla