[Bug 2318054] New: Review Request: rust-serial-core - Rust abstractions for serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
Bug ID: 2318054 Summary: Review Request: rust-serial-core - Rust abstractions for serial ports Product: Fedora Version: 41 OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: solomoncyj@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40... SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40... Description: Rust abstractions for serial ports Fedora Account System Username: solomoncyj
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2318048
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2318048 [Bug 2318048] Review Request: rust-serial-unix - Serial port implementation for Unix
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|NEW |CLOSED Last Closed| |2024-10-23 07:40:03
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords| |Reopened
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
Jakub Jelen jjelen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |jjelen@redhat.com Whiteboard| |Unretirement Assignee|nobody@fedoraproject.org |jjelen@redhat.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Jakub Jelen jjelen@redhat.com --- The f40 links are dead. Current working ones from rawhide looks ok to me:
https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-ra... https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-ra...
The package already exists, but was retired:
https://src.fedoraproject.org/rpms/rust-serial-core
So the process for unretiring is slightly different, but package review needs to go through anyway:
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_...
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- serial-core-devel , rust-serial-core+default-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: rust-serial-core-devel-0.4.0-1.fc42.noarch.rpm rust-serial-core+default-devel-0.4.0-1.fc42.noarch.rpm rust-serial-core-0.4.0-1.fc42.src.rpm =================================================================================================================================================== rpmlint session starts ================================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpic2jgsy6')] checks: 32, packages: 3
rust-serial-core+default-devel.noarch: W: no-documentation ============================================================================================================= 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 12 filtered, 0 badness; has taken 0.2 s =============================================================================================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
rust-serial-core+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.1 s
Source checksums ---------------- https://crates.io/api/v1/crates/serial-core/0.4.0/download#/serial-core-0.4.... : CHECKSUM(SHA256) this package : 3f46209b345401737ae2125fe5b19a77acce90cd53e1658cda928e4fe9a64581 CHECKSUM(SHA256) upstream package : 3f46209b345401737ae2125fe5b19a77acce90cd53e1658cda928e4fe9a64581
Requires -------- rust-serial-core-devel (rpmlib, GLIBC filtered): (crate(libc/default) >= 0.2.0 with crate(libc/default) < 0.3.0~) cargo
rust-serial-core+default-devel (rpmlib, GLIBC filtered): cargo crate(serial-core)
Provides -------- rust-serial-core-devel: crate(serial-core) rust-serial-core-devel
rust-serial-core+default-devel: crate(serial-core/default) rust-serial-core+default-devel
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -rnrust-serial-core-0.4.0-1.fc42.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Haskell, C/C++, fonts, Ocaml, Perl, Python, R, Java, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jjelen@redhat.com | |)
--- Comment #2 from solomoncyj@gmail.com --- Is rust-serial-unix and rust-serial also retired?
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jjelen@redhat.com | |)
--- Comment #3 from solomoncyj@gmail.com --- Is rust-serial-unix and rust-serial also retired?
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jjelen@redhat.com |needinfo- |) |
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
Jakub Jelen jjelen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jjelen@redhat.com | |) |
--- Comment #4 from Jakub Jelen jjelen@redhat.com --- (In reply to solomoncyj from comment #3)
Is rust-serial-unix and rust-serial also retired?
No. These were never packaged before, as you can check on the dist git:
https://src.fedoraproject.org/rpms/rust-serial-unix
https://src.fedoraproject.org/rpms/rust-serial
(giving error 404 instead of the dist git with the dead.package file)
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
--- Comment #5 from solomoncyj@gmail.com --- created devel annocement: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/... created releng issue: https://pagure.io/releng/issue/12452
https://bugzilla.redhat.com/show_bug.cgi?id=2318054
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|NEW |CLOSED Last Closed|2024-10-23 07:40:03 |2024-12-06 02:51:38
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com