[Bug 845628] New: Review Request: mate-mime-data - mate-mime-data provides the file type recognition data files for mate-vfs
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Bug ID: 845628 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mate-mime-data - mate-mime-data provides the file type recognition data files for mate-vfs Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: chat-to-me@raveit.de Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-mime-data.spec SRPM URL: http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-mime-data-1.4.0... Description: mate-mime-data provides the file type recognition data files for mate-vfs Fedora Account System Username: raveit65
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #1 from Wolfgang Ulbrich chat-to-me@raveit.de --- Created attachment 602164 --> https://bugzilla.redhat.com/attachment.cgi?id=602164&action=edit switch mime-data from openoffice to libreoffice, etc for fedora
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #2 from Wolfgang Ulbrich chat-to-me@raveit.de --- Created attachment 602165 --> https://bugzilla.redhat.com/attachment.cgi?id=602165&action=edit switch mime-data from openoffice to libreoffice, etc for fedora
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #3 from Wolfgang Ulbrich chat-to-me@raveit.de --- Created attachment 602166 --> https://bugzilla.redhat.com/attachment.cgi?id=602166&action=edit switch mime-data from openoffice to libreoffice, etc for fedora
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Wolfgang Ulbrich chat-to-me@raveit.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |840149 (MATE-DE-tracker)
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@gmail.co | |m Assignee|nobody@fedoraproject.org |mario.blaettermann@gmail.co | |m Alias| |mate-mime-data
--- Comment #4 from Mario Blättermann mario.blaettermann@gmail.com --- It is not needed to submit your patches to your review request, because they are already included in your srpm.
Some initial comments:
Please drop %defattr from the file list. It is not needed unless you want to provide your package for EPEL <6 (which I don't assume).
%config has to be %config(noreplace). When you add this suffix, this config file won't be replaced when the package will be updated, if someone has changed it in the meantime.
Drop NEWS from the docs, because it is empty.
The *.pc file has to be in a -devel subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #5 from Mario Blättermann mario.blaettermann@gmail.com --- The file COPYING contains the GPLv2, and at least config-mime.pl allows in its header the distribution under newer GPL versions, that's why the license has to be GPLv2+.
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #6 from Wolfgang Ulbrich chat-to-me@raveit.de --- Thank you Mario for doing the review and for your hints.
New spec file. SPEC: http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-mime-data.spec
* Sat Aug 04 2012 Wolfgang Ulbrich chat-to-me@raveit.de - 1.4.0-7 - remove %%defattr - correct licence information - drop NEWS because it is empty - create -devel subpackage
I don't know if the description of -devel was really thoughtfully. Maybe you know some better?
Give me hint if you need a new scratch build.
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #7 from Mario Blättermann mario.blaettermann@gmail.com --- "This package provides header files needed for developing mine-data in Mate."
Besides from you have a typo in the description (miNe-data), you should use the commonly used description for -devel packages:
"This package contains development libraries and headers for the %{name} package."
Doesn't matter that your package only contains a packageconfig file, and no headers or anything. It's not the purpose to describe the content in particular.
%patch0 -p1 -b .librenoffice
Somewhat odd that the patch is named "librenoffice". Just a cosmetic issue, but worth to fix it.
Requires: %{name} = %{version}-%{release} Please change this to %{name}%{?_isa} = %{version}-%{release} to tell Yum to use the correct package for the appropriate architecture.
Both the base and the devel package include the same docs. This is not allowed. Because the devel requires the base package, the doc files are present anyway. Remove the entries from the file list. No problem that rpmlint is unhappy with missing docs in this case.
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #8 from Wolfgang Ulbrich chat-to-me@raveit.de --- all done. http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-mime-data.spec
%changelog * Sat Aug 04 2012 Wolfgang Ulbrich chat-to-me@raveit.de - 1.4.0-8 - fix patch name under %%prep - fix -devel description - fix requires in -devel package - remove AUTHORS COPYING ChangeLog README from -devel
* Sat Aug 04 2012 Wolfgang Ulbrich chat-to-me@raveit.de - 1.4.0-7 - remove %%defattr - correct licence information - drop NEWS because it is empty - create -devel subpackage
* Thu Aug 02 2012 Wolfgang Ulbrich chat-to-me@raveit.de - 1.4.0-6 - initial build for fedora
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #9 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build based on your latest spec: http://koji.fedoraproject.org/koji/taskinfo?taskID=4360652
$ rpmlint -i -v * mate-mime-data.noarch: I: checking mate-mime-data.noarch: W: spelling-error %description -l en_US vfs -> vs, ifs, VF The value of this tag appears to be misspelled. Please double-check.
mate-mime-data.noarch: I: checking-url http://mate-desktop.org (timeout 10 seconds) mate-mime-data.src: I: checking mate-mime-data.src: W: spelling-error %description -l en_US vfs -> vs, ifs, VF The value of this tag appears to be misspelled. Please double-check.
mate-mime-data.src: I: checking-url http://mate-desktop.org (timeout 10 seconds) mate-mime-data.src: I: checking-url http://pub.mate-desktop.org/releases/1.4/mate-mime-data-1.4.0.tar.xz (timeout 10 seconds) mate-mime-data-devel.noarch: I: checking mate-mime-data-devel.noarch: I: checking-url http://mate-desktop.org (timeout 10 seconds) mate-mime-data-devel.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Ignoreable issues from rpmlint.
--------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv2+ [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ sha256sum * d914aa9ed1335ab1da908026667ec5b58337c9123dce7b3d3b2035e3bd7fbc7f mate-mime-data-1.4.0.tar.xz d914aa9ed1335ab1da908026667ec5b58337c9123dce7b3d3b2035e3bd7fbc7f mate-mime-data-1.4.0.tar.xz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - See Koji build above. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [+] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [.] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts.
--------------------------------------
PACKAGE APPROVED
--------------------------------------
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #10 from Wolfgang Ulbrich chat-to-me@raveit.de --- Thank you Mario for approving the package.
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Wolfgang Ulbrich chat-to-me@raveit.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #11 from Wolfgang Ulbrich chat-to-me@raveit.de --- New Package SCM Request ======================= Package Name: mate-mime-data Short Description: mate-mime-data provides the file type recognition data files for mate-vfs Owners: raveit65 Branches: f16 f17 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- mate-mime-data-1.4.0-8.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-mime-data-1.4.0-8.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- mate-mime-data-1.4.0-8.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mate-mime-data-1.4.0-8.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- mate-mime-data-1.4.0-8.fc16 has been pushed to the Fedora 16 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |844164 (mate-vfs)
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- mate-mime-data-1.4.0-9.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mate-mime-data-1.4.0-9.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=845628
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- mate-mime-data-1.4.0-9.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-mime-data-1.4.0-9.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=845628
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|844164 (mate-vfs) |
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Wolfgang Ulbrich chat-to-me@raveit.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED CC|chat-to-me@raveit.de | Resolution|--- |WONTFIX Last Closed| |2012-08-21 08:20:00
--- Comment #18 from Wolfgang Ulbrich chat-to-me@raveit.de --- I don't work for the Mate-Desktop project anymore, because i see no basic for working together with Dan Mashal.
https://bugzilla.redhat.com/show_bug.cgi?id=845628
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org Resolution|WONTFIX |CURRENTRELEASE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla