[Bug 1688801] New: Review Request: python-keras-preprocessing data preprocessing and data augmentation module of the Keras deep learning library

https://bugzilla.redhat.com/show_bug.cgi?id=1688801

Bug ID: 1688801
           Summary: Review Request: python-keras-preprocessing data
                    preprocessing and data augmentation module of the
                    Keras deep learning library
           Product: Fedora
           Version: 30
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...

Description:
Keras Preprocessing is the data preprocessing and data augmentation module of
the Keras deep learning library. It provides utilities for working with image
data, text data, and sequence data.

PyPI: https://pypi.org/project/Keras-Preprocessing/
Documentation: https://keras.io/

[Bug 1688801] Review Request: python-keras-preprocessing data preprocessing and data augmentation module of the Keras deep learning library

https://bugzilla.redhat.com/show_bug.cgi?id=1688801

Elliott Sales de Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Elliott Sales de Andrade  ---
Please remove the Python 2 subpackage.

[Bug 1688801] Review Request: python-keras-preprocessing data preprocessing and data augmentation module of the Keras deep learning library

https://bugzilla.redhat.com/show_bug.cgi?id=1688801

--- Comment #2 from ruslan  ---
The Python 2 subpackage was removed:

https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...
https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...

[Bug 1688801] Review Request: python-keras-preprocessing data preprocessing and data augmentation module of the Keras deep learning library

https://bugzilla.redhat.com/show_bug.cgi?id=1688801

Elliott Sales de Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #3 from Elliott Sales de Andrade  ---
- Remove Group tag
- Remove python3-rpm-macros
- Mixed tabs & spaces starting on line 16

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License". 24 files have unknown
     license. Detailed output of licensecheck in
     1688801-python-keras-preprocessing/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: python3-keras-preprocessing-1.0.9-1.fc30.noarch.rpm
          python-keras-preprocessing-1.0.9-1.fc30.src.rpm
python-keras-preprocessing.src:16: W: mixed-use-of-spaces-and-tabs (spaces:
line 4, tab: line 16)
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_CA.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_CA.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = (unset),
        LC_CTYPE = "C.UTF-8",
        LANG = "en_CA.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
python3-keras-preprocessing.noarch: W: invalid-url URL:
https://github.com/keras-team/keras-preprocessing <urlopen error [Errno -2]
Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Source checksums
----------------
https://github.com/keras-team/keras-preprocessing/archive/1.0.9.tar.gz :
  CHECKSUM(SHA256) this package     :
045a9b3faf4f6d63493cc3ca396659cc0395727b280c988fb9b6c7ff8157f09b
  CHECKSUM(SHA256) upstream package :
045a9b3faf4f6d63493cc3ca396659cc0395727b280c988fb9b6c7ff8157f09b

Requires
--------
python3-keras-preprocessing (rpmlib, GLIBC filtered):
    python(abi)
    python3.7dist(numpy)
    python3.7dist(six)

Provides
--------
python3-keras-preprocessing:
    python3-keras-preprocessing
    python3.7dist(keras-preprocessing)
    python3dist(keras-preprocessing)

Generated by fedora-review 0.6.1 (29df316) last change: 2019-03-10
Command line :/home/elliott/code/FedoraReview/try-fedora-review -m
fedora-rawhide-x86_64 -b 1688801
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: Perl, C/C++, fonts, Ruby, Haskell, R, Ocaml, PHP,
SugarActivity, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

[Bug 1688801] Review Request: python-keras-preprocessing data preprocessing and data augmentation module of the Keras deep learning library

https://bugzilla.redhat.com/show_bug.cgi?id=1688801

Elliott Sales de Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1688801] Review Request: python-keras-preprocessing data preprocessing and data augmentation module of the Keras deep learning library

https://bugzilla.redhat.com/show_bug.cgi?id=1688801

--- Comment #4 from Ben Cotton  ---
This message is a reminder that Fedora 30 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with
a
Fedora 'version' of '30'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 30 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

[Bug 1688801] Review Request: python-keras-preprocessing data preprocessing and data augmentation module of the Keras deep learning library

https://bugzilla.redhat.com/show_bug.cgi?id=1688801

Ben Cotton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |EOL
        Last Closed|                            |2020-05-26 14:44:23

--- Comment #5 from Ben Cotton  ---
Fedora 30 changed to end-of-life (EOL) status on 2020-05-26. Fedora 30 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.