[Bug 766154] New: Review Request: kn0ck0ut - An LV2 spectral subtraction plugin (linux audio) - package-review

List overview All Threads
Download

newer

[Bug 766154] New: Review Request: kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

older

[Bug 781685] New: Review Request:...

[Bug 754004] New: Review Request:...

Red Hat Bugzilla

10 Dec 2011 10 Dec '11

4:42 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Summary: Review Request: kn0ck0ut - An LV2 spectral subtraction plugin (linux audio) Product: Fedora Version: 16 Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: brendan.jones.it@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---

This plugin is an LV2 port of the popular kn0ck0ut VST plugin.

For those of you who aren't familiar with the LV2 audio framework, all your questions can be answered here: http://lv2plug.in/trac/

In the meantime rpmlint show's only errors on the source, due to this being only available via github.

SRPM: http://bsjones.fedorapeople.org/lv2-kn0ck0ut-1.1-0.1.gitd03e8db0.fc16.src.rp... SPEC: http://bsjones.fedorapeople.org/lv2-kn0ck0ut.spec

fedora16:~/rpmbuild/SOURCES $ rpmlint ../SRPMS/lv2-kn0ck0ut-1.1-0.1.gitd03e8db0.fc16.src.rpm ../RPMS/x86_64/lv2-kn0ck0ut*1.1* lv2-kn0ck0ut.src: W: invalid-url Source0: lv2-kn0ck0ut-1.1-gitd03e8db0.tar.bz2

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

10 Dec 10 Dec

4:43 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Brendan Jones brendan.jones.it@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Jan 6 Jan

2:14 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Peter Lemenkov lemenkov@gmail.com changed:

--- Comment #1 from Peter Lemenkov lemenkov@gmail.com 2012-01-06 09:14:29 EST --- I'll review this one.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:25 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #2 from Peter Lemenkov lemenkov@gmail.com 2012-01-06 09:25:26 EST --- Failed to build in Rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3624781

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:02 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #3 from Brendan Jones brendan.jones.it@gmail.com 2012-01-06 10:02:37 EST --- Updated for new lv2core (see bug #771997)

SRPM: http://bsjones.fedorapeople.org/lv2-kn0ck0ut-1.1-0.2.gitd03e8db0.fc16.src.rp... SPEC: http://bsjones.fedorapeople.org/lv2-kn0ck0ut.spec

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:45 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2012-01-06 10:45:39 EST --- Koji build for Rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3624984

Unfortunately I found one unexpected legal issue. It is written in readme.txt that

"Kn0ck0ut is freeware and beta. No warranty, no

support. The plugin may be redistributed but only for free,

and only with this readme file."

We do allow distributing Fedora for profit so this will violate our policies (and this isn't compatible with GPL as well). Could you please clarify what exactly original authors mean by this clause? This could be a leftover from some ancient times btw.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:02 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #5 from Brendan Jones brendan.jones.it@gmail.com 2012-01-06 12:02:21 EST --- Thanks again for the review! I was just about to hit send to upstream about this and then realised that the text you quoted is from the original readme of the VST plugin. I'm not sure it applies to the package in this case but the port author has included it as per the readme.

I will still send upstream a query however...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7 Jan 7 Jan

3:23 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #6 from Brendan Jones brendan.jones.it@gmail.com 2012-01-07 10:23:50 EST --- Hi Peter,

this is from upstream:

Hi Brendan,

As the readme says,

"kn0ck0ut-LV2 is released under the terms of the GPL version 3. (this is done so with the permission of st3pan0va)."

And then below that

"Below Reads the Original Readme"

I left the original readme at the bottom of the readme for historical purposes (and to preserve acknowledgments). The original author gave me explicit permission to release under the GPL. I've pushed changes to the repository which further clarify things under the tag 1.01

Jeremy

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:03 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Peter Lemenkov lemenkov@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #7 from Peter Lemenkov lemenkov@gmail.com 2012-01-07 11:03:13 EST --- Ah, ok. And here is a commit with new licensing terms:

https://github.com/jeremysalwen/kn0ck0ut-LV2/commit/60421a3

Ok, here is my formal

REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is silent

work ~/temp: rpmlint * lv2-kn0ck0ut.src: I: enchant-dictionary-not-found en_US lv2-kn0ck0ut.src: W: invalid-url Source0: lv2-kn0ck0ut-1.1-gitd03e8db0.tar.bz2

^^^ that's expected from GitHub's repos.

3 packages and 0 specfiles checked; 0 errors, 1 warnings. work ~/temp:

+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 or later, as stated in the sources). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. Unfortunately it's almost impossible to create bit-exact tarball from SCM (different usernames, different timestamps) so I used diff -ru to compare. + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. 0 The package DOESN'T have a %clean section, so it won't build cleanly on systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8.

APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Jan 8 Jan

10:11 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Brendan Jones brendan.jones.it@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #8 from Brendan Jones brendan.jones.it@gmail.com 2012-01-08 17:11:51 EST --- New Package SCM Request ======================= Package Name: lv2-kn0ck0ut Short Description: A spectral subtraction LV2 plugin Owners: bsjones Branches: f15 f16 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:12 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #9 from Brendan Jones brendan.jones.it@gmail.com 2012-01-08 17:12:18 EST --- Thanks for the fast review!!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:22 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #10 from Jon Ciesla limburgher@gmail.com 2012-01-08 17:22:29 EST --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 Jan 11 Jan

11:47 a.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Peter Lemenkov lemenkov@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:53 a.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Brendan Jones brendan.jones.it@gmail.com changed:

--- Comment #11 from Brendan Jones brendan.jones.it@gmail.com 2012-01-11 06:53:38 EST --- Peter, the (pending) update will close these bugs.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12 Jan 12 Jan

7:03 a.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:03 a.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2012-01-12 02:03:57 EST --- lv2-kn0ck0ut-1.1-0.3.git60421a3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/lv2-kn0ck0ut-1.1-0.3.git60421a3.fc15

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:04 a.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2012-01-12 02:04:05 EST --- lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Jan 15 Jan

8:06 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2012-01-15 15:06:27 EST --- Package lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-0449/lv2-kn0ck0ut-1.1-0.... then log in and leave karma (feedback).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2 Feb 2 Feb

5:22 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Fedora Update System updates@fedoraproject.org changed:

--- Comment #15 from Fedora Update System updates@fedoraproject.org 2012-02-02 12:22:55 EST --- lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:30 p.m.

New subject: [Bug 766154] Review Request: lv2-kn0ck0ut - An LV2 spectral subtraction plugin (linux audio)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=766154

Fedora Update System updates@fedoraproject.org changed:

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2012-02-02 12:30:08 EST --- lv2-kn0ck0ut-1.1-0.3.git60421a3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5123

Age (days ago)

5177

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla