[Bug 2122024] New: Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024

            Bug ID: 2122024
           Summary: Review Request: golang-github-cloudflare-circl -
                    CIRCL: Cloudflare Interoperable Reusable Cryptographic
                    Library
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: mikel(a)olasagasti.info
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL:
https://mikel.olasagasti.info/tmp/fedora/golang-github-cloudflare-circl.spec
SRPM URL:
https://mikel.olasagasti.info/tmp/fedora/golang-github-cloudflare-circl-1...
Description: CIRCL: Cloudflare Interoperable Reusable Cryptographic Library.
Fedora Account System Username: mikelo2


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024

Mikel Olasagasti Uranga <mikel(a)olasagasti.info&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
         Depends On|                            |2122023





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2122023
[Bug 2122023] Review Request: golang-github-bwesterb-ristretto - Pure Go
implementation of the Ristretto prime-order group over Edwards25519
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024



--- Comment #1 from Mikel Olasagasti Uranga <mikel(a)olasagasti.info&gt; ---
Fedora-review:
https://download.copr.fedorainfracloud.org/results/mikelo2/crypto-specs/f...
Build:
https://copr.fedorainfracloud.org/coprs/mikelo2/crypto-specs/build/4772977/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024

Maxwell G <gotmax(a)e.email&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gotmax(a)e.email



--- Comment #2 from Maxwell G <gotmax(a)e.email&gt; ---
Created attachment 1909682
  --> https://bugzilla.redhat.com/attachment.cgi?id=1909682&action=edit
Install missing license file

There's a license file in the source tree that you didn't install. Please see
the attached patch.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024



--- Comment #3 from Mikel Olasagasti Uranga <mikel(a)olasagasti.info&gt; ---
Spec URL:
https://mikel.olasagasti.info/tmp/fedora/golang-github-cloudflare-circl.spec
SRPM URL:
https://mikel.olasagasti.info/tmp/fedora/golang-github-cloudflare-circl-1...

Added missing license, good catch.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024



--- Comment #4 from Maxwell G <gotmax(a)e.email&gt; ---
It looks like you forgot to upload the new specfile.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024



--- Comment #5 from Mikel Olasagasti Uranga <mikel(a)olasagasti.info&gt; ---
It's a cache problem, can you retry? I need to check my webserver to avoid
caching specs.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024



--- Comment #6 from Maxwell G <gotmax(a)e.email&gt; ---
(In reply to Mikel Olasagasti Uranga from comment #5)
>  It's a cache problem, can you retry? I need to check my webserver
> to avoid
>  caching specs. 
Ah. Ctrl+Shift+R works.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024

Maxwell G <gotmax(a)e.email&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody(a)fedoraproject.org    |gotmax(a)e.email
              Flags|                            |fedora-review+
             Status|NEW                         |POST



--- Comment #7 from Maxwell G <gotmax(a)e.email&gt; ---
I am not going to go through the whole fedora-review template, as this package
uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi
ticket.

If you have time to look at any of my review requests, that would be nice ;).
See https://bugzilla.redhat.com/buglist.cgi?component=Package
Review&email1=gotmax%40e.email&emailreporter1=1&emailtype1=substring&query_format=advanced&status=NEW

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024



--- Comment #8 from Maxwell G <gotmax(a)e.email&gt; ---
https://bugzilla.redhat.com/buglist.cgi?component=Package%20Review&em...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024



--- Comment #9 from Gwyn Ciesla <gwync(a)protonmail.com&gt; ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-cloudflare-circl


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024
Bug 2122024 depends on bug 2122023, which changed state.

Bug 2122023 Summary: Review Request: golang-github-bwesterb-ristretto - Pure Go
implementation of the Ristretto prime-order group over Edwards25519
https://bugzilla.redhat.com/show_bug.cgi?id=2122023

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-a68b00e6fb has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-a68b00e6fb


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2122024

[Bug 2122024] Review Request: golang-github-cloudflare-circl - CIRCL: Cloudflare Interoperable Reusable Cryptographic Library

https://bugzilla.redhat.com/show_bug.cgi?id=2122024

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2022-09-08 21:42:35



--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2022-a68b00e6fb has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2122024