Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059
Summary: Review Request: cowsay - configurable speaking/thinking cow Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mr.ecik@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://ecik.nonlogic.org/cowsay/cowsay.spec SRPM URL: http://ecik.nonlogic.org/cowsay/cowsay-3.03-1.src.rpm Description: cowsay is a configurable talking cow, written in Perl. It operates much as the figlet program does, and it written in the same spirit of silliness. It generates ASCII pictures of a cow with a message. It can also generate pictures of other animals.
rpmlint gives following output: W: cowsay non-conffile-in-etc /etc/bash_completion.d/cowsay.bashcomp but that same output is given on rpmlint.rpm so it looks like we can ignore it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cowsay - configurable speaking/thinking cow
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-01 22:58 EST ------- Actually I know this application because I use this for cowsaver, one of hacks which can be used for xscreensaver.
I will review this.
* Use "cp -p" to keep timestamps ("Timestamps" in http://fedoraproject.org/wiki/Packaging/Guidelines )
* Please fix the description of man package according to installed paths.
* How about randomize a cow which is choosen?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cowsay - configurable speaking/thinking cow
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-01 23:05 EST ------- Created an attachment (id=144618) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=144618&action=vie...) wrapper script I use to randomize cowsay
c.f.
"animalsay", which I use for cowsaver to randomize animal used by cowsay.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cowsay - configurable speaking/thinking cow
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059
------- Additional Comments From mr.ecik@gmail.com 2007-01-02 12:39 EST ------- Thanks for review! I have uploaded new SRPM and Spec files: Spec URL: http://ecik.nonlogic.org/cowsay/cowsay.spec SRPM URL: http://ecik.nonlogic.org/cowsay/cowsay-3.03-2.src.rpm
I hope it's good enough right now :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cowsay - configurable speaking/thinking cow
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-02 13:37 EST ------- [tasaka1@localhost cowsay]$ cat 1.log | animalsay -W 100 _____________________________________________________________________________________________________
/ Thank you for adding my "animalsay" script!! \ | | | Well, = rpmlint issue | | | | W: cowsay non-conffile-in-etc /etc/bash_completion.d/cowsay.bashcomp | | | | = This _must_ be ignored for this case. = Timestamps, man file description are now okay. = License, | | md5sum okay = Other things are also okay... accroding to | | | | http://fedoraproject.org/wiki/Packaging/Guidelines | | | | http://fedoraproject.org/wiki/Packaging/ReviewGuidelines | | | | ----------------------------------------------------------- | | | \ This package (cowsay) is APPROVED by me. / -----------------------------------------------------------------------------------------------------
\ ____ \ / \ | ^__^ | | (oo) |______ | (__) | )/\ ____/|----w | || ||
Moofasa
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cowsay - configurable speaking/thinking cow
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221059
mr.ecik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mr.ecik@gmail.com 2007-01-02 15:49 EST ------- _____________________________________________________ / I had to slightly modify animalsay script ;-) \ | | | Thank you again for review! | | | | Package succesfully built for FC-5, FC-6 and devel. | | | \ Closing. / ----------------------------------------------------- \ \ .--. |o_o | |:_/ | // \ \ (| | ) /'_ _/`\ ___)=(___/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cowsay - configurable speaking/thinking cow
https://bugzilla.redhat.com/show_bug.cgi?id=221059
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
jonstanley@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jonstanley@gmail.com Flag| |fedora-cvs?
------- Additional Comments From jonstanley@gmail.com 2008-05-05 17:45 EST ------- Package Change Request ====================== Package Name: cowsay Updated EPEL Owners: jstanley New Branches: EL-4 EL-5
____________ < Thank You! > ------------ \ \ .--. |o_o | |:_/ | // \ \ (| | ) /'_ _/`\ ___)=(___/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cowsay - configurable speaking/thinking cow
https://bugzilla.redhat.com/show_bug.cgi?id=221059
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-05-05 17:56 EST ------- cvs done.
package-review@lists.fedoraproject.org