https://bugzilla.redhat.com/show_bug.cgi?id=1645922
Bug ID: 1645922 Summary: Review Request: gsignond-plugin-lastfm - Last.FM plugin for gsignond Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://decathorpe.fedorapeople.org/packages/gsignond-plugin-lastfm.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/gsignond-plugin-lastfm-0-0.1.20...
Description: This plugin for the Accounts-SSO gSignOn daemon handles the Last.FM credentials.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=30673384
Note: Running mock builds locally will require the "--enablerepo=local" flag until the next rawhide compose, because there was no successful one since I built gsignond-1.2.0.
PS: Upstream might tag a release of this project soon, I'll update the packaging for that as soon as it happens, be it before or after a successful review.
https://bugzilla.redhat.com/show_bug.cgi?id=1645922
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1512217 | |(PantheonDesktopPackageRevi | |ews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1512217 [Bug 1512217] Tracking: Pantheon Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1645922
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - date should be the date where you took the snapshot, not the date of the commit:
%global commitdate 20180507
Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License (v2 or later)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gsignond-plugin-lastfm /review-gsignond-plugin-lastfm/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gsignond-plugin-lastfm-debuginfo , gsignond-plugin-lastfm-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gsignond-plugin-lastfm-0-0.1.20180507.git0a7a5f8.fc30.x86_64.rpm
gsignond-plugin-lastfm-debuginfo-0-0.1.20180507.git0a7a5f8.fc30.x86_64.rpm
gsignond-plugin-lastfm-debugsource-0-0.1.20180507.git0a7a5f8.fc30.x86_64.rpm gsignond-plugin-lastfm-0-0.1.20180507.git0a7a5f8.fc30.src.rpm gsignond-plugin-lastfm.x86_64: W: spelling-error %description -l en_US gSignOn -> signings gsignond-plugin-lastfm.src: W: spelling-error %description -l en_US gSignOn -> signings 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1645922
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
dist-git Repository request: https://pagure.io/releng/fedora-scm-requests/issue/8721
https://bugzilla.redhat.com/show_bug.cgi?id=1645922
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-11-08 16:37:05
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=30743567
package-review@lists.fedoraproject.org