https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Bug ID: 1231351 Summary: Review Request: php-cdb - CDB functions for PHP Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@cchtml.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://michael.cronenworth.com/RPMS/php-cdb.spec SRPM URL: http://michael.cronenworth.com/RPMS/php-cdb-1.0.1-1.fc21.src.rpm Description: CDB functions for PHP, split out of mediawiki Fedora Account System Username: mooninite
$ rpmlint php-cdb.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/SRPMS/php-cdb-1.0.1-1.fc21.src.rpm php-cdb.src: W: spelling-error %description -l en_US dba -> dab, db, bad 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1230630
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1230630 [Bug 1230630] MediaWiki fails with "requires the PSR-3 logging library to be present"
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.iwinski@gmail.com
--- Comment #1 from Shawn Iwinski shawn.iwinski@gmail.com --- * Shouldn't source come from https://github.com/wikimedia/cdb as that's where Composer installs from? -- https://packagist.org/packages/wikimedia/cdb
* Per https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme, name should be "php-wikimedia-cdb"
* Per https://fedoraproject.org/wiki/Packaging:PHP#File_Placement, install path should be "/usr/share/php/Cdb/*" to be PSR-0 compliant
* Per https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages, need to provide "php-composer(wikimedia/cdb) = %{version}"
* Tests are provided so they should be run in %check
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: php-cdb - |Review Request: |CDB functions for PHP |php-wikimedia-cdb - CDB | |functions for PHP
--- Comment #2 from Michael Cronenworth mike@cchtml.com --- http://michael.cronenworth.com/RPMS/php-wikimedia-cdb.spec http://michael.cronenworth.com/RPMS/php-wikimedia-cdb-1.0.1-2.fc21.src.rpm
Upstream is Wikimedia's git. Why is it preferred to use the github mirror? The provided test can only be loaded through composer.
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #3 from Remi Collet fedora@famillecollet.com --- See #1231356 for a simple fix to run the test suite.
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
--- Comment #4 from Michael Cronenworth mike@cchtml.com --- Added tests and composer.json.
http://michael.cronenworth.com/RPMS/php-wikimedia-cdb.spec http://michael.cronenworth.com/RPMS/php-wikimedia-cdb-1.0.1-3.fc22.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Created attachment 1043006 --> https://bugzilla.redhat.com/attachment.cgi?id=1043006&action=edit phpci.log
phpCompatInfo version 4.3.0 DB built Jun 21 2015 20:17:04 CEST static analyze results
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Created attachment 1043007 --> https://bugzilla.redhat.com/attachment.cgi?id=1043007&action=edit review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #7 from Remi Collet fedora@famillecollet.com --- [!]: License field in the package spec file matches the actual license. from file headers * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. => GPLv2+
[~]: Requires correct, justified where necessary. missing php-spl (because of autoloader) php-dba is optional, but ok (packager choice).
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
--- Comment #8 from Michael Cronenworth mike@cchtml.com --- Thanks for catching the missing +.
The php-dba package is required to perform the unit test.
http://michael.cronenworth.com/RPMS/php-wikimedia-cdb.spec http://michael.cronenworth.com/RPMS/php-wikimedia-cdb-1.0.1-4.fc22.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #9 from Remi Collet fedora@famillecollet.com --- -License: GPLv2 +License: GPLv2+
[x]: License field in the package spec file matches the actual license.
+Requires: php-spl
[x]: Requires correct, justified where necessary.
=== APPROVED ===
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Michael Cronenworth mike@cchtml.com --- Thanks for the review.
New Package SCM Request ======================= Package Name: php-wikimedia-cdb Short Description: CDB functions for PHP Upstream URL: http://www.mediawiki.org/wiki/CDB Owners: mooninite Branches: f21 f22 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limburgher@gmail.com Flags|fedora-cvs+ |needinfo?(limburgher@gmail. | |com) fedora-cvs?
--- Comment #12 from Michael Cronenworth mike@cchtml.com --- Jon, the repo hasn't been made. Can you re-run?
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(limburgher@gmail. | |com) |
--- Comment #13 from Jon Ciesla limburgher@gmail.com --- this runs asynchronously and should exist by now.
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
--- Comment #14 from Michael Cronenworth mike@cchtml.com --- Ugh. I was typing "wikipedia" instead of "wikimedia". :(
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-cdb-1.0.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-wikimedia-cdb-1.0.1-1.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-cdb-1.0.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-wikimedia-cdb-1.0.1-1.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-cdb-1.0.1-1.fc22 has been pushed to the Fedora 22 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |php-wikimedia-cdb-1.0.1-1.f | |c21 Resolution|--- |ERRATA Last Closed| |2015-07-04 16:08:19
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-cdb-1.0.1-1.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1231351
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-wikimedia-cdb-1.0.1-1.f |php-wikimedia-cdb-1.0.1-1.f |c21 |c22
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-wikimedia-cdb-1.0.1-1.fc22 has been pushed to the Fedora 22 stable repository.
package-review@lists.fedoraproject.org