Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: evolution-tray - Tray plugin for evolution
https://bugzilla.redhat.com/show_bug.cgi?id=818991
Summary: Review Request: evolution-tray - Tray plugin for evolution Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jonas.rebmann@googlemail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://jor.netne.net/files/evolution-tray.spec SRPM URL: http://jor.netne.net/files/evolution-tray-0.0.8-1.fc16.src.rpm Description: This plugin puts evolution in "tray" (notification area). While in tray evolution in minimized and it's windows skip the pager. You can restore evolution on any workspace.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818991
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #1 from Mario Blättermann mario.blaettermann@gmail.com 2012-05-05 18:37:52 EDT --- This package needs libgconf-bridge, which is only available from Debian based distros. See the Koji scratch build [1] for more info. How do you've got it working on your machine without this?
Furthermore, intltool and libnotify-devel are missing from BuildRequires.
[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4057144
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #2 from jonas.rebmann@googlemail.com 2012-05-06 06:54:36 EDT --- Thank you. It compiled on my x86_64 f16 without any third party packages/libraries. gconf/gconf-client.h (which was the missing header in the build you posted) is provided by GConf2-devel. Libnotify-devel is not required.
I updated the spec and source rpm.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #3 from Mario Blättermann mario.blaettermann@gmail.com 2012-05-06 12:12:30 EDT --- (In reply to comment #2)
Thank you. It compiled on my x86_64 f16 without any third party packages/libraries. gconf/gconf-client.h (which was the missing header in the build you posted) is provided by GConf2-devel.
OK.
Libnotify-devel is not required.
The plugin's website says:
Dependencies
gtk+-2.0 (>= 2.14) libgconf-bridge libnotify
The following is from build.log (see Koji scratch build above):
checking for LIBNOTIFY... no Package libnotify was not found in the pkg-config search path. Perhaps you should add the directory containing `libnotify.pc' to the PKG_CONFIG_PATH environment variable No package 'libnotify' found
Means, the configure script is looking for libnotify, and is unable to find it. Well, could be that this plugin works without that, but if both website and configure script say that it is needed, it should be true. Another issue:
%{_libdir}/evolution/3.2/plugins/*
Once Evolution is bumped to a higher version number than 3.2, this declaration won't work anymore. Use instead:
%{_libdir}/evolution/*/plugins/*
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #4 from jonas.rebmann@googlemail.com 2012-05-09 15:53:25 EDT --- Ok, fixed it both
https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #5 from Mario Blättermann mario.blaettermann@gmail.com --- As far as I can see, you are not a member of the package maintainers group. If you need a sponsor, please add FE-NEEDSPONSOR to the "Blocks:" field above.
https://bugzilla.redhat.com/show_bug.cgi?id=818991
jonas.rebmann@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #6 from jonas.rebmann@googlemail.com --- I did that. What can I do next to get my Packages upstream?
https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #7 from Mario Blättermann mario.blaettermann@gmail.com --- (In reply to comment #6)
I did that. What can I do next to get my Packages upstream?
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
That's all I could recommend for now. Unfortunately, I cannot sponsor you.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #8 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi Jonas,
I am unable to access the spec file that you've put up. Are you working on getting sponsored and then continuing this review? If you're not up to it, I'd like to package this up and make it available in Fedora.
Thanks, Ankur
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818991
--- Comment #9 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- I can't build this. It requires "gconf/gconf-client.h" which doesn't seem to be available in Fedora. Will check gconf-bridge etc. and see. Some digging in required. Not quite sure how you built it Jonas.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818991
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jonas.rebmann@goo | |glemail.com)
https://bugzilla.redhat.com/show_bug.cgi?id=818991
asl97@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |asl97@outlook.com
--- Comment #10 from asl97@outlook.com --- i think it build fine with version 1.0, http://gnome.eu.org/cgit/evolution-tray/ but it doesn't seem to hide it when minimize nor does it maximize when it was click. in fact, it doesn't even seem to do anything other than place an icon in the tray...
https://bugzilla.redhat.com/show_bug.cgi?id=818991
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@redhat.com Flags| |needinfo?(aTe5bahc@spambog. | |com)
--- Comment #11 from Miroslav Suchý msuchy@redhat.com --- Ping! Are you still interrested in this review?
https://bugzilla.redhat.com/show_bug.cgi?id=818991
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |james.hogarth@gmail.com Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(aTe5bahc@spambog. | |com) | |needinfo?(aTe5bahc@spambog. | |com) | Last Closed| |2015-12-03 23:28:06
--- Comment #12 from James Hogarth james.hogarth@gmail.com --- Closing this bug as a dead review as the requester appears to have deactivated their bugzilla.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org