https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Bug ID: 1312577 Summary: Review Request: python-PyOpenGL - Python bindings for OpenGL Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jonathan.underwood@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fedorapeople.org/~jgu/python-PyOpenGL.spec SRPM URL: https://fedorapeople.org/~jgu/python-PyOpenGL-3.1.1a1-0.fc23.src.rpm Description: PyOpenGL is the cross platform Python binding to OpenGL and related APIs. It includes support for OpenGL v1.1, GLU, GLUT v3.7, GLE 3 and WGL 4. It also includes support for dozens of extensions (where supported in the underlying implementation). Fedora Account System Username: jgu
This is a rename review. The old package name was PyOpenGL, which provided the python2 bindings, and had subpackages for python3. This new package follows the modern python packaging guidelines:
1) The main package name is now python-PyOpenGL 2) There are separate subpackages for python2-PyOpenGL and python3-PyOpenGL 3) The python2-PyOpenGL package has Obsoletes and Provides for PyOpenGL so as not to break upgrade paths 4) The python 2 Tk subpackage is now called python2-PyOpenGL-Tk, and has Obsoletes and Provides for the old name of the subpackage, PyOpenGL-Tk.
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Under the python2-* subpackages, your Provides should be set to be equal to %{version}-%{release}, as you are providing the equivalent package under a different name.
For example, the Obsoletes+Provides pair for python2-PyOpenGL should be: Obsoletes: PyOpenGL < 3.1.0-7 Provides: PyOpenGL = %{version}-%{release}
Same goes for the python2-PyOpenGL-Tk package.
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
--- Comment #2 from Jonathan Underwood jonathan.underwood@gmail.com --- Spec URL: https://fedorapeople.org/~jgu/python-PyOpenGL.spec SRPM URL: https://fedorapeople.org/~jgu/python-PyOpenGL-3.1.1a1-1.fc23.src.rpm
* Sat Feb 27 2016 Jonathan Underwood <Jonathan G. Underwood@gmail.com> - 3.1.1a1-1 - Fix Provides for renamed sub-packages - Use standard build and install python packaging macros
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Jonathan Underwood jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1249421
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1249421 [Bug 1249421] PyOpenGL needs python2 provide
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The guidelines changed a while ago, and package names should be lowercase [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming].
Looks good otherwise.
rpmlint: only no-documentation, and bogus spelling errors.
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
--- Comment #4 from Raphael Groner projects.rg@smart.ms --- Why not use the name python-opengl, so subpackages python3-opengl and python2-opengl?
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
--- Comment #5 from Jonathan Underwood jonathan.underwood@gmail.com --- Spec URL: https://fedorapeople.org/~jgu/python-pyopengl.spec SRPM URL: https://fedorapeople.org/~jgu/python-pyopengl-3.1.1a1-1.fc23.src.rpm
* Sat Feb 27 2016 Jonathan Underwood <Jonathan G. Underwood@gmail.com> - 3.1.1a1-2 - Rename package to python-pyopengl - Rename -Tk subpackages to -tk - Fix Requires of python2-pyopengl-Tk to require python2-pyopengl
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
--- Comment #6 from Jonathan Underwood jonathan.underwood@gmail.com --- (In reply to Raphael Groner from comment #4)
Why not use the name python-opengl, so subpackages python3-opengl and python2-opengl?
Well... because the name of the project is pyopengl/PyOpenGl. And in the future, there might well be another project calling itself python-opengl (the pyopengl bindings are only one way this could be done, and have some limitations -in fact there are other bindings that people are working on).
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Jonathan Underwood jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-PyOpenGL - Python |python-pyopengl - Python |bindings for OpenGL |bindings for OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
--- Comment #7 from Jonathan Underwood jonathan.underwood@gmail.com --- Spec URL: https://fedorapeople.org/~jgu/python-pyopengl.spec SRPM URL: https://fedorapeople.org/~jgu/python-pyopengl-3.1.1a1-3.fc23.src.rpm
* Sat Feb 27 2016 Jonathan Underwood <Jonathan G. Underwood@gmail.com> - 3.1.1a1-3 - Fix python_provide macro calls for the -tk packages
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Looks good. I tested the upgrade path in rawhide, no issues.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
--- Comment #9 from Jonathan Underwood jonathan.underwood@gmail.com --- Great, thanks for the review, much appreciated.
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-pyopengl
https://bugzilla.redhat.com/show_bug.cgi?id=1312577
Jonathan Underwood jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-02-29 09:35:28
package-review@lists.fedoraproject.org