[Bug 1597862] New: Review Request: gr-hpsdr - GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
Bug ID: 1597862 Summary: Review Request: gr-hpsdr - GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jskarvad@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr-1.2-1.fc28.src.rpm Description: GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol. Fedora Account System Username: jskarvad
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - make install DESTDIR=%{buildroot} → %make_install
- %?ldconfig_post
%?ldconfig_postun
Just use %ldconfig_scriptlets
- Build fails:
DEBUG util.py:489: BUILDSTDERR: Error: DEBUG util.py:489: BUILDSTDERR: Problem: package gnuradio-devel-3.7.13.3-3.fc29.x86_64 requires libgnuradio-pmt-3.7.13.3.so.0.0.0()(64bit), but none of the providers can be installed DEBUG util.py:489: BUILDSTDERR: - conflicting requests DEBUG util.py:489: BUILDSTDERR: - nothing provides PyOpenGL needed by gnuradio-3.7.13.3-3.fc29.x86_64
python-pyopngl removed its Provides: PyOpenGL so gnuradio should Requires: python2-pyopengl instead.
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #2 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Robert-André Mauchin from comment #1)
python-pyopngl removed its Provides: PyOpenGL so gnuradio should Requires: python2-pyopengl instead.
Fixed in gnuradio-3.7.13.3-4.fc29.
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #3 from Jaroslav Škarvada jskarvad@redhat.com --- Spec URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr-1.2-2.fc28.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- %make_install, not make install
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- Also why don't you want to use %ldconfig_scriptlets
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #6 from Robert-André Mauchin zebob.m@gmail.com --- Somithing's wrong with the latest gnuradio:
DEBUG util.py:491: (193/193): gnuradio-3.7.13.3-4.fc29.x86_64.rpm 1.3 MB/s | 160 MB 02:02 DEBUG util.py:491: -------------------------------------------------------------------------------- DEBUG util.py:491: Total 2.4 MB/s | 340 MB 02:19 DEBUG util.py:491: Running transaction check DEBUG util.py:491: Transaction check succeeded. DEBUG util.py:491: Running transaction test DEBUG util.py:489: BUILDSTDERR: Error: Transaction check error: DEBUG util.py:489: BUILDSTDERR: file /usr/bin from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64 DEBUG util.py:489: BUILDSTDERR: file /usr/lib from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64 DEBUG util.py:489: BUILDSTDERR: file /usr/lib64 from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #7 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Robert-André Mauchin from comment #6)
Somithing's wrong with the latest gnuradio:
DEBUG util.py:491: (193/193): gnuradio-3.7.13.3-4.fc29.x86_64.rpm 1.3 MB/s | 160 MB 02:02 DEBUG util.py:491:
DEBUG util.py:491: Total 2.4 MB/s | 340 MB 02:19 DEBUG util.py:491: Running transaction check DEBUG util.py:491: Transaction check succeeded. DEBUG util.py:491: Running transaction test DEBUG util.py:489: BUILDSTDERR: Error: Transaction check error: DEBUG util.py:489: BUILDSTDERR: file /usr/bin from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64 DEBUG util.py:489: BUILDSTDERR: file /usr/lib from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64 DEBUG util.py:489: BUILDSTDERR: file /usr/lib64 from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64
This is probably something wrong with the rpmbuild, because in new gnuradio there are now provides: drwxr-xr-x /usr drwxr-xr-x /usr/bin
for the following glob: %{_bindir}/*
i.e. nothing changed in the spec, and it seems it's the same for all similar globs.
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #8 from Jaroslav Škarvada jskarvad@redhat.com --- Spec URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr-1.2-3.fc28.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #9 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Jaroslav Škarvada from comment #7)
(In reply to Robert-André Mauchin from comment #6)
Somithing's wrong with the latest gnuradio:
DEBUG util.py:491: (193/193): gnuradio-3.7.13.3-4.fc29.x86_64.rpm 1.3 MB/s | 160 MB 02:02 DEBUG util.py:491:
DEBUG util.py:491: Total 2.4 MB/s | 340 MB 02:19 DEBUG util.py:491: Running transaction check DEBUG util.py:491: Transaction check succeeded. DEBUG util.py:491: Running transaction test DEBUG util.py:489: BUILDSTDERR: Error: Transaction check error: DEBUG util.py:489: BUILDSTDERR: file /usr/bin from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64 DEBUG util.py:489: BUILDSTDERR: file /usr/lib from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64 DEBUG util.py:489: BUILDSTDERR: file /usr/lib64 from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.9-1.fc29.x86_64
This is probably something wrong with the rpmbuild, because in new gnuradio there are now provides: drwxr-xr-x /usr drwxr-xr-x /usr/bin
for the following glob: %{_bindir}/*
i.e. nothing changed in the spec, and it seems it's the same for all similar globs.
Hmm, maybe just some inconsistency on the builder, because I am unable to reproduce when building locally, I will try to rebuild.
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #10 from Robert-André Mauchin zebob.m@gmail.com --- I rebuild gnuradio locally and I war able to reproduce:
Error: Transaction check error: file /usr/bin from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.8-2.fc28.x86_64 file /usr/lib from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.8-2.fc28.x86_64 file /usr/lib64 from install of gnuradio-3.7.13.3-4.fc29.x86_64 conflicts with file from package filesystem-3.8-2.fc28.x86_64
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #11 from Jaroslav Škarvada jskarvad@redhat.com --- Please try with gnuradio-3.7.13.3-7.fc29.
I am going to rebase gnuradio to gnuradio-3.7.13.4 today, so the gnuradio stack can be broken for a moment (but hopefully chain build will do it :)
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #12 from Robert-André Mauchin zebob.m@gmail.com --- - Use %{python2_sitearch} instead of %{python_sitearch} and add python2-devel as a BR otherwise this macro evaluate to nil, which results in including all files in the main package.
- Shorten the summary and split the descripteon lines to stay below 80 characters per line:
gr-hpsdr.x86_64: E: summary-too-long C GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol gr-hpsdr.x86_64: E: description-line-too-long C GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol.
- You must own these directories:
[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gnuradio, /usr/share/gnuradio/grc, /usr/share/gnuradio/grc/blocks
%dir %{_datadir}/gnuradio %dir %{_datadir}/gnuradio/grc %dir %{_datadir}/gnuradio/grc/blocks/
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 22 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gr-hpsdr/review-gr-hpsdr/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gnuradio, /usr/share/gnuradio/grc, /usr/share/gnuradio/grc/blocks [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gr-hpsdr-1.2-3.fc29.x86_64.rpm gr-hpsdr-devel-1.2-3.fc29.x86_64.rpm gr-hpsdr-doc-1.2-3.fc29.noarch.rpm gr-hpsdr-debuginfo-1.2-3.fc29.x86_64.rpm gr-hpsdr-debugsource-1.2-3.fc29.x86_64.rpm gr-hpsdr-1.2-3.fc29.src.rpm gr-hpsdr.x86_64: E: summary-too-long C GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol gr-hpsdr.x86_64: E: description-line-too-long C GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol. gr-hpsdr.x86_64: W: shared-lib-calls-exit /usr/lib64/libgnuradio-hpsdr.so.0.0.0 exit@GLIBC_2.2.5 gr-hpsdr-devel.x86_64: W: no-documentation gr-hpsdr.src: E: summary-too-long C GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol gr-hpsdr.src: E: description-line-too-long C GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol. 6 packages and 0 specfiles checked; 4 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #13 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Robert-André Mauchin from comment #12) Thanks for te review
%dir %{_datadir}/gnuradio %dir %{_datadir}/gnuradio/grc %dir %{_datadir}/gnuradio/grc/blocks/
It's owned (and should be owned) by gnuradio: $ rpmls ./gnuradio-3.7.13.4-1.fc29.x86_64.rpm | grep /share/gnuradio$ drwxr-xr-x /usr/share/gnuradio $ rpmls ./gnuradio-3.7.13.4-1.fc29.x86_64.rpm | grep /share/gnuradio/grc$ drwxr-xr-x /usr/share/gnuradio/grc $ rpmls ./gnuradio-3.7.13.4-1.fc29.x86_64.rpm | grep /share/gnuradio/grc/blocks$ drwxr-xr-x /usr/share/gnuradio/grc/blocks
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #14 from Jaroslav Škarvada jskarvad@redhat.com --- Spec URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr-1.2-4.fc29.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #15 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #16 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gr-hpsdr
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2018-07-20 11:45:28
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- gr-hpsdr-1.2-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e736b3cbf
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- gr-hpsdr-1.2-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e736b3cbf
https://bugzilla.redhat.com/show_bug.cgi?id=1597862
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NEXTRELEASE |ERRATA
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- gr-hpsdr-1.2-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com