[Bug 1272134] New: Review Request: python-journal-brief - Find new systemd journal entries since last run
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
Bug ID: 1272134 Summary: Review Request: python-journal-brief - Find new systemd journal entries since last run Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: twaugh@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://twaugh.fedorapeople.org/journal-brief/python-journal-brief.spec SRPM URL: https://twaugh.fedorapeople.org/journal-brief/python-journal-brief-1.1.1-1.f... Description: Python module for examining, bookmarking, and filtering systemd journal entries.
Fedora Account System Username: twaugh
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #1 from Matthew Miller mattdm@redhat.com --- I'm getting build errors in mock (both f22 and rawhide). Will have to diagnose whether that's my system or a real problem. :)
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- twaugh's scratch build of python-journal-brief-1.1.1-1.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11471622
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #3 from Tim Waugh twaugh@redhat.com --- Looks like I missed some dependencies. Will fix.
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- twaugh's scratch build of python-journal-brief-1.1.1-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11471937
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #5 from Tim Waugh twaugh@redhat.com --- Updated package now at URL in comment #0.
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
Jiri Popelka jpopelka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jpopelka@redhat.com Assignee|nobody@fedoraproject.org |jpopelka@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
Jiri Popelka jpopelka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Jiri Popelka jpopelka@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: Final provides and requires are sane. [x]: Package functions as described. [x]: Latest version is packaged. [x]: %check is present and all tests pass. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Package is Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #7 from Tim Waugh twaugh@redhat.com --- Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
Tim Waugh twaugh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2015-10-16 09:32:35
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-journal-brief-1.1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c5d59f8cb
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-journal-brief-1.1.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-fd66614a77
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|NEXTRELEASE |--- Keywords| |Reopened
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-journal-brief-1.1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-journal-brief' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c5d59f8cb
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-journal-brief-1.1.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-journal-brief' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-fd66614a77
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
Tim Waugh twaugh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed|2015-10-16 09:32:35 |2015-10-20 05:54:24
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-journal-brief-1.1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1272134
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-journal-brief-1.1.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla