[Bug 1476573] New: Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Bug ID: 1476573
           Summary: Review Request: deepin-mutter - Base window manager
                    for deepin, fork of gnome mutter
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

SPEC:
https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepi...

SRPM:
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...

Description: Base window manager for deepin, fork of gnome mutter

Fedora Account System Username: mosquito

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1465889
                   |                            |(DeepinDEPackageReview)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Robin Lee  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1421055

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1421055
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/GLES
Utility Layer for Deepin

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

--- Comment #1 from [e-mail] ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x8...

Rlease 3.20.21.

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1485721

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1485721
[Bug 1485721] Review Request: deepin-wm - Deepin Window Manager

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

--- Comment #3 from [e-mail] ---
Hi @zebob

Package is ready. Could you review it?

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

--- Comment #4 from Robert-André Mauchin  ---
Should you do like with deepin-cogl, i.e. make the changes done by the Deepin
team go upstream?

I'll review it this evening or tomorrow

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

--- Comment #5 from Robert-André Mauchin  ---
 - glib-compile-schemas is not needed on Fedora 24 and above, you should remove
it. See
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=4...
Just leave this:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

- This file should be in the -devel subpackage, not the main one:

deepin-mutter.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/deepin-mutter/Meta-3.0.gir

You can fix this with:

%files -f %{name}.lang
%doc README.md
%license LICENSE
%{_bindir}/%{name}
%{_libdir}/lib%{name}.so.*
%{_libdir}/%{name}/
%exclude %{_libdir}/%{name}/Meta-3.0.gir
%{_libexecdir}/%{name}/mutter-restart-helper
%{_datadir}/GConf/gsettings/%{name}-schemas.convert
%{_datadir}/applications/%{name}.desktop
%{_datadir}/glib-2.0/schemas/*.xml
%{_datadir}/gnome-control-center/keybindings/50-%{name}-*.xml
%{_mandir}/man1/%{name}.1.gz

%files devel
%{_includedir}/%{name}/
%{_libdir}/%{name}/Meta-3.0.gir
%{_libdir}/pkgconfig/lib%{name}.pc
%{_libdir}/lib%{name}.so

- The description line should be split to stay below 80 characters per line:

deepin-mutter-devel.x86_64: E: description-line-too-long C Header files and
libraries for base window manager for deepin, fork of gnome mutter.

- You have lots of files which contains an incorrect FSF address in the
header. You should patch those files and report the issue upstream:

deepin-mutter-devel.x86_64: E: incorrect-fsf-address
/usr/include/deepin-mutter/meta/meta-backend.h
deepin-mutter-devel.x86_64: E: incorrect-fsf-address
/usr/include/deepin-mutter/meta/meta-monitor-manager.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-backend-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-backend.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-barrier-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-cursor-renderer.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-cursor-renderer.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-pointer-constraint.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-pointer-constraint.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-stage.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/meta-stage.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/dbus-utils.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/dbus-utils.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-backend-native-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-backend-native.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-backend-native.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-barrier-native.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-barrier-native.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-cursor-renderer-native.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-cursor-renderer-native.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-input-settings-native.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-launcher.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-launcher.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/native/meta-monitor-manager-kms.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/meta-backend-x11.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/meta-backend-x11.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/meta-barrier-x11.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/meta-barrier-x11.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/meta-cursor-renderer-x11.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/meta-cursor-renderer-x11.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/meta-input-settings-x11.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/nested/meta-cursor-renderer-x11-nested.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/backends/x11/nested/meta-cursor-renderer-x11-nested.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/compositor/meta-shaped-texture-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/compositor/meta-surface-actor-wayland.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/compositor/meta-surface-actor-wayland.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/compositor/meta-surface-actor-x11.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/compositor/meta-surface-actor-x11.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/core/meta-accel-parse.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/core/meta-accel-parse.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/core/meta-border.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/core/meta-border.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/core/meta-gesture-tracker-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/core/meta-gesture-tracker.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/core/util-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/meta/meta-backend.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/meta/meta-monitor-manager.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-pointer-confinement-wayland.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-pointer-confinement-wayland.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-pointer-lock-wayland.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-pointer-lock-wayland.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-buffer.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-buffer.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-data-device-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-keyboard.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-keyboard.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-outputs.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-outputs.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-pointer-constraints.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-pointer-constraints.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-pointer-gesture-pinch.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-pointer-gesture-swipe.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-pointer-gestures.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-region.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-region.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-seat.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-seat.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-surface.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-surface.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-touch.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland-types.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-wayland.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-window-wayland.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-window-wayland.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-xwayland-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-xwayland-selection-private.h
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-xwayland.c
deepin-mutter-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/deepin-mutter-3.20.21-1.fc28.x86_64/src/wayland/meta-xwayland.h

Something like this would do the trick in %prep:

find . -type f  -print0 | xargs -0 sed -i 's|59 Temple Place - Suite 330|51
Franklin Street, Fifth Floor|'
find . -type f  -print0 | xargs -0 sed -i 's|02111-1307|02110-1301|'

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

--- Comment #6 from [e-mail] ---
https://koji.fedoraproject.org/koji/taskinfo?taskID=22328492

Fixed, thanks.

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-mutter

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #7 from Robert-André Mauchin  ---
Okay, it seems good, package accepted.

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573
Bug 1476573 depends on bug 1421055, which changed state.

Bug 1421055 Summary: Review Request: deepin-cogl - An object oriented GL/GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

--- Comment #2 from [e-mail] ---
SRPM: 
https://kojipkgs.fedoraproject.org//work/tasks/4895/22284895/deepin-mutter-3...

https://koji.fedoraproject.org/koji/taskinfo?taskID=22284894

Fix build error for rawhide.

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Alias|                            |deepin-mutter

[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Zamir SUN  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2018-07-22 09:31:12

--- Comment #9 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.