[Bug 1308561] New: Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Bug ID: 1308561
           Summary: Review Request: sway - i3-compatible window manager
                    for Wayland
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://fale.fedorapeople.org/rpms/sway.spec
SRPM URL:
https://fale.fedorapeople.org/rpms/sway-0-1.20160214git016a774.fc23.src.rpm
Description: i3-compatible window manager for Wayland
Fedora Account System Username: fale

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Fabio Alessandro Locati  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1308480

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1308480
[Bug 1308480] Review Request: wlc - Wayland compositor library

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #1 from Fabio Alessandro Locati  ---
I've packaged the version 0.3 (current release):

SPEC: https://fale.fedorapeople.org/rpms/sway.spec
SRPM: https://fale.fedorapeople.org/rpms/sway-0.3-1.fc23.src.rpm

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #2 from Fabio Alessandro Locati  ---
I've updated to last released version:

SPEC: https://fale.fedorapeople.org/rpms/sway.spec
SRPM: https://fale.fedorapeople.org/rpms/sway-0.6-1.fc23.src.rpm

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #3 from Fabio Alessandro Locati  ---
I've updated to v0.7:

SPEC: https://fale.fedorapeople.org/rpms/sway.spec
SRPM: https://fale.fedorapeople.org/rpms/sway-0.7-1.fc23.src.rpm

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Adam Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |fedora-review?

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #4 from Fabio Alessandro Locati  ---
I've updated to v0.8:

SPEC: https://fale.fedorapeople.org/rpms/sway.spec
SRPM: https://fale.fedorapeople.org/rpms/sway-0.8-1.fc24.src.rpm

Thanks Adam for picking this review up :)

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #5 from Adam Miller  ---
Not a formal review yet, waiting on wlc to land in rawhide before starting
that.

However, I see that this "Requires ffmpeg" and ffmpeg isn't in Fedora and I'm
not entirely sure it can be because of patents. We might need to check with
legal.

Is ffmpeg a hard requirement?

-AdamM

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #6 from Johannes Pfrang  ---
In the AUR PKGBUILD [1] (maintained by the primary sway developer) ImageMagick
and ffmpeg are optional dependencies, which should probably translate to
'Suggests' in SPEC.

[1] https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=sway-git

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #8 from Adam Miller  ---
Apologies for the delay, I'm unsure of how to proceed here as we don't have
Guidelines for Weak Dependencies on things that are from third-party
repositories. I've created a ticket with the Fedora Council on the topic and
opened an email thread on the packaging list.

https://fedorahosted.org/council/ticket/61

https://lists.fedoraproject.org/archives/list/[e-mail]....

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Neal Gompa  ---
If you're going to use weak dependencies, avoid using Suggests/Enhances, since
libsolv based dependency resolvers do not provide a way to trigger the
installation of suggested packages (they are considered "hints" for
Recommends/Supplements).

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #10 from Neal Gompa  ---
Erk, they are also considered hints for Requires as well, to make it easier to
select something that "Provides" something when there are multiple providers.

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Adam Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561
Bug 1308561 depends on bug 1308480, which changed state.

Bug 1308480 Summary: Review Request: wlc - Wayland compositor library
https://bugzilla.redhat.com/show_bug.cgi?id=1308480

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #11 from Fabio Alessandro Locati  ---
Hi,
New version is available:

SPEC: https://fale.fedorapeople.org/rpms/sway.spec
SRPM: https://fale.fedorapeople.org/rpms/sway-0.9-1.fc24.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15117172

I've also commented out the requirements for non-core packages so we can maybe
move forward eventually adding them back if the Council decides to allow them.

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #12 from Fabio Alessandro Locati  ---
I've improved a little bit the dependencies and so forth:

SPEC: https://fale.fedorapeople.org/rpms/sway.spec
SRPM: https://fale.fedorapeople.org/rpms/sway-0.9-2.fc24.src.rpm

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #13 from Igor Gnatenko  ---
> Suggests:       xorg-x11-server-Xwayland

it doesn't make sense. convert to Recommends or drop.
>    -DCMAKE_BUILD_TYPE=Release \

drop this
>    -DCMAKE_INSTALL_PREFIX=/usr \

hardcoded paths, drop it.
>    -DCMAKE_INSTALL_SYSCONFDIR=%{_sysconfdir} \

drop it.
>    .

consider making out-of-tree build

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #14 from Fabio Alessandro Locati  ---
(In reply to Igor Gnatenko from comment #13)
> > Suggests:       xorg-x11-server-Xwayland
>
> it doesn't make sense. convert to Recommends or drop.

Why?
Recomments does not make sense IMHO since it can work properly without xorg
dependencies. Dropping it could be an idea (and was the situation before my
last update) but I think it's worth pointing it out since some user could want
to run X apps on it (without having the whole xorg installed).
> >    -DCMAKE_BUILD_TYPE=Release \
>
> drop this

In the Sway documentation is suggested to use it. Is there some Fedora reason
to not have it?
> >    -DCMAKE_INSTALL_SYSCONFDIR=%{_sysconfdir} \
>
> drop it.

In the Sway documentation is suggested to use it. Is there some Fedora reason
to not have it?
> consider making out-of-tree build

What do you mean? Why should I consider makin out-of-tree build?

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #15 from Igor Gnatenko  ---
(In reply to Fabio Alessandro Locati from comment #14)
> (In reply to Igor Gnatenko from comment #13)
> > > Suggests:       xorg-x11-server-Xwayland
> >
> > it doesn't make sense. convert to Recommends or drop.
>
> Why?
> Recomments does not make sense IMHO since it can work properly without xorg
> dependencies. Dropping it could be an idea (and was the situation before my
> last update) but I think it's worth pointing it out since some user could
> want to run X apps on it (without having the whole xorg installed).

Suggests means to prefer one package over the other, for example:
* Package: bar Provides: foo
* Package: baz Provides: foo
* Package: sway Suggests: bar
dnf install sway will install only sway.
now you do dnf install foo and most likely (it's too complicated process) "bar"
instead of "baz" will be installed as sway has Suggests.
> > >    -DCMAKE_BUILD_TYPE=Release \
> >
> > drop this
>
> In the Sway documentation is suggested to use it. Is there some Fedora
> reason to not have it?

because debuginfo will be broken, %cmake defines it as RelWithDebInfo.
> > >    -DCMAKE_INSTALL_SYSCONFDIR=%{_sysconfdir} \
> >
> > drop it.
>
> In the Sway documentation is suggested to use it. Is there some Fedora
> reason to not have it?

defined by %cmake.
> > consider making out-of-tree build
>
> What do you mean? Why should I consider makin out-of-tree build?

because it's good practice.
> %prep
> ...
> mkdir %{_target_platform}
> %build
> pushd %{_target_platform}
>   %cmake ..
> popd
> %make_build -C %{_target_platform}
> %install
> %make_install -C %{_target_platform}

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #16 from Fabio Alessandro Locati  ---
(In reply to Igor Gnatenko from comment #15)
> (In reply to Fabio Alessandro Locati from comment #14)
> > (In reply to Igor Gnatenko from comment #13)
> > > > Suggests:       xorg-x11-server-Xwayland
> > >
> > > it doesn't make sense. convert to Recommends or drop.
> >
> > Why?
> > Recomments does not make sense IMHO since it can work properly without xorg
> > dependencies. Dropping it could be an idea (and was the situation before my
> > last update) but I think it's worth pointing it out since some user could
> > want to run X apps on it (without having the whole xorg installed).
>
> Suggests means to prefer one package over the other, for example:
> Package: bar Provides: foo
> Package: baz Provides: foo
> Package: sway Suggests: bar
>
> dnf install sway will install only sway.
> now you do dnf install foo and most likely (it's too complicated process)
> "bar" instead of "baz" will be installed as sway has Suggests.

As discussed in chat with vondruch, your statement is not exact, since you are
assuming that the usage (and abuse) done by libsolv is the only possible use,
while it's not.
> > > >    -DCMAKE_INSTALL_SYSCONFDIR=%{_sysconfdir} \
> > >
> > > drop it.
> >
> > In the Sway documentation is suggested to use it. Is there some Fedora
> > reason to not have it?
>
> defined by %cmake.

This is not true, in fact if I don't put it, my config file is not places in
/etc/sway/config but in /usr/etc/sway/config

Thanks for the other tips, I have done a new build:

SPEC: https://fale.fedorapeople.org/rpms/sway.spec
SRPM: https://fale.fedorapeople.org/rpms/sway-0.9-3.fc24.src.rpm

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Adam Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #17 from Adam Miller  ---
It looks like everything I wanted cleaned up got cleaned up and since the
external packages are left out pending the Council's decision, I'm inclined to
approve. Apologies for the lag time on this.

APPROVED.

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #18 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/sway

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #19 from Fedora Update System  ---
sway-0.9-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4f53f0e6c9

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #20 from Fedora Update System  ---
sway-0.9-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-88448e465a

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #21 from Fedora Update System  ---
sway-0.9-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca479ecc25

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #22 from Fedora Update System  ---
sway-0.9-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-88448e465a

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #23 from Fedora Update System  ---
sway-0.9-3.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4f53f0e6c9

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #24 from Fedora Update System  ---
sway-0.9-3.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca479ecc25

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #25 from Fedora Update System  ---
sway-0.9-3.fc25 has been pushed to the Fedora 25 stable repository. If problems
still persist, please make note of it in this bug report.

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2016-08-27 06:16:11

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #26 from Fedora Update System  ---
sway-0.9-3.fc24 has been pushed to the Fedora 24 stable repository. If problems
still persist, please make note of it in this bug report.

[Bug 1308561] Review Request: sway - i3-compatible window manager for Wayland

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308561

--- Comment #27 from Fedora Update System  ---
sway-0.9-3.fc23 has been pushed to the Fedora 23 stable repository. If problems
still persist, please make note of it in this bug report.