[Bug 435541] New: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=435541

           Summary: Review Request: xfhell - GTK based Ham Radio application
                    for the Hellschreiber communications mode
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: bob(a)fedoraunity.org
         QAContact: extras-qa(a)fedoraproject.org
                CC: [e-mail],notting(a)redhat.com


Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-2.fc9.src.rpm
Description: xfhell is a GTK+ application for the "fuzzy" digital amateur radio
communication mode known as Hellschreiber. 

This package mock builds for Fedora 7, Fedora 8 and devel on i386 and x86_64. All
resulting rpms are rpmlint clean.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541


panemade(a)gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody(a)fedoraproject.org    |panemade(a)gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From kanarip(a)kanarip.com  2008-03-01 06:47 EST -------
Source http://5b4az.chronos.org.uk/pkg/hell/xfhell-1.3.tar.gz doesn't match with
the %{version} (xfhell-1.4)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From panemade(a)gmail.com  2008-03-01 07:01 EST -------
unable verify sources as 1.4 is not available.

Source URL should be
http://5b4az.chronos.org.uk/pkg/hell/%{name}-%{version}.tar.gz



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From panemade(a)gmail.com  2008-03-01 07:08 EST -------
make changes. provides new SRPM. Will review then.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From bob(a)fedoraunity.org  2008-03-01 13:50 EST -------
Do NOT package when tired... sorry about that.

Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-3.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541


kanarip(a)kanarip.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(bob(a)fedoraunity.or
                   |                            |g)




------- Additional Comments From kanarip(a)kanarip.com  2008-03-02 11:49 EST -------
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK (GPLv2+)
Actual License: OK (GPLv2+ from source code)
%doc License: OK (COPYING file included)
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum match after figuring out the exact
location of the upstream tarball)
Compile and Build:
 - F-7: OK
 - F-8: OK
 - rawhide: OK
 - EL-5: OK
 - koji scratch dist-f9: OK
Applicable Package Guidelines:
 - -debuginfo package: OK (~136K)
Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

Please adjust Source0 location to
http://5b4az.chronos.org.uk/pkg/%{name}/%{name}-%{version}.tar.gz please

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541


bob(a)fedoraunity.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(bob(a)fedoraunity.or|
                   |g)                          |




------- Additional Comments From bob(a)fedoraunity.org  2008-03-02 13:18 EST -------
New Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xfhell.spec
New SRPM URL:
http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xfhell-1.4-4.fc8.src.rpm

Scratch built in koji for devel

URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=484636

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541


panemade(a)gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade(a)gmail.com  2008-03-02 22:49 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=485859 
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
ecaf2a9a48478f45d56bffac35773a82  xfhell-1.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Desktop file installed correctly.
+ a GUI app.

 SHOULD:
   Ask upstream to add license file in next upstream tarball release.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541


bob(a)fedoraunity.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




------- Additional Comments From bob(a)fedoraunity.org  2008-03-03 00:34 EST -------
New Package CVS Request
=======================
Package Name: xfhell
Short Description: GTK based Ham Radio application for the Hellschreiber
communications mode
Owners: bjensen,sconklin
Branches: F-7 F-8
InitialCC: sindrepb
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541


kevin(a)tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+




------- Additional Comments From kevin(a)tummy.com  2008-03-03 15:14 EST -------
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From panemade(a)gmail.com  2008-03-12 23:14 EST -------
so is this package built on all requested brnaches?
If yes can we CLOSE this review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From bob(a)fedoraunity.org  2008-03-14 12:10 EST -------
I requested cvs and got sidetracked, then forgot, I will build and close today.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From updates(a)fedoraproject.org  2008-03-14 13:28 EST -------
xfhell-1.4-4.fc8 has been submitted as an update for Fedora 8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From updates(a)fedoraproject.org  2008-03-14 13:29 EST -------
xfhell-1.4-4.fc7 has been submitted as an update for Fedora 7

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541


bob(a)fedoraunity.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE




------- Additional Comments From bob(a)fedoraunity.org  2008-03-14 13:33 EST -------
Thank you for the review and reminder.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From updates(a)fedoraproject.org  2008-03-16 15:30 EST -------
xfhell-1.4-4.fc7 has been pushed to the Fedora 7 stable repository.  If problems still
persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 435541] Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber communications mode

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfhell - GTK based Ham Radio application for the Hellschreiber
communications mode


https://bugzilla.redhat.com/show_bug.cgi?id=435541





------- Additional Comments From updates(a)fedoraproject.org  2008-03-16 15:30 EST -------
xfhell-1.4-4.fc8 has been pushed to the Fedora 8 stable repository.  If problems still
persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.