[Bug 1015857] New: Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Bug ID: 1015857
           Summary: Review Request: golang-googlecode-sqlite - Trivial
                    sqlite3 binding for Go
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.1.h...

Description: Trivial sqlite3 binding for Go

Fedora Account System Username: lsm5

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6028690

Note: Pretty much the same as Bug 1009967, just that it didn't come with a
license file included so I installed the BSD license by myself.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1000662
           Assignee|[e-mail]    |[e-mail]

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1000662
[Bug 1000662] Review Request: docker-io - Automates deployment of
containerized applications

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #1 from Lokesh Mandvekar  ---
btw, docker 0.7-staging branch seems to use this package, that's why the review
request

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #2 from Vincent Batts  ---
> Note: Pretty much the same as Bug 1009967, just that it didn't come with a
> license file included so I installed the BSD license by myself.

This is consistent. Russ Cox's (a core golang developer) comment refers to a
LICENSE file that is not there. I'm guessing he's refering to the go compiler's
LICENSE.

// Copyright 2010 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #3 from Lokesh Mandvekar  ---
%changelog
* Tue Oct 08 2013 Lokesh Mandvekar  0-0.2.hg74691fb6f837
- exclusivearch as per golang
- debug_package nil

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.1.h...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #4 from Lokesh Mandvekar  ---
(In reply to Vincent Batts from comment #2)
> This is consistent. Russ Cox's (a core golang developer) comment refers to a
> LICENSE file that is not there. I'm guessing he's refering to the go
> compiler's LICENSE.
>
> // Copyright 2010 The Go Authors. All rights reserved.
> // Use of this source code is governed by a BSD-style
> // license that can be found in the LICENSE file.

Umm, did he comment somewhere?

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #5 from Lokesh Mandvekar  ---
%changelog
* Tue Oct 08 2013 Lokesh Mandvekar  0-0.3.hg74691fb6f837
- golang license for 2012 installed

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.3.h...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Matthew Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #6 from Matthew Miller  ---
upstream request for license file
http://code.google.com/p/gosqlite/issues/detail?id=21

(It's okay to add our own in the meantime.)

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #7 from Matthew Miller  ---
If you could add the following to the description (from the source code
comments),

This package has no exported API. It registers a driver for the standard Go
database/sql package.

I think that would be good.

These really all should stay as noarch packages. The exclusivearch hack isn't a
good solution to the PPC problem -- making the no-arch packages arch-specific
is actually a worse issue, I think.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #8 from Matthew Miller  ---
It's possible that adding "noarch" to the ExclusiveArch list will make that
work -- I've seen a couple of suggestions for doing that. Seems kind of ugly
but is the best I can think of right now.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #9 from Vincent Batts  ---
(In reply to Lokesh Mandvekar from comment #4)
> (In reply to Vincent Batts from comment #2)
> > This is consistent. Russ Cox's (a core golang developer) comment refers to a
> > LICENSE file that is not there. I'm guessing he's refering to the go
> > compiler's LICENSE.
> >
> > // Copyright 2010 The Go Authors. All rights reserved.
> > // Use of this source code is governed by a BSD-style
> > // license that can be found in the LICENSE file.
>
> Umm, did he comment somewhere?

This comment is from the *.go source code of this project.
https://code.google.com/p/gosqlite/source/browse/sqlite/sqlite.go#1

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #10 from Lokesh Mandvekar  ---
%changelog
* Tue Oct 08 2013 Lokesh Mandvekar  0-0.4.hg74691fb6f837
- description update
- added noarch to exclusivearch list

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.3.h...
reply to Vincent Batts from comment #9)
> (In reply to Lokesh Mandvekar from comment #4)
> This comment is from the *.go source code of this project.
> https://code.google.com/p/gosqlite/source/browse/sqlite/sqlite.go#1

silly me :|

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #11 from Lokesh Mandvekar  ---
%changelog
* Tue Oct 08 2013 Lokesh Mandvekar  0-0.5.hg74691fb6f837
- buildarch: noarch

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.5.h...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #12 from Lokesh Mandvekar  ---
%changelog
* Tue Oct 08 2013 Lokesh Mandvekar  0-0.6.hg74691fb6f837
- sql -> SQL, rpmlint warning fixed

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.5.h...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #13 from Lokesh Mandvekar  ---
Ignore Comment 12 (wrong srpm link)

%changelog
* Tue Oct 08 2013 Lokesh Mandvekar  0-0.6.hg74691fb6f837
- sql -> SQL, rpmlint warning fixed

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.6.h...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #14 from Lokesh Mandvekar  ---
also, koji looks good for dist-6E-epel

http://koji.fedoraproject.org/koji/taskinfo?taskID=6036895

only rpmlint warning for spec and srpm: setup-not-quiet

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #15 from Matthew Miller  ---
I like not-quiet setup. :)

Except for getting the exclusivearch/noarch quirk fixed, I think this is ready
to go. See https://fedorahosted.org/fpc/ticket/355

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #16 from Matthew Miller  ---
As noted in IRC, the devel subpackage should have "Requires: sqlite-devel".

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #17 from Lokesh Mandvekar  ---
%changelog
* Tue Oct 08 2013 Lokesh Mandvekar  0-0.7.hg74691fb6f837
- noarch for f19+ and rhel7+, exclusivearch otherwise
- requires sqlite-devel

Spec URL:
http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec
SRPM URL:
http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.7.h...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Matthew Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #18 from Matthew Miller  ---
Review passed with same caveat as before: go lang guidelines are draft so we
may need to update this to match as those are made official.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs+

--- Comment #19 from Lokesh Mandvekar  ---
New Package SCM Request
=======================
Package Name: golang-googlecode-sqlite
Short Description: Trivial sqlite3 binding for Go
Owners: lsm5
Branches: f19 f20 el6
InitialCC:

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs+                 |fedora-cvs?

--- Comment #20 from Lokesh Mandvekar  ---
woops ... set the wrong fedora-cvs+ flag ...corrected to fedora-cvs?

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #21 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #22 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc20 has been submitted as an
update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg746...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #23 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc19 has been submitted as an
update for Fedora 19.
https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg746...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #24 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.el6 has been submitted as an
update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg746...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #25 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc20 has been pushed to the
Fedora 20 testing repository.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Lokesh Mandvekar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2013-10-16 00:08:43

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #26 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc20 has been submitted as an
update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg746...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #27 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc19 has been submitted as an
update for Fedora 19.
https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg746...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #28 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6 has been submitted as an
update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg746...

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ON_QA
         Resolution|RAWHIDE                     |---
           Keywords|                            |Reopened

--- Comment #29 from Fedora Update System  ---
Package golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11862/golang-google...
then log in and leave karma (feedback).

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|fedora-cvs+                 |fedora-cvs?

--- Comment #30 from Peter Lemenkov  ---
Package Change Request
======================
Package Name: golang-googlecode-sqlite
InitialCC: golang-sig

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

--- Comment #31 from Jon Ciesla  ---
Done.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |golang-googlecode-sqlite-0-
                   |                            |0.8.hg74691fb6f837.fc19
         Resolution|---                         |ERRATA
        Last Closed|2013-10-16 00:08:43         |2013-10-28 23:35:07

--- Comment #32 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc19 has been pushed to the
Fedora 19 stable repository.  If problems still persist, please make note of it
in this bug report.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|golang-googlecode-sqlite-0- |golang-googlecode-sqlite-0-
                   |0.8.hg74691fb6f837.fc19     |0.8.hg74691fb6f837.el6

--- Comment #33 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6 has been pushed to the Fedora
EPEL 6 stable repository.  If problems still persist, please make note of it in
this bug report.

[Bug 1015857] Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1015857

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|golang-googlecode-sqlite-0- |golang-googlecode-sqlite-0-
                   |0.8.hg74691fb6f837.el6      |0.8.hg74691fb6f837.fc20

--- Comment #34 from Fedora Update System  ---
golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc20 has been pushed to the
Fedora 20 stable repository.  If problems still persist, please make note of it
in this bug report.