https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Bug ID: 1015857 Summary: Review Request: golang-googlecode-sqlite - Trivial sqlite3 binding for Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lsm5@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.1.h...
Description: Trivial sqlite3 binding for Go
Fedora Account System Username: lsm5
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6028690
Note: Pretty much the same as Bug 1009967, just that it didn't come with a license file included so I installed the BSD license by myself.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1000662 Assignee|nobody@fedoraproject.org |mattdm@redhat.com
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1000662 [Bug 1000662] Review Request: docker-io - Automates deployment of containerized applications
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #1 from Lokesh Mandvekar lsm5@redhat.com --- btw, docker 0.7-staging branch seems to use this package, that's why the review request
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #2 from Vincent Batts vbatts@redhat.com ---
Note: Pretty much the same as Bug 1009967, just that it didn't come with a license file included so I installed the BSD license by myself.
This is consistent. Russ Cox's (a core golang developer) comment refers to a LICENSE file that is not there. I'm guessing he's refering to the go compiler's LICENSE.
// Copyright 2010 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #3 from Lokesh Mandvekar lsm5@redhat.com --- %changelog * Tue Oct 08 2013 Lokesh Mandvekar lsm5@redhat.com 0-0.2.hg74691fb6f837 - exclusivearch as per golang - debug_package nil
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.1.h...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #4 from Lokesh Mandvekar lsm5@redhat.com --- (In reply to Vincent Batts from comment #2)
This is consistent. Russ Cox's (a core golang developer) comment refers to a LICENSE file that is not there. I'm guessing he's refering to the go compiler's LICENSE.
// Copyright 2010 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file.
Umm, did he comment somewhere?
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #5 from Lokesh Mandvekar lsm5@redhat.com --- %changelog * Tue Oct 08 2013 Lokesh Mandvekar lsm5@redhat.com 0-0.3.hg74691fb6f837 - golang license for 2012 installed
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.3.h...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Matthew Miller mattdm@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #6 from Matthew Miller mattdm@redhat.com --- upstream request for license file http://code.google.com/p/gosqlite/issues/detail?id=21
(It's okay to add our own in the meantime.)
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #7 from Matthew Miller mattdm@redhat.com --- If you could add the following to the description (from the source code comments),
This package has no exported API. It registers a driver for the standard Go database/sql package.
I think that would be good.
These really all should stay as noarch packages. The exclusivearch hack isn't a good solution to the PPC problem -- making the no-arch packages arch-specific is actually a worse issue, I think.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #8 from Matthew Miller mattdm@redhat.com --- It's possible that adding "noarch" to the ExclusiveArch list will make that work -- I've seen a couple of suggestions for doing that. Seems kind of ugly but is the best I can think of right now.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #9 from Vincent Batts vbatts@redhat.com --- (In reply to Lokesh Mandvekar from comment #4)
(In reply to Vincent Batts from comment #2)
This is consistent. Russ Cox's (a core golang developer) comment refers to a LICENSE file that is not there. I'm guessing he's refering to the go compiler's LICENSE.
// Copyright 2010 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file.
Umm, did he comment somewhere?
This comment is from the *.go source code of this project. https://code.google.com/p/gosqlite/source/browse/sqlite/sqlite.go#1
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #10 from Lokesh Mandvekar lsm5@redhat.com --- %changelog * Tue Oct 08 2013 Lokesh Mandvekar lsm5@redhat.com 0-0.4.hg74691fb6f837 - description update - added noarch to exclusivearch list
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.3.h... reply to Vincent Batts from comment #9)
(In reply to Lokesh Mandvekar from comment #4) This comment is from the *.go source code of this project. https://code.google.com/p/gosqlite/source/browse/sqlite/sqlite.go#1
silly me :|
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #11 from Lokesh Mandvekar lsm5@redhat.com --- %changelog * Tue Oct 08 2013 Lokesh Mandvekar lsm5@redhat.com 0-0.5.hg74691fb6f837 - buildarch: noarch
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.5.h...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #12 from Lokesh Mandvekar lsm5@redhat.com --- %changelog * Tue Oct 08 2013 Lokesh Mandvekar lsm5@redhat.com 0-0.6.hg74691fb6f837 - sql -> SQL, rpmlint warning fixed
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.5.h...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #13 from Lokesh Mandvekar lsm5@redhat.com --- Ignore Comment 12 (wrong srpm link)
%changelog * Tue Oct 08 2013 Lokesh Mandvekar lsm5@redhat.com 0-0.6.hg74691fb6f837 - sql -> SQL, rpmlint warning fixed
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.6.h...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #14 from Lokesh Mandvekar lsm5@redhat.com --- also, koji looks good for dist-6E-epel
http://koji.fedoraproject.org/koji/taskinfo?taskID=6036895
only rpmlint warning for spec and srpm: setup-not-quiet
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #15 from Matthew Miller mattdm@redhat.com --- I like not-quiet setup. :)
Except for getting the exclusivearch/noarch quirk fixed, I think this is ready to go. See https://fedorahosted.org/fpc/ticket/355
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #16 from Matthew Miller mattdm@redhat.com --- As noted in IRC, the devel subpackage should have "Requires: sqlite-devel".
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #17 from Lokesh Mandvekar lsm5@redhat.com --- %changelog * Tue Oct 08 2013 Lokesh Mandvekar lsm5@redhat.com 0-0.7.hg74691fb6f837 - noarch for f19+ and rhel7+, exclusivearch otherwise - requires sqlite-devel
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-sqlite.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-sqlite-0-0.7.h...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Matthew Miller mattdm@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #18 from Matthew Miller mattdm@redhat.com --- Review passed with same caveat as before: go lang guidelines are draft so we may need to update this to match as those are made official.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs+
--- Comment #19 from Lokesh Mandvekar lsm5@redhat.com --- New Package SCM Request ======================= Package Name: golang-googlecode-sqlite Short Description: Trivial sqlite3 binding for Go Owners: lsm5 Branches: f19 f20 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #20 from Lokesh Mandvekar lsm5@redhat.com --- woops ... set the wrong fedora-cvs+ flag ...corrected to fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #21 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg746...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg746...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.7.hg74691fb6f837.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.7.hg746...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.7.hg74691fb6f837.fc20 has been pushed to the Fedora 20 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2013-10-16 00:08:43
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg746...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg746...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-sqlite-0-0.8.hg746...
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- Package golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11862/golang-google... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lemenkov@gmail.com Flags|fedora-cvs+ |fedora-cvs?
--- Comment #30 from Peter Lemenkov lemenkov@gmail.com --- Package Change Request ====================== Package Name: golang-googlecode-sqlite InitialCC: golang-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
--- Comment #31 from Jon Ciesla limburgher@gmail.com --- Done.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |golang-googlecode-sqlite-0- | |0.8.hg74691fb6f837.fc19 Resolution|--- |ERRATA Last Closed|2013-10-16 00:08:43 |2013-10-28 23:35:07
--- Comment #32 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-googlecode-sqlite-0- |golang-googlecode-sqlite-0- |0.8.hg74691fb6f837.fc19 |0.8.hg74691fb6f837.el6
--- Comment #33 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.8.hg74691fb6f837.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1015857
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-googlecode-sqlite-0- |golang-googlecode-sqlite-0- |0.8.hg74691fb6f837.el6 |0.8.hg74691fb6f837.fc20
--- Comment #34 from Fedora Update System updates@fedoraproject.org --- golang-googlecode-sqlite-0-0.8.hg74691fb6f837.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org