Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243501
Summary: Review Request: qtiplot-doc - Documentation of qtiplot Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: frank-buettner@gmx.net QAContact: fedora-package-review@redhat.com
Spec URL: http://downloads.sourceforge.net/qsmartcard/qtiplot-doc.spec?use_mirror=osdn SRPM URL: http://downloads.sourceforge.net/qsmartcard/qtiplot-doc-0.9_rc1-1.fc6.src.rp... Description: The documentation of the application.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243501
frank-buettner@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |240373
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243501
frank-buettner@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|240373 |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243501
frank-buettner@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |240373 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |opensource@till.name Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From opensource@till.name 2007-09-08 10:43 EST ------- License should be GFDL according to http://fedoraproject.org/wiki/Licensing#head-19fc3ef10add085a28cb06784dc34ef... and index.html
You use tabs and spaces in the spec, e.g. in Group you align with spaces but in URL you align with tabs. Please use either tabs or spaces.
I did not try it but I guess you can simplify the spec when you use in %prep %setup -q -n manual-en dos2unix qtiplot.adp
and in %files %doc *
Then you can remove mkdir -p $RPM_BUILD_ROOT/%{_docdir}/%{name} tar -xjf %{SOURCE0} -C $RPM_BUILD_ROOT/%{_docdir}/%{name} dos2unix $RPM_BUILD_ROOT/%{_docdir}/%{name}/manual-en/qtiplot.adp from %install.
In %files a %defattr(-,root,root,-) before the %doc is missing.
According to http://soft.proindependent.com/manuals.html the documentation is version 0.8.9
Imho you should skip the %{?dist} tag in Release and ask rel-eng everytime you built a package to sync it to all Fedora releases, this will also avoid updating the manual everytime one updrades the system.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
------- Additional Comments From opensource@till.name 2007-09-08 10:47 EST ------- I forgot: run dos2unix with --keepdate
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
------- Additional Comments From frank-buettner@gmx.net 2007-09-08 12:24 EST ------- The simple setup will not work.:( So I must use complex one. So here the next try.(I have correct the version number of the doc) SRPM: http://downloads.sourceforge.net/qsmartcard/qtiplot-doc-0.8.9-1.fc8.src.rpm?... SPEC: http://downloads.sourceforge.net/qsmartcard/qtiplot-doc.spec?use_mirror=osdn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
------- Additional Comments From frank-buettner@gmx.net 2007-09-30 05:53 EST ------- The new spec file: http://downloads.sourceforge.net/qsmartcard/qtiplot-doc.spec?use_mirror=osdn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|240373 | nThis| | BugsThisDependsOn| |240373
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
Bug 243501 depends on bug 240373, which changed state.
Bug 240373 Summary: Review Request: qtiplot - Data Analysis and Scientific Plotting https://bugzilla.redhat.com/show_bug.cgi?id=240373
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Status|NEEDINFO |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qtiplot-doc - Documentation of qtiplot
https://bugzilla.redhat.com/show_bug.cgi?id=243501
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
------- Additional Comments From opensource@till.name 2008-06-09 17:34 EST ------- I just realized, that I totally neglected this review request. I noticed however, that there is now a new release of the manual. I just tried the new version, the Sources needs to be adjusted and the dos2unix invokation does not work. The upstream tarball contains .svn directories, which creates a huge rpmlint warning. Imho they should be removed.
Also the specfile contains both space and tabs, only after the Buildroot and the Group tag are spaces, after the other tags are tabs. I would only use spaces, but you need to choose one method to align the tags.
If you still want to get this package in, please reply with a new spec and I will try very hard to complete this review soon after your reply.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=243501
Rakesh Pandit rakesh.pandit@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(frank-buettner@gm | |x.net)
--- Comment #6 from Rakesh Pandit rakesh.pandit@gmail.com 2008-09-03 11:01:09 EDT --- @Frank Any updates in here? This request will be closed with in a week if no updates are provided.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=243501
Till Maas opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED CC| |opensource@till.name Blocks| |201449 Resolution| |NOTABUG AssignedTo|opensource@till.name |nobody@fedoraproject.org Flag|fedora-review?, | |needinfo?(frank-buettner@gm | |x.net) |
--- Comment #7 from Till Maas opensource@till.name 2008-11-07 06:44:00 EDT --- There was no response for a while and iirc I read somewhere that the submitter is currently very busy.
Therefore I close this for now, feel free to reopen this once you want to finish it.
package-review@lists.fedoraproject.org