[Bug 1622127] New: Review Request: zram-generator - Systemd unit generator for zram devices
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
Bug ID: 1622127 Summary: Review Request: zram-generator - Systemd unit generator for zram devices Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zbyszek@in.waw.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-zram-generator.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-zram-generator-0.1.0-1.fc30.src.rpm Fedora Account System Username: zbyszek Description: This is a systemd unit generator that creates a unit file to create a zram device on systems that have <2GB memory.
Upstream repo: https://github.com/systemd/zram-generator
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Both the URL and Source0 are 404s. zram-generator is not published on crates.io. And there is no release on Github which means you need to specify how you generated the crate and fix Source0.
- Install zram-generator.conf.example as %doc or install a copy as /etc/systemd/zram-generator.conf
- Install README.md as %doc.
- As upstream, you should include a file for the MIT license.
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Thanks for the quick review.
I pushed a 0.1.1 tag to github, and published the crate on crates.io. All requested change are implemented.
Spec URL: https://in.waw.pl/~zbyszek/fedora/rust-zram-generator.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/rust-zram-generator-0.1.1-1.fc30.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Looks good, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/zram-generator
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Oops, I screwed up here. The spec file is named correctly, but the review request and my repo request were missing "rust-". I'll re-request the repo. Sorry for the trouble.
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |zram-generator - Systemd |rust-zram-generator - |unit generator for zram |Systemd unit generator for |devices |zram devices
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zram-generator
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- rust-zram-generator-0.1.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-999c047709
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- rust-zram-generator-0.1.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-999c047709
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- rust-zram-generator-0.1.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-999c047709
https://bugzilla.redhat.com/show_bug.cgi?id=1622127
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-09-21 01:22:12
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- rust-zram-generator-0.1.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com