[Bug 230585] New: Review Request: xdg-user-dirs - Handling of well known folders in homedir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230585

Summary: Review Request: xdg-user-dirs - Handling of well known
                    folders in homedir
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://people.redhat.com/alexl/temp/xdg-user-dirs.spec
SRPM URL: http://people.redhat.com/alexl/temp/xdg-user-dirs-0.3-1.fc7.src.rpm
Description: 
Contains xdg-user-dirs-update that updates folders in a users
homedirectory based on the defaults configured by the administrator.

See http://freedesktop.org/wiki/Software_2fxdg_2duser_2ddirs for more info

[Bug 230585] Review Request: xdg-user-dirs - Handling of well known folders in homedir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdg-user-dirs - Handling of well known folders in homedir

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230585

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2007-03-01 14:03 EST -------
- rpmlint is silent both on source and binary rpm
- package meets naming guidelines
- package meets packaging guidelines 
- license (GPL ) is OK, matches source 
- spec file legible, in am. english
- source matches upstream,is latest available version, sha1sum
ddb6299faae1e23da524b113eb5d7a27c734630a  xdg-user-dirs-0.3.tar.gz
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales properly handled via find_lang
- not relocatable
- owns all files/directories that it creates, does not take ownership of foreign
files/directories
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- no scriptlets
- no static, .la or .pc files

SHOULD
- package builds in mock/devel/x86_64
- works as advertised

TODO 
- I suggest including the Changelog (including the one for translations)
- I think that it would be a good idea to use "-p" when installing %Source1, in
order to preserve the timestamp
- MUSTFIX: include the license file, it exists in the tar.gz but is not included
in %doc

Package is APPROVED but please add the license before uploading to CVS

[Bug 230585] Review Request: xdg-user-dirs - Handling of well known folders in homedir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdg-user-dirs - Handling of well known folders in homedir

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230585

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-03-02 02:47 EST -------
New Package CVS Request
=======================
Package Name: xdg-user-dirs
Short Description: Handling of user well-known folders
Owners: [e-mail]
Branches: devel
InitialCC:

[Bug 230585] Review Request: xdg-user-dirs - Handling of well known folders in homedir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdg-user-dirs - Handling of well known folders in homedir

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230585

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-03-02 08:06 EST -------
CVS done

[Bug 230585] Review Request: xdg-user-dirs - Handling of well known folders in homedir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdg-user-dirs - Handling of well known folders in homedir

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230585

------- Additional Comments From [e-mail]  2007-03-06 04:33 EST -------
Alex, the package has been successfuly built, could you please close this ticket ?

[Bug 230585] Review Request: xdg-user-dirs - Handling of well known folders in homedir

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xdg-user-dirs - Handling of well known folders in homedir

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230585

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE