https://bugzilla.redhat.com/show_bug.cgi?id=2075207
Bug ID: 2075207 Summary: Review Request: rust-wasmtime-jit-debug - JIT debug interfaces support for Wasmtime Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-wasmtime-jit-debug.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-wasmtime-jit-debug-0.35.3-1.fc36.sr...
Description: JIT debug interfaces support for Wasmtime.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=85629809
https://bugzilla.redhat.com/show_bug.cgi?id=2075207
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |michel@michel-slm.name Status|NEW |ASSIGNED Flags| |fedora-review? CC| |michel@michel-slm.name Doc Type|--- |If docs needed, set a value
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- Taking this review
https://bugzilla.redhat.com/show_bug.cgi?id=2075207
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- Note: depends on the rustix update, which depends on linux-raw-sys and io-lifetimes, make sure to push them together once they are ready
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
one question - rust2rpm does automatically generate the comment that this is ASL with LLVM exception, but... is there a better thing we can put in the license field?
https://bugzilla.redhat.com/show_bug.cgi?id=2075207
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review! Yeah, I'm building all these packages in side tags right now, they will be submitted together.
rust2rpm does automatically generate the comment that this is ASL with LLVM exception
This is a known problem ... Fedora Legal determined that "Apache-2.0 WITH LLVM-Exception" is functionally equivalent to "Apache-2.0" for our purposes. rust2rpm however can't easily map this to just "ASL 2.0" because the SPDX parser apparently doesn't support doing that. Reported as an issue to rust2rpm here: https://pagure.io/fedora-rust/rust2rpm/issue/163
https://pagure.io/releng/fedora-scm-requests/issue/43720 https://pagure.io/releng/fedora-scm-requests/issue/43721 https://pagure.io/releng/fedora-scm-requests/issue/43722 https://pagure.io/releng/fedora-scm-requests/issue/43723
https://bugzilla.redhat.com/show_bug.cgi?id=2075207
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wasmtime-jit-debug
https://bugzilla.redhat.com/show_bug.cgi?id=2075207
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|POST |CLOSED Last Closed| |2022-04-15 16:15:58
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Built and submitted for rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2022-31e5d41c38
package-review@lists.fedoraproject.org