[Bug 847389] New: Review Request: python-supernova - wrapper for python-novaclient to access multiple OpenStack nova environments
https://bugzilla.redhat.com/show_bug.cgi?id=847389
Bug ID: 847389 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: python-supernova - wrapper for python-novaclient to access multiple OpenStack nova environments Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: major@mhtx.net Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://majorhayden.com/RPMS/python-supernova/python-supernova.spec SRPM URL: http://majorhayden.com/RPMS/python-supernova/python-supernova-0.7.4-1.fc17.s... Description: This is a wrapper for python-novaclient which allows users to specify OpenStack nova environment credentials in a simple configuration file while also allowing users to store sensitive credentials in a keyring via python-keyring. Fedora Account System Username: mhayden
https://bugzilla.redhat.com/show_bug.cgi?id=847389
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #1 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4513652
The build fails because of a missing python-keyring in BuildRequires. From build-log:
+ /usr/bin/python setup.py build Traceback (most recent call last): File "setup.py", line 18, in <module> from supernova import supernova File "/builddir/build/BUILD/supernova/supernova/supernova.py", line 18, in <module> import keyring ImportError: No module named keyring
Probably you can drop python-keyring from Requires then, usually rpm should pick up this dependency automatically.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
--- Comment #2 from Mario Blättermann mario.blaettermann@gmail.com --- Any news here...?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
--- Comment #3 from Major Hayden major@mhtx.net --- Sorry Mario - I missed your last update. I'll try to get this wrapped up this week.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
--- Comment #4 from Major Hayden major@mhtx.net --- Updated: http://majorhayden.com/RPMS/python-supernova/python-supernova-0.7.5-1.fc17.s...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mario.blaettermann@gmail.co | |m Flags| |fedora-review?
--- Comment #5 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4694118
$ rpmlint -i -v * python-supernova.src: I: checking python-supernova.src: W: spelling-error Summary(en_US) novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.src: W: spelling-error %description -l en_US novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.src: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring The value of this tag appears to be misspelled. Please double-check.
python-supernova.src: I: checking-url http://github.com/rackerhacker/supernova (timeout 10 seconds) python-supernova.src:19: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
python-supernova.src: W: invalid-url Source0: supernova-0.7.5.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL.
python-supernova.noarch: I: checking python-supernova.noarch: W: spelling-error Summary(en_US) novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.noarch: W: spelling-error %description -l en_US novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.noarch: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring The value of this tag appears to be misspelled. Please double-check.
python-supernova.noarch: I: checking-url http://github.com/rackerhacker/supernova (timeout 10 seconds) python-supernova.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
python-supernova.noarch: W: no-manual-page-for-binary supernova Each executable in standard binary directories should have a man page.
python-supernova.noarch: W: no-manual-page-for-binary supernova-keyring Each executable in standard binary directories should have a man page.
python-supernova.spec:19: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
python-supernova.spec: W: invalid-url Source0: supernova-0.7.5.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL.
2 packages and 1 specfiles checked; 0 errors, 13 warnings.
Some false positive spelling errors. Moreover, an invalid source file which can also be ignored in this case.
There remains still one issue: Please use either tabs or spaces in the spec file. I recommend the latter, because this way your spec looks the same in all text editors regardless of the configured tab width.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
--- Comment #6 from Major Hayden major@mhtx.net --- Good catch. I missed that line in the rpmlint output about tabs/spaces.
http://majorhayden.com/RPMS/python-supernova/python-supernova-0.7.5-2.fc17.s...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
--- Comment #7 from Mario Blättermann mario.blaettermann@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4721916
$ rpmlint -i -v * python-supernova.src: I: checking python-supernova.src: W: spelling-error Summary(en_US) novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.src: W: spelling-error %description -l en_US novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.src: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring The value of this tag appears to be misspelled. Please double-check.
python-supernova.src: I: checking-url http://github.com/rackerhacker/supernova (timeout 10 seconds) python-supernova.src: W: invalid-url Source0: supernova-0.7.5.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL.
python-supernova.noarch: I: checking python-supernova.noarch: W: spelling-error Summary(en_US) novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.noarch: W: spelling-error %description -l en_US novaclient -> nova client, nova-client, clientele The value of this tag appears to be misspelled. Please double-check.
python-supernova.noarch: W: spelling-error %description -l en_US keyring -> keying, key ring, key-ring The value of this tag appears to be misspelled. Please double-check.
python-supernova.noarch: I: checking-url http://github.com/rackerhacker/supernova (timeout 10 seconds) python-supernova.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
python-supernova.noarch: W: no-manual-page-for-binary supernova Each executable in standard binary directories should have a man page.
python-supernova.noarch: W: no-manual-page-for-binary supernova-keyring Each executable in standard binary directories should have a man page.
python-supernova.spec: W: invalid-url Source0: supernova-0.7.5.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL.
2 packages and 1 specfiles checked; 0 errors, 11 warnings.
OK so far.
$ sha256sum * e226f56a7d12ebba9c459fad62f05d5e3f03ae24827aaf2c1f5af8ecd585281d supernova-0.7.5.tar.gz a08a641f617c8411ab9e0f7794c93a49cd5fe2efa9b638f9a834c75510679dc6 supernova-0.7.5.tar.gz.orig
The checksums differ, which is a usual problem for Git checkouts. No matter, but for future packages, you should use the following command for download, which delivers an unique checksum:
wget --content-disposition https://github.com/rackerhacker/supernova/tarball/c6b6b5a8e9
This is an example for the current Git state. Similar commands can be used for all Github stuff. BTW, there's a Git tag missing from your download command, so it fetches always the latest content.
Moreover, I'm missing %doc. There should be at least README.md as a minimal documentation.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
--- Comment #8 from Mario Blättermann mario.blaettermann@gmail.com --- Ping...?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC|mario.blaettermann@gmail.co | |m | Assignee|mario.blaettermann@gmail.co |nobody@fedoraproject.org |m | Flags|fedora-review? |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847389
Major Hayden major@mhtx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2013-03-08 07:57:00
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla