[Bug 1350260] New: Review Request: cmap-resources - CMap Resources for Adobe's public character collections
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
Bug ID: 1350260 Summary: Review Request: cmap-resources - CMap Resources for Adobe's public character collections Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rosser.bjr@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
NOTE: this is a re-review for the cmap resources packages:
* cmap-japan1-6 * cmap-korean1-2 * cmap-identity0 * cmap-gb1-5 * cmap-cns1-6
I'm submitting a re-review because (as of last December) upstream no longer distributes separate tarballs for each; instead, the files are just stored in a github repository (https://github.com/adobe-type-tools/cmap-resources/). Therefore, it no longer makes sense to have a standalone source package per resource.
Instead, I have repackaged the cmap resources as a series of subpackages (cmap-resources-cns1-6, etc.) that provide cmap-cns1-6, etc. Note that -korean1-2 and -identity0 were renamed upstream to -korea1-2 and -identity-0 for consistency; I thus provide both cmap-korean1-2 and cmap-korea1-2.
A cmap-resources-japan2-0 containing the deprecated japan2-0 resources is now also included.
The resources are installed into /usr/share/cmap/, as before. While my previous packages installed into /usr/share/cmap/cmap-cns1-6-%{version}, I've decided providing an unversioned installation directory (/usr/share/cmap/cmap-cns1-6) is probably more valuable, but I've mantained versioned symlinks (so the packages ship %{_datadir}/cmap-cns1-6-%{version} as a symlink to %{_datadir}/cmap-cns1-6). Thus, these new packages should be a drop in replacement for the old cmap resources.
Spec URL: https://tc01.fedorapeople.org/cmap/cmap-resources.spec SRPM URL: https://tc01.fedorapeople.org/cmap/cmap-resources-2015.12.05-1.fc23.src.rpm Description: CMap (Character Map) resources are used to unidirectionally map character codes, such as a Unicode encoding form, to CIDs (Characters IDs, meaning glyphs) of a CIDFont resource.
Fedora Account System Username: tc01
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |dominik@greysector.net Flags| |fedora-review?
--- Comment #1 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Taking review.
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Sorry for the delay.
Two things:
Change Source0: to: https://github.com/adobe-type-tools/cmap-resources/archive/%%7Bcommit%7D.zip...
Consider moving the license, docs and /usr/share/cmap ownership to cmap-resources main package and have all subpackages require it instead of duplicating the license and all txt files in the subpackages.
Other than that, it looks fine. You can correct the above upon import.
Package APPROVED.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: unzip See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/cmap(cmap-cns1-6, cmap-korean1-2, cmap-gb1-5, cmap-identity0, cmap-japan1-6) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 12 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. 5d7d69740e679206efba680d40753a7451eb5ba7b3b0d681c40be968d06ffa69 cmap-resources-0561ebca035813ed04c3485bca636a0aa7abdc1d.zip
[x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: cmap-resources-cns1-6-2015.12.05-1.fc26.noarch.rpm cmap-resources-gb1-5-2015.12.05-1.fc26.noarch.rpm cmap-resources-japan2-0-2015.12.05-1.fc26.noarch.rpm cmap-resources-japan1-6-2015.12.05-1.fc26.noarch.rpm cmap-resources-korea1-2-2015.12.05-1.fc26.noarch.rpm cmap-resources-identity-0-2015.12.05-1.fc26.noarch.rpm cmap-resources-2015.12.05-1.fc26.src.rpm cmap-resources-cns1-6.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-cns1-6.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-gb1-5.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-gb1-5.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-japan2-0.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-japan2-0.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-japan1-6.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-japan1-6.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-korea1-2.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-korea1-2.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-identity-0.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-identity-0.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources.src: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources.src: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources.src:10: W: macro-in-comment %{commit} cmap-resources.src:11: W: macro-in-comment %{commit} cmap-resources.src: W: invalid-url Source0: cmap-resources-0561ebca035813ed04c3485bca636a0aa7abdc1d.zip 7 packages and 0 specfiles checked; 0 errors, 17 warnings.
Rpmlint (installed packages) ---------------------------- cmap-resources-gb1-5.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-gb1-5.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-japan2-0.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-japan2-0.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-identity-0.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-identity-0.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-japan1-6.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-japan1-6.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-korea1-2.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-korea1-2.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s cmap-resources-cns1-6.noarch: W: spelling-error %description -l en_US unidirectionally -> unidirectional, bidirectionally, bidirectional cmap-resources-cns1-6.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s 6 packages and 0 specfiles checked; 0 errors, 12 warnings.
Requires -------- cmap-resources-gb1-5 (rpmlib, GLIBC filtered):
cmap-resources-japan2-0 (rpmlib, GLIBC filtered):
cmap-resources-identity-0 (rpmlib, GLIBC filtered):
cmap-resources-japan1-6 (rpmlib, GLIBC filtered):
cmap-resources-korea1-2 (rpmlib, GLIBC filtered):
cmap-resources-cns1-6 (rpmlib, GLIBC filtered):
Provides -------- cmap-resources-gb1-5: cmap-gb1-5 cmap-resources-gb1-5
cmap-resources-japan2-0: cmap-japan2-0 cmap-resources-japan2-0
cmap-resources-identity-0: cmap-identity-0 cmap-identity0 cmap-resources-identity-0
cmap-resources-japan1-6: cmap-japan1-6 cmap-resources-japan1-6
cmap-resources-korea1-2: cmap-korea1-2 cmap-korean1-2 cmap-resources-korea1-2
cmap-resources-cns1-6: cmap-cns1-6 cmap-resources-cns1-6
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1350260 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/cmap-resources
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #4 from Ben Rosser rosser.bjr@gmail.com --- Awesome, thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dfec1e7435
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6020e3145
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e32728be1
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-085ef35ab8
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dfec1e7435
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-085ef35ab8
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e32728be1
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c6020e3145
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-08-27 06:19:07
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1350260
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- cmap-resources-2015.12.05-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla