https://bugzilla.redhat.com/show_bug.cgi?id=1873302
Bug ID: 1873302 Summary: Review Request: IP2Location - IP2location library Product: Fedora Version: rawhide Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: pb@bieringer.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/chrislim2888/IP2Location-C-Library/master/...
SRPM URL: ftp://ftp.bieringer.de/pub/linux/IP2Location/IP2Location-8.0.9-5.fc34.src.rpm
Description : IP2Location C library enables the user to get the country, region, city, coordinates, ZIP code, time zone, ISP, domain name, connection type, area code, weather info, mobile carrier, elevation and usage type from any IP address or hostname. This library has been optimized for speed and memory utilization. The library contains API to query all IP2Location LITE and commercial binary databases.
Users can download the latest LITE database from IP2Location web site using e.g. the included downloader.
Prebuilds fine on fc32/fc34/el8
Fedora Account System Username: pbiering
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
Peter Bieringer pb@bieringer.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |guru2018@gmail.com
--- Comment #1 from Peter Bieringer pb@bieringer.de --- *** Bug 1081434 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Use a better name for your archive:
Source0: https://github.com/chrislim2888/IP2Location-C-Library/archive/%%7Bversion%7D...
→
Source0: https://github.com/chrislim2888/IP2Location-C-Library/archive/%%7Bversion%7D...
- Not needed:
Group: System Environment/Libraries
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Group: Development/C
rm -rf %{buildroot}
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
%clean rm -rf %{buildroot}
%defattr(644,root,root,755)
%defattr(-,root,root)
%attr(755,-,-)
- autoreconf -fi → autoreconf -fiv
- make %{?_smp_mflags} → make_build
- make clean shouldn't be needed
- make install DESTDIR=%{buildroot} → make_install
- Be more specific:
%{_includedir}/*
- Licenses must be installed with %license in %files and INSTALL shouldn't be provided
%doc AUTHORS ChangeLog README.md NEWS %license COPYING LICENSE.TXT
- In order to avoid unintentional soname bump, we recommend not globbing the major soname version, be more specific instead:
%{_libdir}/*.so*
- Own %{_datadir}/%{name}/tools/ by removing the glob
%{_datadir}/%{name}/tools/
- don't use cp but install -p:
cp tools/download.pl %{buildroot}%{_datadir}/%{name}/tools
→
install -pm 0755 tools/download.pl %{buildroot}%{_datadir}/%{name}/tools
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #3 from Peter Bieringer pb@bieringer.de --- Thank you for reviewing, hopefully all changes applied, please check:
https://raw.githubusercontent.com/pbiering/IP2Location-C-Library/spec-file-f...
once fine I will create PR for upstream and can use the same on the Fedora build system
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - This should be in the devel package:
%{_libdir}/libIP2Location.so
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- You have not removed these:
%defattr(644,root,root,755)
%defattr(-,root,root)
%attr(755,-,-)
If there is issues with the permissions of the libraries, chmod them in install and send a patch to fix upstream build system.
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #5 from Peter Bieringer pb@bieringer.de ---
- This should be in the devel package:
Ok, checked with GeoIP, here it is also the case -> fixed
other forgotten/overseen issues are fixed and pushed to github again
Please check again
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #6 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- LGTM, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #7 from Peter Bieringer pb@bieringer.de --- executed: fedpkg request-repo IP2Location 1873302 will now wait for approval
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #8 from Igor Raits igor.raits@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/IP2Location
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
Peter Bieringer pb@bieringer.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NOTABUG Last Closed| |2020-09-08 16:36:43
--- Comment #9 from Peter Bieringer pb@bieringer.de --- repo exists, will start working now on building packages, so this ticket can be closed...but who is interest can keep watching https://koji.fedoraproject.org/koji/packageinfo?packageID=32132
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
Peter Bieringer pb@bieringer.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |WORKSFORME
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #10 from Peter Bieringer pb@bieringer.de --- initial packages for f31...34 and el7..8 are now available, feel free to test, if any issues found, send e-mail or create a ticket: https://koji.fedoraproject.org/koji/packageinfo?packageID=32132
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #11 from Michael C mikecameroon@gmail.com --- Do we need to update the repository manually? I can only see f34 stable release.
https://src.fedoraproject.org/rpms/IP2Location
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #12 from Peter Bieringer pb@bieringer.de --- will push next to updates-testing, had to run initial tests first.
https://bugzilla.redhat.com/show_bug.cgi?id=1873302
--- Comment #13 from Peter Bieringer pb@bieringer.de --- watch this now: https://bodhi.fedoraproject.org/updates/?search=IP2Location
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com