Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=439141
Summary: Review Request: python-demjson - Python JSON module and lint checker Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: thomas.moschny@gmx.de QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://thm.fedorapeople.org/python-demjson.spec SRPM URL: http://thm.fedorapeople.org/python-demjson-1.3-1.fc8.src.rpm
Description: This module provides classes and functions for encoding or decoding data represented in the language-neutral JSON format (which is often used as a simpler substitute for XML in Ajax web applications). This implementation tries to be as compliant to the JSON specification (RFC 4627) as possible, while still providing many optional extensions to allow less restrictive JavaScript syntax. It includes complete Unicode support, including UTF-32, BOM, and surrogate pair processing. It can also support JavaScript's NaN and Infinity numeric types as well as it's 'undefined' type.
It also includes a lint-like JSON syntax validator which tests JSON text for strict compliance to the standard.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2008-03-27 07:38 EST ------- Not needed now following as per python packaging guidelines %if 0%{?fedora} >= 8 BuildRequires: python-setuptools-devel %else BuildRequires: python-setuptools %endif
But add only BuildRequires: python-setuptools-devel
also, drop INSTALL.txt from %doc
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From thomas.moschny@gmx.de 2008-03-27 08:18 EST ------- (In reply to comment #1)
Not needed now following as per python packaging guidelines %if 0%{?fedora} >= 8 BuildRequires: python-setuptools-devel %else BuildRequires: python-setuptools %endif
Isn't this necessary to successfully build for F-7?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From thomas.moschny@gmx.de 2008-03-27 19:19 EST ------- (In reply to comment #1)
Not needed now following as per python packaging guidelines
Ok, seems indeed not to be necessary anymore.
But add only BuildRequires: python-setuptools-devel
Done.
also, drop INSTALL.txt from %doc
Done.
Spec file and srpm updated.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From panemade@gmail.com 2008-03-31 02:31 EST ------- will you please post updated SRPM link ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From thomas.moschny@gmx.de 2008-03-31 03:01 EST ------- Spec URL: http://thm.fedorapeople.org/python-demjson.spec SRPM URL: http://thm.fedorapeople.org/python-demjson-1.3-2.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-04-01 00:00 EST ------- Review: + package builds in mock. Koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=539324 http://koji.fedoraproject.org/koji/taskinfo?taskID=539326 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 5989d22248cce8641c986ed189e4e601 demjson-1.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
thomas.moschny@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From thomas.moschny@gmx.de 2008-04-01 02:53 EST ------- Thanks for reviewing!
New Package CVS Request ======================= Package Name: python-demjson Short Description: Python JSON module and lint checker Owners: thm Branches: F-7 F-8 InitialCC: none Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-04-01 15:25 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From updates@fedoraproject.org 2008-04-01 17:11 EST ------- python-demjson-1.3-2.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From updates@fedoraproject.org 2008-04-01 17:14 EST ------- python-demjson-1.3-2.fc7 has been submitted as an update for Fedora 7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
------- Additional Comments From updates@fedoraproject.org 2008-04-09 01:16 EST ------- python-demjson-1.3-2.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-demjson'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-2942
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From panemade@gmail.com 2008-04-27 06:27 EST ------- is this pushed to rawhide?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From thomas.moschny@gmx.de 2008-05-03 03:30 EST ------- (In reply to comment #12)
is this pushed to rawhide?
Not sure I understand this question. Afaict there's a python-demjson package available in f9 as well as in devel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From panemade@gmail.com 2008-05-05 00:12 EST ------- ok then we can close this review as packages built successfully and are in respective repositories.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From thomas.moschny@gmx.de 2008-05-05 05:46 EST ------- Bodhi would have auto-closed this bug after moving the F-7 and F-8 packages from updates-testing to updates-stable.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From panemade@gmail.com 2008-05-05 06:01 EST ------- But then I am not sure how long to keep open this review request as review already passed and packages successfully built for all requested branches. Its almost one month I can see updates submitted as per comments #9 and #10 but not pushed to stable repository. Feel free to open this review as anyway bodhi will going to change resolution to Errata (IIRC) once updates gets pushed to stable repo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From updates@fedoraproject.org 2008-05-10 09:50 EST ------- python-demjson-1.3-2.fc7.1 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |CURRENTRELEASE Fixed In Version| |1.3-2.fc7.1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-demjson - Python JSON module and lint checker
https://bugzilla.redhat.com/show_bug.cgi?id=439141
------- Additional Comments From updates@fedoraproject.org 2008-05-10 09:53 EST ------- python-demjson-1.3-2.fc8.1 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla