[Bug 2049808] New: Review Request: awscli-2 - Universal Command Line Environment for AWS, Version 2
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Bug ID: 2049808 Summary: Review Request: awscli-2 - Universal Command Line Environment for AWS, Version 2 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: davdunc@amazon.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://davdunc.fedorapeople.org/awscli-2-rpms/awscli-2.spec SRPM URL: https://davdunc.fedorapeople.org/awscli-2-rpms/awscli-2-2.4.12-2.fc35.src.rp... Description: This package provides version 2 of the unified command line interface to Amazon Web Services. Fedora Account System Username: davdunc
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |michel@michel-slm.name Flags| |fedora-review? CC| |michel@michel-slm.name
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2049689
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2049689 [Bug 2049689] Review Request: python-awscrt - Python bindings for the AWS Common Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(davdunc@amazon.co | |m)
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- This depends on awscrt, marked it as a blocker. Meanwhile:
- why rename this to awscli-2 ? If the intention is that both are parallel installable, this should not obsolete the other. If not, then you can just call this awscli (and actually, don't need a review request) - missing %license LICENSE.txt - with auto build requirement, you only need python3-devel. Drop toml and wheel, they should be automatically picked up - drop python_provide, it's deprecated: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_deprecate... - there are tests, you probably want a %check section. If invoking %tox is too much of a work, invoking %pytest should work. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
--- Comment #2 from David Duncan davdunc@amazon.com --- (In reply to Michel Alexandre Salim from comment #1)
This depends on awscrt, marked it as a blocker. Meanwhile:
- why rename this to awscli-2 ? If the intention is that both are parallel
installable, this should not obsolete the other. If not, then you can just call this awscli (and actually, don't need a review request)
it's a separate package. We have to maintain the original awscli package because it is in RHEL and needs to stay consistent for the foreseeable future. We will need to maintain the two tracks because they function in very different ways.
- missing %license LICENSE.txt
whoops!
- with auto build requirement, you only need python3-devel. Drop toml and
wheel, they should be automatically picked up
- drop python_provide, it's deprecated:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ #_deprecated_macros
Thank you. some careless copying of old process.
- there are tests, you probably want a %check section. If invoking %tox is
too much of a work, invoking %pytest should work. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests
I think kyle can figure this out for me. Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |--- Status|CLOSED |ASSIGNED Keywords| |Reopened
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- This not stalled...
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2179888
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2179888 [Bug 2179888] Review Request: python-awscrt - Python bindings for the AWS Common Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=2049808 Bug 2049808 depends on bug 2049689, which changed state.
Bug 2049689 Summary: Review Request: python-awscrt - Python bindings for the AWS Common Runtime https://bugzilla.redhat.com/show_bug.cgi?id=2049689
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Nikola Forró nforro@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nforro@redhat.com
--- Comment #5 from Nikola Forró nforro@redhat.com --- Here are some more important issues:
Name: %{appname}-2
I don't think this is a valid name. Packaging Guidelines say about packages with the same base name [1]:
If the base package name does not end with a digit, the version MUST be directly appended to the package name with no intervening separator.
License: ASL 2.0 and MIT
This should be:
License: Apache-2.0 AND MIT
You should also explicitly state in a comment which source files are under MIT (since majority of them are under Apache-2.0).
Patch0: awscli-2.patch
Existence of this patch should be justified.
The package doesn't build. It does build after updating to the latest upstream version (2.11.6) and removing the downstream patch and version cap of prompt-toolkit, but the test suite ends with:
= 96 failed, 64530 passed, 4 skipped, 3 warnings, 97 errors in 518.31s (0:08:38) =
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple
https://bugzilla.redhat.com/show_bug.cgi?id=2049808 Bug 2049808 depends on bug 2179888, which changed state.
Bug 2179888 Summary: Review Request: python-awscrt - Python bindings for the AWS Common Runtime https://bugzilla.redhat.com/show_bug.cgi?id=2179888
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2049808
Nikola Forró nforro@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE Last Closed|2022-03-06 00:45:19 |2023-04-25 07:33:36
--- Comment #6 from Nikola Forró nforro@redhat.com --- Closing this in favor of bug #2189420.
*** This bug has been marked as a duplicate of bug 2189420 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com