[Bug 2183400] New: golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

Bug ID: 2183400
           Summary: golang-github-containerd-btrfs-2 - Btrfs bindings for
                    Go
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://gist.github.com/dghubble/aa2821da4c13927fa9af96cbffebd28a
SRPM URL: https://dghubble.fedorapeople.org/ <- waiting for this to appear
Description: Btrfs bindings for Go
Fedora Account System Username: dghubble

We're working on creating packages to be able to build containerd v1.7.0. See
https://src.fedoraproject.org/rpms/containerd/pull-request/13#comment-135159

Created this review request by following
https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process...

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

Maxwell G  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Maxwell G  ---
I'll take this review :). Here are some initial comments:
> %gometa -f

Remove the `-f` flag and just use plain `%gometa`. The `-f` flag disables
building/testing the
package on i386 which we don't want in this case. We're only using this
flag for new packages that don't have dependents. containerd is still
built for i386.

The package only contains a btrfs-test binary which isn't useful for end
users, so I wouldn't ship it. You'll have to add

```
%global debug_package %{nil}
```

to the beginning of the specfile (right above %bcond_without check is a
standard place, but it doesn't particularly matter) and make the changes
listed below.
> %build
> for cmd in cmd/* ; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done

Remove the entire %build section. We don't want to ship the btrfs-test
binary.
> %install
> %gopkginstall
> install -m 0755 -vd                     %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/

Remove the two install invocations. We're not installing any binaries.
> %files
> %license LICENSE
> %doc README.md
> %{_bindir}/*

Remove this %files section.

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://dghubble.fedorapeople.org/golang-github-containerd-btrfs-2.spec
SRPM URL:
https://dghubble.fedorapeople.org/golang-github-containerd-btrfs-2-2.0.0-1.f...
Description: Btrfs bindings for Go
Fedora Account System Username: dghubble

We're working on creating packages to be able to build containerd v1.7.0. See
https://src.fedoraproject.org/rpms/containerd/pull-request/13#comment-135159

Created this review request by following
https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process...

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

--- Comment #2 from [e-mail] ---
Initial fixes should be there, and updated the links to use fedorapeople.org

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

--- Comment #3 from Maxwell G  ---
[fedora-review-service-build]

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

--- Comment #4 from Maxwell G  ---
Please rebuild the SRPM and upload it again

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

--- Comment #5 from [e-mail] ---
Local mockbuild works and I've uploaded the SRPM.

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

Maxwell G  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST

--- Comment #6 from Maxwell G  ---
This package was generated using go2rpm, which simplifies the review. Normally,
I'd go through the full template generated by the `fedora-review` tool.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The specfile is sane.
- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors
- [x] The package runs tests in %check
- [x] The latest version is packaged.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [x] There are no wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the
Bodhi ticket.

I'll send you a separate email later with instructions since this is your first
Package Review ticket.

Thanks!

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

Maxwell G  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 2183400] golang-github-containerd-btrfs-2 - Btrfs bindings for Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

--- Comment #7 from Maxwell G  ---
> I'll send you a separate email later with instructions since this is your first Package Review ticket.

Sent!

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|golang-github-containerd-bt |New:
                   |rfs-2 - Btrfs bindings for  |golang-github-containerd-bt
                   |Go                          |rfs-2 - Btrfs bindings for
                   |                            |Go

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

--- Comment #8 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-containerd-btrfs-2

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-0416784055 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-0416784055

https://bugzilla.redhat.com/show_bug.cgi?id=2183400

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-04-05 02:39:06

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-0416784055 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.