Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: guayadeque - Music player based on wxWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=585707
Summary: Review Request: guayadeque - Music player based on wxWidgets Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pawelpogorzelski@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://dl.dropbox.com/u/146266/Fedora_Packages/guayadeque.spec SRPM URL: http://dl.dropbox.com/u/146266/Fedora_Packages/guayadeque-0.2.5-1.fc12.src.r... Description: Music Player with the aims to be intuitive, easy to use and fast even for huge music collections. Developed for Linux with wxWidgets for GTK under Gnome. This is my first package try and I seek a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585707
Mohammed Imran imranceh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |imranceh@gmail.com
--- Comment #1 from Mohammed Imran imranceh@gmail.com 2010-04-28 10:07:24 EDT --- Please set BLOCKS to FE-NEEDSPONSOR,so that sponsors can find you.
This is a informal review
Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
Need to Fix these =================
1) Summary is too short Media Player,try to expand it. 2) GROUP should be Applications/Multimedia not Application/media 3)Add gstreamer-devel in Buildrequires too and remove gcc-c++,by default gcc will handle it 4)Source should be http://downloads.sourceforge.net/guayadeque/guayadeque-0.2.5.tar.gz pleas refer https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net 4)Description's each line should be <79 chars 5)Use either tabs or spaces,not both(together) 6)Remove taglib from requires,its handled by rpm 7)README says it needs sqlite3
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec [x] Package meets the Packaging Guidelines. [X] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: [!] Rpmlint output: guayadeque.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) guayadeque.src: E: description-line-too-long Music Player with the aims to be intuitive, easy to use and fast even for huge music collections. Developed for Linux with wxWidgets for GTK under Gnome. guayadeque.src: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) guayadeque.i586: E: explicit-lib-dependency taglib guayadeque.i586: E: description-line-too-long Music Player with the aims to be intuitive, easy to use and fast even for huge music collections. Developed for Linux with wxWidgets for GTK under Gnome. 2 packages and 1 specfiles checked; 3 errors, 2 warnings.
[x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package :4faeeb53f83a0b8329e2bc26b9b992ab MD5SUM upstream package:4faeeb53f83a0b8329e2bc26b9b992ab
[x] Package is not known to require ExcludeArch, OR: Arches excluded: Why:
[!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[x] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585707
--- Comment #2 from Pawel Pogorzelski pawelpogorzelski@gmail.com 2010-04-29 13:08:46 EDT --- All pointed out errors (thanks for showing them up - I'm just learning) fixed (I hope properly). rpmlint (I didn't knew it earlier) shows no errors. SPEC and SRPM in new version replaced the originals (links remain the same). I'll set also the blocks as suggested (didn't found that part on wiki).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585707
Pawel Pogorzelski pawelpogorzelski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585707
--- Comment #3 from Mohammed Imran imranceh@gmail.com 2010-04-30 01:53:12 EDT --- I'm also learning,We're in the Same Boat Brother ;)
Few more things to fix
rpmlint output =============== [imran@localhost SPECS]$ rpmlint guayadeque.spec ../SRPMS/guayadeque-0.2.5-1.fc11.src.rpm ../RPMS/i586/guayadeque-0.2.5-1.fc11.i586.rpm guayadeque.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) guayadeque.src: E: description-line-too-long Music Player with the aims to be intuitive, easy to use and fast even for huge music collections. Developed for Linux with wxWidgets for GTK under Gnome. guayadeque.src: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) guayadeque.i586: E: description-line-too-long Music Player with the aims to be intuitive, easy to use and fast even for huge music collections. Developed for Linux with wxWidgets for GTK under Gnome. 2 packages and 1 specfiles checked; 2 errors, 2 warnings.
* Please refer https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#desc...
* Run rpmlint on both the SRPM and the binary RPMs before uploading them for review
* Increase the "Release" tag every time you upload a new package to avoid confusion. The reviewer and other interested parties probably still have older versions of your SRPM lying around to check what has changed between the old and new packages; those get confused when the revision didn't change.Also change revision number in changelog tag as 0.2.5-2
* No . at the end of summary
Apart from these,spec looks ok to me.
Also refer this URL http://fedoraproject.org/wiki/Koji
For scratch build on koji use command koji build --scratch dist-f14 <SRPM_file>
Best of luck :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585707
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |StalledSubmitter
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2010-11-19 09:30:55 EST --- There doesn't seem to be any response to comment 3, and the links are all dead.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585707
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution| |NOTABUG Status Whiteboard|StalledSubmitter | Last Closed| |2010-12-26 15:31:50
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla