[Bug 1060454] New: Review Request: golang-github-armon-go-metrics - Collect run time and performance metrics in golang software
https://bugzilla.redhat.com/show_bug.cgi?id=1060454
Bug ID: 1060454 Summary: Review Request: golang-github-armon-go-metrics - Collect run time and performance metrics in golang software Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: jeffschroeder@computer.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://www.digitalprognosis.com/opensource/packages/golang-github-armon-go-m... SRPM URL: http://www.digitalprognosis.com/opensource/packages/golang-github-armon-go-m... Description: This library provides a metrics package which can be used to instrument code, expose application metrics, and profile run time performance in a flexible manner. It allows exporting performance and run time metrics to external metrics systems (i.e. statsite, statsd).
Fedora Account System Username: sejeff
[jeff@omniscience SPECS]$ rpmlint golang-github-armon-go-metrics.spec ../SRPMS/golang-github-armon-go-metrics-0-0.1.git8ceaed1d0bc3.fc20.src.rpm ../RPMS/golang-github-armon-go-metrics-devel-0-0.1.git8ceaed1d0bc3.fc20.noarch.rpm golang-github-armon-go-metrics.src: W: spelling-error %description -l en_US statsite -> stat site, stat-site, stateside golang-github-armon-go-metrics.src: W: spelling-error %description -l en_US statsd -> stats, stated, stats d 2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Both statsd and statsite are other projects and are not typos.
https://bugzilla.redhat.com/show_bug.cgi?id=1060454
Jeff Schroeder jeffschroeder@computer.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1060454
Jeff Schroeder jeffschroeder@computer.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Depends On|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1060454
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.mashal@gmail.com
--- Comment #1 from Dan Mashal dan.mashal@gmail.com ---
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/dan/fedora- review/1060454-golang-github-armon-go-metrics/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/dan/fedora-review/1060454-golang-github-armon-go- metrics/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src(golang- github-gorilla-mux-devel, golang-googlecode-net-devel, golang-googlecode- goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang- googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang- github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang- github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode (golang-github-gorilla-mux-devel, golang-googlecode-net-devel, golang- googlecode-goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang-googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode/src/github.com(golang-github-gorilla-mux-devel, golang- github-syndtr-gocapability-devel, golang-github-coreos-go-systemd-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel) [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-armon-go-metrics-devel-0-0.1.git8ceaed1d0bc3.fc20.noarch.rpm golang-github-armon-go-metrics-0-0.1.git8ceaed1d0bc3.fc20.src.rpm golang-github-armon-go-metrics.src: W: spelling-error %description -l en_US statsite -> stat site, stat-site, stateside golang-github-armon-go-metrics.src: W: spelling-error %description -l en_US statsd -> stats, stated, stats d golang-github-armon-go-metrics.src: W: file-size-mismatch armon-go-metrics-8ceaed1.tar.gz = 9512, https://github.com/armon/go-metrics/tarball/master/armon-go-metrics-8ceaed1.... = 9740 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint golang-github-armon-go-metrics-devel 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- golang-github-armon-go-metrics-devel (rpmlib, GLIBC filtered): golang
Provides -------- golang-github-armon-go-metrics-devel: golang(github.com/armon/go-metrics) golang-github-armon-go-metrics-devel
Source checksums ---------------- https://github.com/armon/go-metrics/tarball/master/armon-go-metrics-8ceaed1.... : CHECKSUM(SHA256) this package : 004ccc948eb01c9a66a22297c3b1d5fde22783eb77d1738a62250d8d4e6fadae CHECKSUM(SHA256) upstream package : f7937b3f9c4967f205c1fea7e15c7cfd13ed3afe75a642b6aa88509750326071 diff -r also reports differences
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1060454 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1060454
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lemenkov@gmail.com Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- Removing FE-NEEDSPONSOR - I've just sponsored Jeff.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1060454
Vincent Batts vbatts@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vbatts@redhat.com
--- Comment #3 from Vincent Batts vbatts@redhat.com --- a couple of comments: * %{gopath} need not be defined. it is provided in the 'golang' rpm * ExclusiveArch can be set as "%{go_arches} noarch" * the -devel package also needs BuildArch: noarch
https://bugzilla.redhat.com/show_bug.cgi?id=1060454
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |athoscribeiro@gmail.com Resolution|--- |DUPLICATE Last Closed| |2017-05-01 19:20:22
--- Comment #4 from Athos Ribeiro athoscribeiro@gmail.com ---
*** This bug has been marked as a duplicate of bug 1211990 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla