https://bugzilla.redhat.com/show_bug.cgi?id=1372429
Bug ID: 1372429 Summary: Review Request: openjdk-orb - A downstream fork of OpenJDK's ORB impl Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: puntogil@libero.it QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://gil.fedorapeople.org/openjdk-orb.spec SRPM URL: https://gil.fedorapeople.org/openjdk-orb-8.0.7-1.fc24.src.rpm Description: JBoss repackaging of the OpenJDK ORB. Fedora Account System Username: gil
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15464009
Wildfly 10+ dependency
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1181081
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1181081 [Bug 1181081] wildfly: Upgrade to 10.1.0.Final
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: openjdk-orb |Review Request: openjdk-orb |- A downstream fork of |- A downstream fork of |OpenJDK's ORB impl |OpenJDK's ORB | |implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
Jason Taylor jtfas90@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jtfas90@gmail.com Assignee|nobody@fedoraproject.org |jtfas90@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #1 from Jason Taylor jtfas90@gmail.com --- Hi gil,
looks like Source0 could be updated to
https://github.com/jboss/%%7Bname%7D/archive/%%7Bname%7D-%%7Bnamedversion%7D...
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #2 from Jason Taylor jtfas90@gmail.com --- I don't see a line installing the pom.xml. According to https://fedorahosted.org/released/javapackages/doc/ it looks like there should be a:
%mvn_artifact pom.xml
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #3 from gil cattaneo puntogil@libero.it --- (In reply to Jason Taylor from comment #2)
I don't see a line installing the pom.xml. According to https://fedorahosted.org/released/javapackages/doc/ it looks like there should be a:
%mvn_artifact pom.xml
This should be done only when is used an ant build style all artifacts (pom and jar) are installed with %mvn_install https://fedorahosted.org/released/javapackages/doc/#ant https://fedorahosted.org/released/javapackages/doc/#maven the guideline is not update, now, "%dir %{_javadir}/%{name}" is useless because is already owned
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #4 from gil cattaneo puntogil@libero.it ---
(In reply to Jason Taylor from comment #1)
Hi gil,
looks like Source0 could be updated to
https://github.com/jboss/%%7Bname%7D/archive/%%7Bname%7D-%%7Bnamedversion%7D...
for me is useless. it should be at the discretion of the packager
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
Jason Taylor jtfas90@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Jason Taylor jtfas90@gmail.com --- Looks good then, I see you opened a couple of tickets with upstream regarding the misc licensing fixes.
Must and Should components appear to be satisfied. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #6 from gil cattaneo puntogil@libero.it --- (In reply to Jason Taylor from comment #5)
Looks good then, I see you opened a couple of tickets with upstream regarding the misc licensing fixes.
Must and Should components appear to be satisfied. Package approved.
Thanks! Please, set Status field as ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
Jason Taylor jtfas90@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #7 from gil cattaneo puntogil@libero.it --- Thanks for the review!
create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/7647 https://admin.fedoraproject.org/pkgdb/package/requests/7648
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/openjdk-orb
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- openjdk-orb-8.0.7-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1372429
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-09-09 17:48:40
package-review@lists.fedoraproject.org