https://bugzilla.redhat.com/show_bug.cgi?id=2236866
Bug ID: 2236866 Summary: Review Request: rust-gix-attributes - Gix implemenation for handling git attributes files Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/rust-gix-attributes/rust-gix-attributes.spe... SRPM URL: https://blinxen.fedorapeople.org/rust-gix-attributes/rust-gix-attributes-0.1...
Description: Gix implemenation for handling git attributes files.
Fedora Account System Username: blinxen
https://bugzilla.redhat.com/show_bug.cgi?id=2236866
--- Comment #1 from blinxen h-k-81@hotmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=105629486
https://bugzilla.redhat.com/show_bug.cgi?id=2236866
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Status|NEW |ASSIGNED
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Error: Problem: conflicting requests - nothing provides (crate(document-features/default) >= 0.2.1 with crate(document-features/default) < 0.3.0~) needed by rust-gix-attributes+document-features-devel-0.16.0-1.fc40.noarch from @commandline
You need to remove the document-features optional dependency, just like in most other gix packages.
https://bugzilla.redhat.com/show_bug.cgi?id=2236866
--- Comment #3 from blinxen h-k-81@hotmail.com --- Updated to the latest version
Links to the updated files: Spec URL: https://blinxen.fedorapeople.org/rust-gix-attributes/rust-gix-attributes.spe... SRPM URL: https://blinxen.fedorapeople.org/rust-gix-attributes/rust-gix-attributes-0.1...
https://bugzilla.redhat.com/show_bug.cgi?id=2236866
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks, looks good to me.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2236866
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-attributes
https://bugzilla.redhat.com/show_bug.cgi?id=2236866
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-51fd6e136b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-51fd6e136b
https://bugzilla.redhat.com/show_bug.cgi?id=2236866
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-09-17 18:41:07
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-51fd6e136b has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org